The Trunk: System-cwp.526.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: System-cwp.526.mcz

commits-2
Colin Putney uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-cwp.526.mcz

==================== Summary ====================

Name: System-cwp.526
Author: cwp
Time: 28 April 2013, 10:43:06.298 am
UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c
Ancestors: System-ul.525

Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler.

=============== Diff against System-ul.525 ===============

Item was changed:
  ----- Method: Behavior>>allCallsOn (in category '*System-Support') -----
  allCallsOn
  "Answer a SortedCollection of all the methods that refer to me by name or as part of an association in a global dict."
 
  | theClass |
  theClass := self theNonMetaClass.
+ ^(self  systemNavigation allCallsOn:  (self environment bindingOf: theClass name)),
- ^(self  systemNavigation allCallsOn:  (self environment associationAt: theClass name)),
   (Preferences thoroughSenders
  ifTrue: [OrderedCollection new]
  ifFalse: [self  systemNavigation allCallsOn: theClass name]),
   (self systemNavigation allClasses
  select: [:c| c sharedPools includes: theClass]
  thenCollect:
  [:c|
  ClassReference new
  setClassSymbol: c name
  classIsMeta: false
  stringVersion: c name])!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.526.mcz

Frank Shearar-3
On 28 April 2013 18:44,  <[hidden email]> wrote:

> Colin Putney uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-cwp.526.mcz
>
> ==================== Summary ====================
>
> Name: System-cwp.526
> Author: cwp
> Time: 28 April 2013, 10:43:06.298 am
> UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c
> Ancestors: System-ul.525
>
> Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler.
>
> =============== Diff against System-ul.525 ===============


Also, #bindingOf: is the right protocol to use; Colin's keen on moving
Environments away from Dictionary's API.

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.526.mcz

Chris Muller-3
In reply to this post by commits-2
Thanks but is it working for you?  I'm still missing tons of
references to Error when I browse for them.

Also, I know you didn't change this but the ifTrue:ifFalse: blocks
look backward for the Preferences thoroughSenders question in this
method.

On Sun, Apr 28, 2013 at 12:44 PM,  <[hidden email]> wrote:

> Colin Putney uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-cwp.526.mcz
>
> ==================== Summary ====================
>
> Name: System-cwp.526
> Author: cwp
> Time: 28 April 2013, 10:43:06.298 am
> UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c
> Ancestors: System-ul.525
>
> Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler.
>
> =============== Diff against System-ul.525 ===============
>
> Item was changed:
>   ----- Method: Behavior>>allCallsOn (in category '*System-Support') -----
>   allCallsOn
>         "Answer a SortedCollection of all the methods that refer to me by name or as part of an association in a global dict."
>
>         | theClass |
>         theClass := self theNonMetaClass.
> +       ^(self  systemNavigation allCallsOn:  (self environment bindingOf: theClass name)),
> -       ^(self  systemNavigation allCallsOn:  (self environment associationAt: theClass name)),
>           (Preferences thoroughSenders
>                 ifTrue: [OrderedCollection new]
>                 ifFalse: [self  systemNavigation allCallsOn: theClass name]),
>           (self systemNavigation allClasses
>                 select: [:c| c sharedPools includes: theClass]
>                 thenCollect:
>                         [:c|
>                         ClassReference new
>                                 setClassSymbol: c name
>                                 classIsMeta: false
>                                 stringVersion: c name])!
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.526.mcz

Chris Muller-3
In reply to this post by commits-2
Do we need to put out a new alpha image with a recompileAll?

On Sun, Apr 28, 2013 at 12:44 PM,  <[hidden email]> wrote:

> Colin Putney uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-cwp.526.mcz
>
> ==================== Summary ====================
>
> Name: System-cwp.526
> Author: cwp
> Time: 28 April 2013, 10:43:06.298 am
> UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c
> Ancestors: System-ul.525
>
> Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler.
>
> =============== Diff against System-ul.525 ===============
>
> Item was changed:
>   ----- Method: Behavior>>allCallsOn (in category '*System-Support') -----
>   allCallsOn
>         "Answer a SortedCollection of all the methods that refer to me by name or as part of an association in a global dict."
>
>         | theClass |
>         theClass := self theNonMetaClass.
> +       ^(self  systemNavigation allCallsOn:  (self environment bindingOf: theClass name)),
> -       ^(self  systemNavigation allCallsOn:  (self environment associationAt: theClass name)),
>           (Preferences thoroughSenders
>                 ifTrue: [OrderedCollection new]
>                 ifFalse: [self  systemNavigation allCallsOn: theClass name]),
>           (self systemNavigation allClasses
>                 select: [:c| c sharedPools includes: theClass]
>                 thenCollect:
>                         [:c|
>                         ClassReference new
>                                 setClassSymbol: c name
>                                 classIsMeta: false
>                                 stringVersion: c name])!
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.526.mcz

Frank Shearar-3
As in publish one to ftp.squeak.org? I don't see how it could hurt.
Tobias would also like to publish a Seaside-on-4.5 image too, IIRC.
(Apologies for my lack of response there, Tobias.)

frank

On 29 April 2013 01:34, Chris Muller <[hidden email]> wrote:

> Do we need to put out a new alpha image with a recompileAll?
>
> On Sun, Apr 28, 2013 at 12:44 PM,  <[hidden email]> wrote:
>> Colin Putney uploaded a new version of System to project The Trunk:
>> http://source.squeak.org/trunk/System-cwp.526.mcz
>>
>> ==================== Summary ====================
>>
>> Name: System-cwp.526
>> Author: cwp
>> Time: 28 April 2013, 10:43:06.298 am
>> UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c
>> Ancestors: System-ul.525
>>
>> Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler.
>>
>> =============== Diff against System-ul.525 ===============
>>
>> Item was changed:
>>   ----- Method: Behavior>>allCallsOn (in category '*System-Support') -----
>>   allCallsOn
>>         "Answer a SortedCollection of all the methods that refer to me by name or as part of an association in a global dict."
>>
>>         | theClass |
>>         theClass := self theNonMetaClass.
>> +       ^(self  systemNavigation allCallsOn:  (self environment bindingOf: theClass name)),
>> -       ^(self  systemNavigation allCallsOn:  (self environment associationAt: theClass name)),
>>           (Preferences thoroughSenders
>>                 ifTrue: [OrderedCollection new]
>>                 ifFalse: [self  systemNavigation allCallsOn: theClass name]),
>>           (self systemNavigation allClasses
>>                 select: [:c| c sharedPools includes: theClass]
>>                 thenCollect:
>>                         [:c|
>>                         ClassReference new
>>                                 setClassSymbol: c name
>>                                 classIsMeta: false
>>                                 stringVersion: c name])!
>>
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.526.mcz

Colin Putney-3
In reply to this post by Chris Muller-3



On Sun, Apr 28, 2013 at 5:34 PM, Chris Muller <[hidden email]> wrote:
Do we need to put out a new alpha image with a recompileAll?

Yeah, that would be good.

But it won't work at the moment, because Encoder>>litIndex: has a halt in it. Eliot, the method has your initials. Do you remember what that was for? 

Colin


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.526.mcz

Frank Shearar-3
On 29 April 2013 08:17, Colin Putney <[hidden email]> wrote:

>
>
>
> On Sun, Apr 28, 2013 at 5:34 PM, Chris Muller <[hidden email]> wrote:
>>
>> Do we need to put out a new alpha image with a recompileAll?
>
>
> Yeah, that would be good.
>
> But it won't work at the moment, because Encoder>>litIndex: has a halt in
> it. Eliot, the method has your initials. Do you remember what that was for?

Why won't it work? In practice, I mean, not in theory.
ReleaseSqueakTrunk's artifact has had a recompileAll, as part of
ReleaseBuilderFor4dot5 prepareNewBuild.

(But don't bother checking Squeak4.5-12475 or earlier; SOMEONE left
the ToolSet set to CommandLineToolSet, which means the image will quit
very quickly with a stacktrace on stdout. *ahem*. I've fixed the
problem and the next build should work.

frank

> Colin
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.526.mcz

Nicolas Cellier
In reply to this post by Colin Putney-3
I've reverted the halt - it's probably only for debugging purpose.


2013/4/29 Colin Putney <[hidden email]>



On Sun, Apr 28, 2013 at 5:34 PM, Chris Muller <[hidden email]> wrote:
Do we need to put out a new alpha image with a recompileAll?

Yeah, that would be good.

But it won't work at the moment, because Encoder>>litIndex: has a halt in it. Eliot, the method has your initials. Do you remember what that was for? 

Colin






Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.526.mcz

Colin Putney-3
In reply to this post by Frank Shearar-3
On 2013-04-29, at 2:52 AM, Frank Shearar <[hidden email]> wrote:

> Why won't it work? In practice, I mean, not in theory.

Oh, just 'cause that method is part of the compiler, and recompileAll
will eventually trigger the halt.

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.526.mcz

Frank Shearar-3
On 29 April 2013 15:40, Colin Putney <[hidden email]> wrote:
> On 2013-04-29, at 2:52 AM, Frank Shearar <[hidden email]> wrote:
>
>> Why won't it work? In practice, I mean, not in theory.
>
> Oh, just 'cause that method is part of the compiler, and recompileAll
> will eventually trigger the halt.

OK, so happenstance that it hadn't yet happened.

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.526.mcz

Colin Putney-3
On 2013-04-29, at 7:47 AM, Frank Shearar <[hidden email]> wrote:

> On 29 April 2013 15:40, Colin Putney <[hidden email]> wrote:
>> On 2013-04-29, at 2:52 AM, Frank Shearar <[hidden email]> wrote:
>>
>>> Why won't it work? In practice, I mean, not in theory.
>>
>> Oh, just 'cause that method is part of the compiler, and recompileAll
>> will eventually trigger the halt.
>
> OK, so happenstance that it hadn't yet happened.

Well, it happened when I tried to recompile my image. I admit I may
have over-generalized from that experience. :-)