The Trunk: System-dtl.1233.mcz

>
> David T. Lewis uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-dtl.1233.mcz
>
> ==================== Summary ====================
>
> Name: System-dtl.1233
> Author: dtl
> Time: 15 May 2021, 1:25:37.809444 pm
> UUID: 660215fe-f151-4184-8a31-8775202baa81
> Ancestors: System-nice.1232
>
> Be permissive when filing in Cuis packages. Skip chunks that begin with known extensions that are not meaningful for Squeak, logging to Transcript to show chunks that have been ignored.
>
> =============== Diff against System-nice.1232 ===============
>
> Item was changed:
>   ----- Method: PositionableStream>>fileInAnnouncing: (in category '*System-Changes-fileIn/Out') -----
>   fileInAnnouncing: announcement
>         "This is special for reading expressions from text that has been formatted
>         with exclamation delimitors. The expressions are read and passed to the
>         Compiler. Answer the result of compilation.  Put up a progress report with
>        the given announcement as the title."
>
>         | val |
>         announcement
>                 displayProgressFrom: 0
>                 to: self size
>                 during:
>                         [:bar |
>                         [self atEnd] whileFalse:
>                                         [bar value: self position.
>                                         self skipSeparators.
>
>                                         [ | chunk |
>                                         val := (self peekFor: $!!)
> +                                                               ifTrue: [ | ch |
> +                                                                       ch := self nextChunk.
> +                                                                       (self shouldIgnore: ch)
> +                                                                               ifTrue: [Transcript showln: 'Ignoring chunk: ', ch]
> +                                                                               ifFalse: [(Compiler evaluate: ch logged: true) scanFrom: self]]
> -                                                               ifTrue: [(Compiler evaluate: self nextChunk logged: true) scanFrom: self]
>                                                                 ifFalse:
>                                                                         [chunk := self nextChunk.
>                                                                         self checkForPreamble: chunk.
>                                                                         Compiler evaluate: chunk logged: true]]
>                                                         on: InMidstOfFileinNotification
>                                                         do: [:ex | ex resume: true].
>                                         self skipStyleChunk].
>                         self close].
>         "Note:  The main purpose of this banner is to flush the changes file."
>         Smalltalk logChange: '----End fileIn of ' , self name , '----'.
>         self flag: #ThisMethodShouldNotBeThere. "sd"
>         ^val!
>
> Item was added:
> + ----- Method: PositionableStream>>shouldIgnore: (in category '*System-Changes-fileIn/Out') -----
> + shouldIgnore: chunk
> +       "Fileouts created on another Smalltalk may contain chunks that are
> +       not meaningful for Squeak. Answer true if chunk should be ignored."
> +
> +       ^ ((chunk beginsWith: 'provides:') "Cuis Smalltalk extensions"
> +               or: [chunk beginsWith: 'requires:'])
> +                       or: [chunk beginsWith: 'classDefinition:']
> + !
>
>

>
> On Sat, May 15, 2021 at 12:25 PM <[hidden email]> wrote:
> >
> > David T. Lewis uploaded a new version of System to project The Trunk:
> > http://source.squeak.org/trunk/System-dtl.1233.mcz
> >
> > ==================== Summary ====================
> >
> > Name: System-dtl.1233
> > Author: dtl
> > Time: 15 May 2021, 1:25:37.809444 pm
> > UUID: 660215fe-f151-4184-8a31-8775202baa81
> > Ancestors: System-nice.1232
> >
> > Be permissive when filing in Cuis packages. Skip chunks that begin with known extensions that are not meaningful for Squeak, logging to Transcript to show chunks that have been ignored.
> >
> > =============== Diff against System-nice.1232 ===============
> >
> > Item was changed:
> >   ----- Method: PositionableStream>>fileInAnnouncing: (in category '*System-Changes-fileIn/Out') -----
> >   fileInAnnouncing: announcement
> >         "This is special for reading expressions from text that has been formatted
> >         with exclamation delimitors. The expressions are read and passed to the
> >         Compiler. Answer the result of compilation.  Put up a progress report with
> >        the given announcement as the title."
> >
> >         | val |
> >         announcement
> >                 displayProgressFrom: 0
> >                 to: self size
> >                 during:
> >                         [:bar |
> >                         [self atEnd] whileFalse:
> >                                         [bar value: self position.
> >                                         self skipSeparators.
> >
> >                                         [ | chunk |
> >                                         val := (self peekFor: $!!)
> > +                                                               ifTrue: [ | ch |
> > +                                                                       ch := self nextChunk.
> > +                                                                       (self shouldIgnore: ch)
> > +                                                                               ifTrue: [Transcript showln: 'Ignoring chunk: ', ch]
> > +                                                                               ifFalse: [(Compiler evaluate: ch logged: true) scanFrom: self]]
> > -                                                               ifTrue: [(Compiler evaluate: self nextChunk logged: true) scanFrom: self]
> >                                                                 ifFalse:
> >                                                                         [chunk := self nextChunk.
> >                                                                         self checkForPreamble: chunk.
> >                                                                         Compiler evaluate: chunk logged: true]]
> >                                                         on: InMidstOfFileinNotification
> >                                                         do: [:ex | ex resume: true].
> >                                         self skipStyleChunk].
> >                         self close].
> >         "Note:  The main purpose of this banner is to flush the changes file."
> >         Smalltalk logChange: '----End fileIn of ' , self name , '----'.
> >         self flag: #ThisMethodShouldNotBeThere. "sd"
> >         ^val!
> >
> > + ----- Method: PositionableStream>>shouldIgnore: (in category '*System-Changes-fileIn/Out') -----
> > + shouldIgnore: chunk
> > +       "Fileouts created on another Smalltalk may contain chunks that are
> > +       not meaningful for Squeak. Answer true if chunk should be ignored."
> > +
> > +       ^ ((chunk beginsWith: 'provides:') "Cuis Smalltalk extensions"
> > +               or: [chunk beginsWith: 'requires:'])
> > +                       or: [chunk beginsWith: 'classDefinition:']
> > + !
> >
> >
>
> > Item was added:

>>
>> And as explained in the commit comment:
>>
>>   Skip chunks that begin with known extensions that are not meaningful
>>   for Squeak, logging to Transcript to show chunks that have been ignored.
>
>
> Magma implements a method called #classDefinition:.  I wanted to make sure this wouldn't cause it to get skipped.  My test of filing out a single method and also the whole class, seemed to work okay.
>
>>
>> With respect to the Cuis reference, my use case was installing
>> VectorEnginePlugin in Squeak. The upstream repository for this plugin
>> is on GitHub, which stores the portable Smalltalk code in chunk format
>> with some Cuis extensions:
>>
>>   https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/blob/master/Packages/Features/VectorEnginePlugin.pck.st
>>
>> The plugin code is well-written and portable for at least Squeak and Cuis.
>> The Cuis-specific chunks are not relevant to Squeak, so they can and
>> should be ignored when filing in to Squeak.
>
>
> Does this mean we can generally load Cuis code into Squeak now?  That almost seems [ANN]-worthy.   :)
>
>  - Chris
>

> Le mer. 19 mai 2021 ?? 04:22, Chris Muller <[hidden email]> a ??crit :
> >>
> >> And as explained in the commit comment:
> >>
> >>   Skip chunks that begin with known extensions that are not meaningful
> >>   for Squeak, logging to Transcript to show chunks that have been ignored.
> >
> >
> > Magma implements a method called #classDefinition:.  I wanted to make sure this wouldn't cause it to get skipped.  My test of filing out a single method and also the whole class, seemed to work okay.
> >
> >>
> >> With respect to the Cuis reference, my use case was installing
> >> VectorEnginePlugin in Squeak. The upstream repository for this plugin
> >> is on GitHub, which stores the portable Smalltalk code in chunk format
> >> with some Cuis extensions:
> >>
> >>   https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/blob/master/Packages/Features/VectorEnginePlugin.pck.st
> >>
> >> The plugin code is well-written and portable for at least Squeak and Cuis.
> >> The Cuis-specific chunks are not relevant to Squeak, so they can and
> >> should be ignored when filing in to Squeak.
> >
> >
> > Does this mean we can generally load Cuis code into Squeak now?  That almost seems [ANN]-worthy.   :)
> >
> >  - Chris
> >
>