David T. Lewis uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-dtl.512.mcz ==================== Summary ==================== Name: System-dtl.512 Author: dtl Time: 17 January 2013, 8:12:00.656 pm UUID: 3e96758d-c221-4b54-bc03-b8a66e2ca3cd Ancestors: System-fbs.511 Only the instance of SystemOrganizer that is the global SystemOrganization should send change notifications to the singleton SystemChangeNotifier. Addresses the case of a FileContentsBrowser that uses a new SystemOrganization to load code for browsing and should not initiate a system change notification for the class being browsed, as reported by Bob Arning on squeak-dev http://lists.squeakfoundation.org/pipermail/squeak-dev/2013-January/167941.html =============== Diff against System-fbs.511 =============== Item was changed: ----- Method: SystemOrganizer>>addCategory:before: (in category 'accessing') ----- addCategory: catString before: nextCategory + self == SystemOrganization ifTrue: [ + SystemChangeNotifier uniqueInstance + doSilently: [super addCategory: catString before: nextCategory]; + classCategoryAdded: catString]! - SystemChangeNotifier uniqueInstance - doSilently: [super addCategory: catString before: nextCategory]; - classCategoryAdded: catString! Item was changed: ----- Method: SystemOrganizer>>classify:under: (in category 'accessing') ----- classify: element under: newCategory | oldCategory class | oldCategory := self categoryOfElement: element. super classify: element under: newCategory. class := Smalltalk at: element ifAbsent: [^ self]. + self == SystemOrganization ifTrue: [ + SystemChangeNotifier uniqueInstance + class: class + recategorizedFrom: oldCategory + to: newCategory]! - SystemChangeNotifier uniqueInstance - class: class - recategorizedFrom: oldCategory - to: newCategory ! Item was changed: ----- Method: SystemOrganizer>>removeCategory: (in category 'accessing') ----- removeCategory: cat | r | r := super removeCategory: cat. + self == SystemOrganization + ifTrue: [SystemChangeNotifier uniqueInstance classCategoryRemoved: cat]. - SystemChangeNotifier uniqueInstance classCategoryRemoved: cat. ^ r! Item was changed: ----- Method: SystemOrganizer>>renameCategory:toBe: (in category 'accessing') ----- renameCategory: oldCatString toBe: newCatString | r | r := super renameCategory: oldCatString toBe: newCatString. + self == SystemOrganization ifTrue: [ + SystemChangeNotifier uniqueInstance + classCategoryRenamedFrom: oldCatString to: newCatString]. - SystemChangeNotifier uniqueInstance - classCategoryRenamedFrom: oldCatString to: newCatString. ^ r! |
On 20 January 2013 17:54, <[hidden email]> wrote:
> David T. Lewis uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-dtl.512.mcz > > ==================== Summary ==================== > > Name: System-dtl.512 > Author: dtl > Time: 17 January 2013, 8:12:00.656 pm > UUID: 3e96758d-c221-4b54-bc03-b8a66e2ca3cd > Ancestors: System-fbs.511 > > Only the instance of SystemOrganizer that is the global SystemOrganization should send change notifications to the singleton SystemChangeNotifier. > > Addresses the case of a FileContentsBrowser that uses a new SystemOrganization to load code for browsing and should not initiate a system change notification for the class being browsed, as reported by Bob Arning on squeak-dev http://lists.squeakfoundation.org/pipermail/squeak-dev/2013-January/167941.html > > =============== Diff against System-fbs.511 =============== I've taken the liberty of updating http://bugs.squeak.org/view.php?id=7719 accordingly. frank |
Free forum by Nabble | Edit this page |