The Trunk: System-dtl.560.mcz

> David T. Lewis uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-dtl.560.mcz
>
> ==================== Summary ====================
>
> Name: System-dtl.560
> Author: dtl
> Time: 8 July 2013, 1:15:09.698 am
> UUID: f9176e6f-41f5-4bec-a2d0-a15717fabdeb
> Ancestors: System-fbs.559
>
> Add ST80Tools and ST80Tests to the list of packages to be unloaded in #unloadAllKnownPackages. These are new package categories that should be unloaded as part of MVC unloading.
>
> =============== Diff against System-fbs.559 ===============
>
> Item was changed:
>   ----- Method: SmalltalkImage>>unloadAllKnownPackages (in category 'shrinking') -----
>   unloadAllKnownPackages
>         "Unload all packages we know how to unload and reload"
>
>         "Prepare unloading"
>         Smalltalk zapMVCprojects.
>         Flaps disableGlobalFlaps: false.
>         StandardScriptingSystem removeUnreferencedPlayers.
>         Project removeAllButCurrent.
>         #('Morphic-UserObjects' 'EToy-UserObjects' 'Morphic-Imported' )
>                 do: [:each | SystemOrganization removeSystemCategory: each].
>         Smalltalk at: #ServiceRegistry ifPresent:[:aClass|
>                 SystemChangeNotifier uniqueInstance
>                         noMoreNotificationsFor: aClass.
>         ].
>         World removeAllMorphs.
>
>         "Go unloading"
>         #(      'ReleaseBuilder' 'ScriptLoader'
>                 '311Deprecated' '39Deprecated'
>                 'Universes' 'SMLoader' 'SMBase' 'Installer-Core'
>                 'VersionNumberTests' 'VersionNumber'
>                 'Services-Base' 'PreferenceBrowser' 'Nebraska'
> +               'ToolBuilder-MVC' 'ST80Tools' 'ST80Tests' 'ST80'

> On 8 July 2013 06:15,  <[hidden email]> wrote:
> > David T. Lewis uploaded a new version of System to project The Trunk:
> > http://source.squeak.org/trunk/System-dtl.560.mcz
> >
> > ==================== Summary ====================
> >
> > Name: System-dtl.560
> > Author: dtl
> > Time: 8 July 2013, 1:15:09.698 am
> > UUID: f9176e6f-41f5-4bec-a2d0-a15717fabdeb
> > Ancestors: System-fbs.559
> >
> > Add ST80Tools and ST80Tests to the list of packages to be unloaded in #unloadAllKnownPackages. These are new package categories that should be unloaded as part of MVC unloading.
> >
> > =============== Diff against System-fbs.559 ===============
> >
> > Item was changed:
> >   ----- Method: SmalltalkImage>>unloadAllKnownPackages (in category 'shrinking') -----
> >   unloadAllKnownPackages
> >         "Unload all packages we know how to unload and reload"
> >
> >         "Prepare unloading"
> >         Smalltalk zapMVCprojects.
> >         Flaps disableGlobalFlaps: false.
> >         StandardScriptingSystem removeUnreferencedPlayers.
> >         Project removeAllButCurrent.
> >         #('Morphic-UserObjects' 'EToy-UserObjects' 'Morphic-Imported' )
> >                 do: [:each | SystemOrganization removeSystemCategory: each].
> >         Smalltalk at: #ServiceRegistry ifPresent:[:aClass|
> >                 SystemChangeNotifier uniqueInstance
> >                         noMoreNotificationsFor: aClass.
> >         ].
> >         World removeAllMorphs.
> >
> >         "Go unloading"
> >         #(      'ReleaseBuilder' 'ScriptLoader'
> >                 '311Deprecated' '39Deprecated'
> >                 'Universes' 'SMLoader' 'SMBase' 'Installer-Core'
> >                 'VersionNumberTests' 'VersionNumber'
> >                 'Services-Base' 'PreferenceBrowser' 'Nebraska'
> > +               'ToolBuilder-MVC' 'ST80Tools' 'ST80Tests' 'ST80'
>
> Thanks, Dave. I remembered to edit ReleaseBuilder class >>
> #loadWellKnownPackages, but not this guy!
>
> Oh, and 45Deprecated can go here too.
>
> But... how can we verify that this guy still works?
>

> On Mon, Jul 08, 2013 at 08:01:32AM +0100, Frank Shearar wrote:
>> On 8 July 2013 06:15,  <[hidden email]> wrote:
>> > David T. Lewis uploaded a new version of System to project The Trunk:
>> > http://source.squeak.org/trunk/System-dtl.560.mcz
>> >
>> > ==================== Summary ====================
>> >
>> > Name: System-dtl.560
>> > Author: dtl
>> > Time: 8 July 2013, 1:15:09.698 am
>> > UUID: f9176e6f-41f5-4bec-a2d0-a15717fabdeb
>> > Ancestors: System-fbs.559
>> >
>> > Add ST80Tools and ST80Tests to the list of packages to be unloaded in #unloadAllKnownPackages. These are new package categories that should be unloaded as part of MVC unloading.
>> >
>> > =============== Diff against System-fbs.559 ===============
>> >
>> > Item was changed:
>> >   ----- Method: SmalltalkImage>>unloadAllKnownPackages (in category 'shrinking') -----
>> >   unloadAllKnownPackages
>> >         "Unload all packages we know how to unload and reload"
>> >
>> >         "Prepare unloading"
>> >         Smalltalk zapMVCprojects.
>> >         Flaps disableGlobalFlaps: false.
>> >         StandardScriptingSystem removeUnreferencedPlayers.
>> >         Project removeAllButCurrent.
>> >         #('Morphic-UserObjects' 'EToy-UserObjects' 'Morphic-Imported' )
>> >                 do: [:each | SystemOrganization removeSystemCategory: each].
>> >         Smalltalk at: #ServiceRegistry ifPresent:[:aClass|
>> >                 SystemChangeNotifier uniqueInstance
>> >                         noMoreNotificationsFor: aClass.
>> >         ].
>> >         World removeAllMorphs.
>> >
>> >         "Go unloading"
>> >         #(      'ReleaseBuilder' 'ScriptLoader'
>> >                 '311Deprecated' '39Deprecated'
>> >                 'Universes' 'SMLoader' 'SMBase' 'Installer-Core'
>> >                 'VersionNumberTests' 'VersionNumber'
>> >                 'Services-Base' 'PreferenceBrowser' 'Nebraska'
>> > +               'ToolBuilder-MVC' 'ST80Tools' 'ST80Tests' 'ST80'
>>
>> Thanks, Dave. I remembered to edit ReleaseBuilder class >>
>> #loadWellKnownPackages, but not this guy!
>>
>> Oh, and 45Deprecated can go here too.
>>
>> But... how can we verify that this guy still works?
>>
>
> Good question. At this point it is clearly a manual verification. Try doing
> the unload, see if the resulting image still works and does not have
> references to the unloaded packages. It would be nice if we could automate
> that in the form of a test, but I don't know how to do it.
>
> Dave
>
>

> On Tue, Jul 16, 2013 at 11:49:18AM +0100, Frank Shearar wrote:
>> So when I unloaded ST80, I should also have unloaded ToolBuilder-MVC.
>> I've now done that, making the SqueakTrunk build much happier. ST80
>> and ToolBuilder-MVC continue to be tested (and they pass their tests
>> currently) in the ExternalPackages job.
>>
>> Dave, I'd appreciate it if you could take a latest-and-greatest
>> ReleaseSqueakTrunk artifact and play around with ST80 in it.
>> Everything _should_ Just Work.
>>
>
> I loaded MVC back into the Squeak4.5-12579 image from ReleaseSqueakTrunk
> (packages ST80, ST80Tools, ST80Tests, and ToolBuilder-MVC). I saw no new
> problems and all seems to work fine, just a little faster than usual due
> to the smaller image. Nice :-)
>
> Unrelated to MVC, I did accidentally notice that "Object new open" crashes
> the VM in this image rather than opening a debugger, we'll have to see
> what's up with that.

>
>
> On Tue, Jul 16, 2013 at 5:11 AM, Frank Shearar <[hidden email]>
> wrote:
>>
>> On 16 July 2013 12:46, David T. Lewis <[hidden email]> wrote:
>> > On Tue, Jul 16, 2013 at 11:49:18AM +0100, Frank Shearar wrote:
>> >> So when I unloaded ST80, I should also have unloaded ToolBuilder-MVC.
>> >> I've now done that, making the SqueakTrunk build much happier. ST80
>> >> and ToolBuilder-MVC continue to be tested (and they pass their tests
>> >> currently) in the ExternalPackages job.
>> >>
>> >> Dave, I'd appreciate it if you could take a latest-and-greatest
>> >> ReleaseSqueakTrunk artifact and play around with ST80 in it.
>> >> Everything _should_ Just Work.
>> >>
>> >
>> > I loaded MVC back into the Squeak4.5-12579 image from ReleaseSqueakTrunk
>> > (packages ST80, ST80Tools, ST80Tests, and ToolBuilder-MVC). I saw no new
>> > problems and all seems to work fine, just a little faster than usual due
>> > to the smaller image. Nice :-)
>> >
>> > Unrelated to MVC, I did accidentally notice that "Object new open"
>> > crashes
>> > the VM in this image rather than opening a debugger, we'll have to see
>> > what's up with that.
>>
>> Hm, I wonder if the ToolSet's correctly set back to the
>> StandardToolSet rather than CommandLineToolSet.
>
>
> That's the issue.
>
> 0xbffb3efc I SmalltalkImage>snapshot:andQuit:embedded: 0x139515b8: a(n)
> SmalltalkImage
> 0xbffb3f28 I SmalltalkImage>snapshot:andQuit: 0x139515b8: a(n)
> SmalltalkImage
> 0xbffb2e28 I CommandLineToolSet class>debugError: 0x1443106c: a(n)
> CommandLineToolSet class
> 0xbffb2e50 I ToolSet class>debugError: 0x139261e4: a(n) ToolSet class
> 0xbffb2e74 I UnhandledError>defaultAction 0x1473a134: a(n) UnhandledError
> 0xbffb2e90 M UndefinedObject>handleSignal: 0x1360a004: a(n) UndefinedObject
> 0xbffb2eb0 M MethodContext(ContextPart)>handleSignal: 0x14739f64: a(n)
> MethodContext
> 0xbffb2ed0 M MethodContext(ContextPart)>handleSignal: 0x14739f08: a(n)
> MethodContext
> 0xbffb2eec M UnhandledError(Exception)>signal 0x1473a134: a(n)
> UnhandledError
> 0xbffb2f0c I UnhandledError class>signalForException: 0x13927100: a(n)
> UnhandledError class
> 0xbffb2f30 I Halt>defaultAction 0x14739e38: a(n) Halt
> 0xbffb257c M UndefinedObject>handleSignal: 0x1360a004: a(n) UndefinedObject
> 0xbffb259c M MethodContext(ContextPart)>handleSignal: 0x14739f64: a(n)
> MethodContext
> 0xbffb25bc M MethodContext(ContextPart)>handleSignal: 0x14739f08: a(n)
> MethodContext
> 0xbffb25d8 M Halt(Exception)>signal 0x14739e38: a(n) Halt
> 0xbffb25f8 I Halt class(Exception class)>signal 0x13927204: a(n) Halt class
> 0xbffb2618 I UndefinedObject(Object)>halt 0x1360a004: a(n) UndefinedObject
> 0xbffb2630 M UndefinedObject()>? 0x1360a004: a(n) UndefinedObject
> 0xbffb2668 I Compiler>evaluate:cue:ifFail:logged: 0x146b25f4: a(n) Compiler
>
>>
>>
>> frank
>>
>> > Dave
>> >
>> >
>>
>
>
>
> --
> best,
> Eliot
>
>
>

> https://github.com/squeak-smalltalk/squeak-ci/blob/master/release.st
> shows that it's perfectly possible. Really what I'd like is to be able
> to say "fail, and return a failing exit status". IIRC that required VM
> level changes, which we half have? [1]
>
> [1] https://github.com/squeak-smalltalk/squeak-ci/issues/14
>
> frank
>
> On 18 July 2013 19:16, Eliot Miranda <[hidden email]> wrote:
>>
>>
>> On Tue, Jul 16, 2013 at 5:11 AM, Frank Shearar <[hidden email]>
>> wrote:
>>>
>>> On 16 July 2013 12:46, David T. Lewis <[hidden email]> wrote:
>>> > On Tue, Jul 16, 2013 at 11:49:18AM +0100, Frank Shearar wrote:
>>> >> So when I unloaded ST80, I should also have unloaded ToolBuilder-MVC.
>>> >> I've now done that, making the SqueakTrunk build much happier. ST80
>>> >> and ToolBuilder-MVC continue to be tested (and they pass their tests
>>> >> currently) in the ExternalPackages job.
>>> >>
>>> >> Dave, I'd appreciate it if you could take a latest-and-greatest
>>> >> ReleaseSqueakTrunk artifact and play around with ST80 in it.
>>> >> Everything _should_ Just Work.
>>> >>
>>> >
>>> > I loaded MVC back into the Squeak4.5-12579 image from ReleaseSqueakTrunk
>>> > (packages ST80, ST80Tools, ST80Tests, and ToolBuilder-MVC). I saw no new
>>> > problems and all seems to work fine, just a little faster than usual due
>>> > to the smaller image. Nice :-)
>>> >
>>> > Unrelated to MVC, I did accidentally notice that "Object new open"
>>> > crashes
>>> > the VM in this image rather than opening a debugger, we'll have to see
>>> > what's up with that.
>>>
>>> Hm, I wonder if the ToolSet's correctly set back to the
>>> StandardToolSet rather than CommandLineToolSet.
>>
>>
>> That's the issue.
>>
>> 0xbffb3efc I SmalltalkImage>snapshot:andQuit:embedded: 0x139515b8: a(n)
>> SmalltalkImage
>> 0xbffb3f28 I SmalltalkImage>snapshot:andQuit: 0x139515b8: a(n)
>> SmalltalkImage
>> 0xbffb2e28 I CommandLineToolSet class>debugError: 0x1443106c: a(n)
>> CommandLineToolSet class
>> 0xbffb2e50 I ToolSet class>debugError: 0x139261e4: a(n) ToolSet class
>> 0xbffb2e74 I UnhandledError>defaultAction 0x1473a134: a(n) UnhandledError
>> 0xbffb2e90 M UndefinedObject>handleSignal: 0x1360a004: a(n) UndefinedObject
>> 0xbffb2eb0 M MethodContext(ContextPart)>handleSignal: 0x14739f64: a(n)
>> MethodContext
>> 0xbffb2ed0 M MethodContext(ContextPart)>handleSignal: 0x14739f08: a(n)
>> MethodContext
>> 0xbffb2eec M UnhandledError(Exception)>signal 0x1473a134: a(n)
>> UnhandledError
>> 0xbffb2f0c I UnhandledError class>signalForException: 0x13927100: a(n)
>> UnhandledError class
>> 0xbffb2f30 I Halt>defaultAction 0x14739e38: a(n) Halt
>> 0xbffb257c M UndefinedObject>handleSignal: 0x1360a004: a(n) UndefinedObject
>> 0xbffb259c M MethodContext(ContextPart)>handleSignal: 0x14739f64: a(n)
>> MethodContext
>> 0xbffb25bc M MethodContext(ContextPart)>handleSignal: 0x14739f08: a(n)
>> MethodContext
>> 0xbffb25d8 M Halt(Exception)>signal 0x14739e38: a(n) Halt
>> 0xbffb25f8 I Halt class(Exception class)>signal 0x13927204: a(n) Halt class
>> 0xbffb2618 I UndefinedObject(Object)>halt 0x1360a004: a(n) UndefinedObject
>> 0xbffb2630 M UndefinedObject()>? 0x1360a004: a(n) UndefinedObject
>> 0xbffb2668 I Compiler>evaluate:cue:ifFail:logged: 0x146b25f4: a(n) Compiler
>>
>>>
>>>
>>> frank
>>>
>>> > Dave
>>> >
>>> >
>>>
>>
>>
>>
>> --
>> best,
>> Eliot
>>
>>
>>