Smalltalk › Squeak › Squeak - Dev

The Trunk: System-eem.982.mcz

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 3 messages Options
commits-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

The Trunk: System-eem.982.mcz

commits-2
Eliot Miranda uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-eem.982.mcz

==================== Summary ====================

Name: System-eem.982
Author: eem
Time: 12 December 2017, 9:41:56.677625 am
UUID: 178a5e44-255e-4f96-b321-28c3d27f913c
Ancestors: System-eem.981

Resave to eliminate inadvertent Preferences changes.  I can't believe that we're still having to step around this b.s.  sigh...

=============== Diff against System-eem.981 ===============

Item was removed:
- ----- Method: Preferences class>>enablePortraitMode (in category 'standard queries') -----
- enablePortraitMode
- ^ self
- valueOfFlag: #enablePortraitMode
- ifAbsent: [false]!

Item was removed:
- ----- Method: Preferences class>>enableVirtualOLPCDisplay (in category 'standard queries') -----
- enableVirtualOLPCDisplay
- ^ self
- valueOfFlag: #enableVirtualOLPCDisplay
- ifAbsent: [false]!

Item was changed:
+ ----- Method: Preferences class>>haloTheme (in category 'prefs - halos') -----
- ----- Method: Preferences class>>haloTheme (in category 'standard queries') -----
  haloTheme
  ^ self
  valueOfFlag: #haloTheme
+ ifAbsent: [ #iconicHaloSpecifications ]!
- ifAbsent: [#iconicHaloSpecifications]!

Item was changed:
  ----- Method: Preferences class>>showAdvancedNavigatorButtons (in category 'standard queries') -----
  showAdvancedNavigatorButtons
  ^ self
  valueOfFlag: #showAdvancedNavigatorButtons
+ ifAbsent: [ true ]!
- ifAbsent: [false]!

Item was removed:
- ----- Method: Preferences class>>sugarAutoSave (in category 'standard queries') -----
- sugarAutoSave
- ^ self
- valueOfFlag: #sugarAutoSave
- ifAbsent: [false]!

Item was removed:
- ----- Method: Preferences class>>vmProfilerFillInIntegral (in category 'standard queries') -----
- vmProfilerFillInIntegral
- ^ self
- valueOfFlag: #vmProfilerFillInIntegral
- ifAbsent: [false]!


marcel.taeumel
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: System-eem.982.mcz

marcel.taeumel
I tried to get rid of those for 5.1, but then realized that some of these standard queries were actually used by some applications. :-) :-/  They should be in "*autogenerated" or something not to be checked-in by accident.

Best,
Marcel

Am 12.12.2017 18:42:59 schrieb [hidden email] <[hidden email]>:

Eliot Miranda uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-eem.982.mcz

==================== Summary ====================

Name: System-eem.982
Author: eem
Time: 12 December 2017, 9:41:56.677625 am
UUID: 178a5e44-255e-4f96-b321-28c3d27f913c
Ancestors: System-eem.981

Resave to eliminate inadvertent Preferences changes. I can't believe that we're still having to step around this b.s. sigh...

=============== Diff against System-eem.981 ===============

Item was removed:
- ----- Method: Preferences class>>enablePortraitMode (in category 'standard queries') -----
- enablePortraitMode
- ^ self
- valueOfFlag: #enablePortraitMode
- ifAbsent: [false]!

Item was removed:
- ----- Method: Preferences class>>enableVirtualOLPCDisplay (in category 'standard queries') -----
- enableVirtualOLPCDisplay
- ^ self
- valueOfFlag: #enableVirtualOLPCDisplay
- ifAbsent: [false]!

Item was changed:
+ ----- Method: Preferences class>>haloTheme (in category 'prefs - halos') -----
- ----- Method: Preferences class>>haloTheme (in category 'standard queries') -----
haloTheme
^ self
valueOfFlag: #haloTheme
+ ifAbsent: [ #iconicHaloSpecifications ]!
- ifAbsent: [#iconicHaloSpecifications]!

Item was changed:
----- Method: Preferences class>>showAdvancedNavigatorButtons (in category 'standard queries') -----
showAdvancedNavigatorButtons
^ self
valueOfFlag: #showAdvancedNavigatorButtons
+ ifAbsent: [ true ]!
- ifAbsent: [false]!

Item was removed:
- ----- Method: Preferences class>>sugarAutoSave (in category 'standard queries') -----
- sugarAutoSave
- ^ self
- valueOfFlag: #sugarAutoSave
- ifAbsent: [false]!

Item was removed:
- ----- Method: Preferences class>>vmProfilerFillInIntegral (in category 'standard queries') -----
- vmProfilerFillInIntegral
- ^ self
- valueOfFlag: #vmProfilerFillInIntegral
- ifAbsent: [false]!
Eliot Miranda-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: System-eem.982.mcz

Eliot Miranda-2


On Dec 13, 2017, at 12:25 AM, Marcel Taeumel <[hidden email]> wrote:

I tried to get rid of those for 5.1, but then realized that some of these standard queries were actually used by some applications. :-) :-/  They should be in "*autogenerated" or something not to be checked-in by accident.

Exactly.  There was some discussion earlier.  The only issue is categorization.  Autogenerated preferences should not be in the System package.  Surely this is easy to fix.


Best,
Marcel

Am 12.12.2017 18:42:59 schrieb [hidden email] <[hidden email]>:

Eliot Miranda uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-eem.982.mcz

==================== Summary ====================

Name: System-eem.982
Author: eem
Time: 12 December 2017, 9:41:56.677625 am
UUID: 178a5e44-255e-4f96-b321-28c3d27f913c
Ancestors: System-eem.981

Resave to eliminate inadvertent Preferences changes. I can't believe that we're still having to step around this b.s. sigh...

=============== Diff against System-eem.981 ===============

Item was removed:
- ----- Method: Preferences class>>enablePortraitMode (in category 'standard queries') -----
- enablePortraitMode
- ^ self
- valueOfFlag: #enablePortraitMode
- ifAbsent: [false]!

Item was removed:
- ----- Method: Preferences class>>enableVirtualOLPCDisplay (in category 'standard queries') -----
- enableVirtualOLPCDisplay
- ^ self
- valueOfFlag: #enableVirtualOLPCDisplay
- ifAbsent: [false]!

Item was changed:
+ ----- Method: Preferences class>>haloTheme (in category 'prefs - halos') -----
- ----- Method: Preferences class>>haloTheme (in category 'standard queries') -----
haloTheme
^ self
valueOfFlag: #haloTheme
+ ifAbsent: [ #iconicHaloSpecifications ]!
- ifAbsent: [#iconicHaloSpecifications]!

Item was changed:
----- Method: Preferences class>>showAdvancedNavigatorButtons (in category 'standard queries') -----
showAdvancedNavigatorButtons
^ self
valueOfFlag: #showAdvancedNavigatorButtons
+ ifAbsent: [ true ]!
- ifAbsent: [false]!

Item was removed:
- ----- Method: Preferences class>>sugarAutoSave (in category 'standard queries') -----
- sugarAutoSave
- ^ self
- valueOfFlag: #sugarAutoSave
- ifAbsent: [false]!

Item was removed:
- ----- Method: Preferences class>>vmProfilerFillInIntegral (in category 'standard queries') -----
- vmProfilerFillInIntegral
- ^ self
- valueOfFlag: #vmProfilerFillInIntegral
- ifAbsent: [false]!
Free forum by Nabble Edit this page