The Trunk: System-fbs.558.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: System-fbs.558.mcz

commits-2
Frank Shearar uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-fbs.558.mcz

==================== Summary ====================

Name: System-fbs.558
Author: fbs
Time: 6 July 2013, 3:41:20.164 pm
UUID: 0b1d3a00-169d-954c-bb6c-756e4620ea6d
Ancestors: System-fbs.557

Make ColorTheme concrete, and the default theme.

Thanks to Chris Muller for the colour values!

=============== Diff against System-fbs.557 ===============

Item was changed:
  ----- Method: ColorTheme class>>defaultTheme (in category 'accessing') -----
  defaultTheme
+ ^ self.!
- Smalltalk
- at: #YellowSmallLandColorTheme
- ifPresent: [:yellowSmallLandColorTheme | ^ yellowSmallLandColorTheme].
- ^ (self allSubclasses
- select: [:each | each subclasses isEmpty]) anyOne!

Item was changed:
  ----- Method: ColorTheme>>balloonColor (in category 'theme') -----
  balloonColor
+ ^ TranslucentColor
+ r: 0.92
+ g: 0.92
+ b: 0.706
+ alpha: 0.75!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>defaultWorldColor (in category 'theme') -----
  defaultWorldColor
+ ^ Color blue muchLighter!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>dockingBarAutoGradient (in category 'theme - dockingbar') -----
  dockingBarAutoGradient
+ ^ true!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>dockingBarColor (in category 'theme - dockingbar') -----
  dockingBarColor
+ ^ Color r: 0.6 g: 0.7 b: 1!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>dockingBarGradientRamp (in category 'theme - dockingbar') -----
  dockingBarGradientRamp
+ ^ { 0.0 -> Color white.
+ 1.0 -> (Color r: 0.6 g: 0.7 b: 1) }!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>helpColor (in category 'theme') -----
  helpColor
+ ^ Color lightGreen!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>insertionPointColor (in category 'theme') -----
  insertionPointColor
+ ^ Color red!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>keyboardFocusColor (in category 'theme') -----
  keyboardFocusColor
+ ^ Color r: 0.6 g: 1 b: 1!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>menuBorderColor (in category 'theme - menus') -----
  menuBorderColor
+ ^ Color r: 0.2 g: 0.3 b: 0.9!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>menuBorderWidth (in category 'theme - menus') -----
  menuBorderWidth
+ ^ 2!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>menuColor (in category 'theme - menus') -----
  menuColor
+ ^ Color r: 0.85 g: 0.9 b: 1!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>menuLineColor (in category 'theme - menus') -----
  menuLineColor
+ ^ Color r: 0.6 g: 0.7 b: 1!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>menuSelectionColor (in category 'theme - menus') -----
  menuSelectionColor
+ ^ Color r: 0.2 g: 0.3 b: 0.9!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>menuTitleBorderColor (in category 'theme - menus') -----
  menuTitleBorderColor
+ ^ Color r: 0.6 g: 0.7 b: 1!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>menuTitleBorderWidth (in category 'theme - menus') -----
  menuTitleBorderWidth
+ ^ 6!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>menuTitleColor (in category 'theme - menus') -----
  menuTitleColor
+ ^ Color r: 0.6 g: 0.7 b: 1!
- ^ self subclassResponsibility!

Item was changed:
  ----- Method: ColorTheme>>textHighlightColor (in category 'theme') -----
  textHighlightColor
+ ^ Color blue muchLighter alpha: 0.7!
- ^ self subclassResponsibility!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-fbs.558.mcz

Chris Muller-3
Where's the work I did?  I gave this thing much-needed state so we can
change the values without recompiling code..

On Sat, Jul 6, 2013 at 9:41 AM,  <[hidden email]> wrote:

> Frank Shearar uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-fbs.558.mcz
>
> ==================== Summary ====================
>
> Name: System-fbs.558
> Author: fbs
> Time: 6 July 2013, 3:41:20.164 pm
> UUID: 0b1d3a00-169d-954c-bb6c-756e4620ea6d
> Ancestors: System-fbs.557
>
> Make ColorTheme concrete, and the default theme.
>
> Thanks to Chris Muller for the colour values!
>
> =============== Diff against System-fbs.557 ===============
>
> Item was changed:
>   ----- Method: ColorTheme class>>defaultTheme (in category 'accessing') -----
>   defaultTheme
> +       ^ self.!
> -       Smalltalk
> -               at: #YellowSmallLandColorTheme
> -               ifPresent: [:yellowSmallLandColorTheme | ^ yellowSmallLandColorTheme].
> -       ^ (self allSubclasses
> -               select: [:each | each subclasses isEmpty]) anyOne!
>
> Item was changed:
>   ----- Method: ColorTheme>>balloonColor (in category 'theme') -----
>   balloonColor
> +       ^ TranslucentColor
> +                       r: 0.92
> +                       g: 0.92
> +                       b: 0.706
> +                       alpha: 0.75!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>defaultWorldColor (in category 'theme') -----
>   defaultWorldColor
> +       ^ Color blue muchLighter!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>dockingBarAutoGradient (in category 'theme - dockingbar') -----
>   dockingBarAutoGradient
> +       ^ true!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>dockingBarColor (in category 'theme - dockingbar') -----
>   dockingBarColor
> +       ^ Color r: 0.6 g: 0.7 b: 1!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>dockingBarGradientRamp (in category 'theme - dockingbar') -----
>   dockingBarGradientRamp
> +       ^ { 0.0 -> Color white.
> +               1.0 -> (Color r: 0.6 g: 0.7 b: 1) }!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>helpColor (in category 'theme') -----
>   helpColor
> +       ^ Color lightGreen!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>insertionPointColor (in category 'theme') -----
>   insertionPointColor
> +       ^ Color red!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>keyboardFocusColor (in category 'theme') -----
>   keyboardFocusColor
> +       ^ Color r: 0.6 g: 1 b: 1!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>menuBorderColor (in category 'theme - menus') -----
>   menuBorderColor
> +       ^ Color r: 0.2 g: 0.3 b: 0.9!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>menuBorderWidth (in category 'theme - menus') -----
>   menuBorderWidth
> +       ^ 2!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>menuColor (in category 'theme - menus') -----
>   menuColor
> +       ^ Color r: 0.85 g: 0.9 b: 1!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>menuLineColor (in category 'theme - menus') -----
>   menuLineColor
> +       ^ Color r: 0.6 g: 0.7 b: 1!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>menuSelectionColor (in category 'theme - menus') -----
>   menuSelectionColor
> +       ^ Color r: 0.2 g: 0.3 b: 0.9!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>menuTitleBorderColor (in category 'theme - menus') -----
>   menuTitleBorderColor
> +       ^ Color r: 0.6 g: 0.7 b: 1!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>menuTitleBorderWidth (in category 'theme - menus') -----
>   menuTitleBorderWidth
> +       ^ 6!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>menuTitleColor (in category 'theme - menus') -----
>   menuTitleColor
> +       ^ Color r: 0.6 g: 0.7 b: 1!
> -       ^ self subclassResponsibility!
>
> Item was changed:
>   ----- Method: ColorTheme>>textHighlightColor (in category 'theme') -----
>   textHighlightColor
> +       ^ Color blue muchLighter alpha: 0.7!
> -       ^ self subclassResponsibility!
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-fbs.558.mcz

Chris Muller-3
I got it -- you're just working on modularity right now.

On Sat, Jul 6, 2013 at 5:45 PM, Chris Muller <[hidden email]> wrote:

> Where's the work I did?  I gave this thing much-needed state so we can
> change the values without recompiling code..
>
> On Sat, Jul 6, 2013 at 9:41 AM,  <[hidden email]> wrote:
>> Frank Shearar uploaded a new version of System to project The Trunk:
>> http://source.squeak.org/trunk/System-fbs.558.mcz
>>
>> ==================== Summary ====================
>>
>> Name: System-fbs.558
>> Author: fbs
>> Time: 6 July 2013, 3:41:20.164 pm
>> UUID: 0b1d3a00-169d-954c-bb6c-756e4620ea6d
>> Ancestors: System-fbs.557
>>
>> Make ColorTheme concrete, and the default theme.
>>
>> Thanks to Chris Muller for the colour values!
>>
>> =============== Diff against System-fbs.557 ===============
>>
>> Item was changed:
>>   ----- Method: ColorTheme class>>defaultTheme (in category 'accessing') -----
>>   defaultTheme
>> +       ^ self.!
>> -       Smalltalk
>> -               at: #YellowSmallLandColorTheme
>> -               ifPresent: [:yellowSmallLandColorTheme | ^ yellowSmallLandColorTheme].
>> -       ^ (self allSubclasses
>> -               select: [:each | each subclasses isEmpty]) anyOne!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>balloonColor (in category 'theme') -----
>>   balloonColor
>> +       ^ TranslucentColor
>> +                       r: 0.92
>> +                       g: 0.92
>> +                       b: 0.706
>> +                       alpha: 0.75!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>defaultWorldColor (in category 'theme') -----
>>   defaultWorldColor
>> +       ^ Color blue muchLighter!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>dockingBarAutoGradient (in category 'theme - dockingbar') -----
>>   dockingBarAutoGradient
>> +       ^ true!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>dockingBarColor (in category 'theme - dockingbar') -----
>>   dockingBarColor
>> +       ^ Color r: 0.6 g: 0.7 b: 1!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>dockingBarGradientRamp (in category 'theme - dockingbar') -----
>>   dockingBarGradientRamp
>> +       ^ { 0.0 -> Color white.
>> +               1.0 -> (Color r: 0.6 g: 0.7 b: 1) }!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>helpColor (in category 'theme') -----
>>   helpColor
>> +       ^ Color lightGreen!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>insertionPointColor (in category 'theme') -----
>>   insertionPointColor
>> +       ^ Color red!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>keyboardFocusColor (in category 'theme') -----
>>   keyboardFocusColor
>> +       ^ Color r: 0.6 g: 1 b: 1!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>menuBorderColor (in category 'theme - menus') -----
>>   menuBorderColor
>> +       ^ Color r: 0.2 g: 0.3 b: 0.9!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>menuBorderWidth (in category 'theme - menus') -----
>>   menuBorderWidth
>> +       ^ 2!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>menuColor (in category 'theme - menus') -----
>>   menuColor
>> +       ^ Color r: 0.85 g: 0.9 b: 1!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>menuLineColor (in category 'theme - menus') -----
>>   menuLineColor
>> +       ^ Color r: 0.6 g: 0.7 b: 1!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>menuSelectionColor (in category 'theme - menus') -----
>>   menuSelectionColor
>> +       ^ Color r: 0.2 g: 0.3 b: 0.9!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>menuTitleBorderColor (in category 'theme - menus') -----
>>   menuTitleBorderColor
>> +       ^ Color r: 0.6 g: 0.7 b: 1!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>menuTitleBorderWidth (in category 'theme - menus') -----
>>   menuTitleBorderWidth
>> +       ^ 6!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>menuTitleColor (in category 'theme - menus') -----
>>   menuTitleColor
>> +       ^ Color r: 0.6 g: 0.7 b: 1!
>> -       ^ self subclassResponsibility!
>>
>> Item was changed:
>>   ----- Method: ColorTheme>>textHighlightColor (in category 'theme') -----
>>   textHighlightColor
>> +       ^ Color blue muchLighter alpha: 0.7!
>> -       ^ self subclassResponsibility!
>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-fbs.558.mcz

Frank Shearar-3
Yup (re modularity). Also, AttributableObject isn't in Trunk yet, and
I didn't want to force anyone's hand by simply merging it in.

frank

On 7 July 2013 01:59, Chris Muller <[hidden email]> wrote:

> I got it -- you're just working on modularity right now.
>
> On Sat, Jul 6, 2013 at 5:45 PM, Chris Muller <[hidden email]> wrote:
>> Where's the work I did?  I gave this thing much-needed state so we can
>> change the values without recompiling code..
>>
>> On Sat, Jul 6, 2013 at 9:41 AM,  <[hidden email]> wrote:
>>> Frank Shearar uploaded a new version of System to project The Trunk:
>>> http://source.squeak.org/trunk/System-fbs.558.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: System-fbs.558
>>> Author: fbs
>>> Time: 6 July 2013, 3:41:20.164 pm
>>> UUID: 0b1d3a00-169d-954c-bb6c-756e4620ea6d
>>> Ancestors: System-fbs.557
>>>
>>> Make ColorTheme concrete, and the default theme.
>>>
>>> Thanks to Chris Muller for the colour values!
>>>
>>> =============== Diff against System-fbs.557 ===============
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme class>>defaultTheme (in category 'accessing') -----
>>>   defaultTheme
>>> +       ^ self.!
>>> -       Smalltalk
>>> -               at: #YellowSmallLandColorTheme
>>> -               ifPresent: [:yellowSmallLandColorTheme | ^ yellowSmallLandColorTheme].
>>> -       ^ (self allSubclasses
>>> -               select: [:each | each subclasses isEmpty]) anyOne!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>balloonColor (in category 'theme') -----
>>>   balloonColor
>>> +       ^ TranslucentColor
>>> +                       r: 0.92
>>> +                       g: 0.92
>>> +                       b: 0.706
>>> +                       alpha: 0.75!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>defaultWorldColor (in category 'theme') -----
>>>   defaultWorldColor
>>> +       ^ Color blue muchLighter!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>dockingBarAutoGradient (in category 'theme - dockingbar') -----
>>>   dockingBarAutoGradient
>>> +       ^ true!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>dockingBarColor (in category 'theme - dockingbar') -----
>>>   dockingBarColor
>>> +       ^ Color r: 0.6 g: 0.7 b: 1!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>dockingBarGradientRamp (in category 'theme - dockingbar') -----
>>>   dockingBarGradientRamp
>>> +       ^ { 0.0 -> Color white.
>>> +               1.0 -> (Color r: 0.6 g: 0.7 b: 1) }!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>helpColor (in category 'theme') -----
>>>   helpColor
>>> +       ^ Color lightGreen!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>insertionPointColor (in category 'theme') -----
>>>   insertionPointColor
>>> +       ^ Color red!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>keyboardFocusColor (in category 'theme') -----
>>>   keyboardFocusColor
>>> +       ^ Color r: 0.6 g: 1 b: 1!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>menuBorderColor (in category 'theme - menus') -----
>>>   menuBorderColor
>>> +       ^ Color r: 0.2 g: 0.3 b: 0.9!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>menuBorderWidth (in category 'theme - menus') -----
>>>   menuBorderWidth
>>> +       ^ 2!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>menuColor (in category 'theme - menus') -----
>>>   menuColor
>>> +       ^ Color r: 0.85 g: 0.9 b: 1!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>menuLineColor (in category 'theme - menus') -----
>>>   menuLineColor
>>> +       ^ Color r: 0.6 g: 0.7 b: 1!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>menuSelectionColor (in category 'theme - menus') -----
>>>   menuSelectionColor
>>> +       ^ Color r: 0.2 g: 0.3 b: 0.9!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>menuTitleBorderColor (in category 'theme - menus') -----
>>>   menuTitleBorderColor
>>> +       ^ Color r: 0.6 g: 0.7 b: 1!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>menuTitleBorderWidth (in category 'theme - menus') -----
>>>   menuTitleBorderWidth
>>> +       ^ 6!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>menuTitleColor (in category 'theme - menus') -----
>>>   menuTitleColor
>>> +       ^ Color r: 0.6 g: 0.7 b: 1!
>>> -       ^ self subclassResponsibility!
>>>
>>> Item was changed:
>>>   ----- Method: ColorTheme>>textHighlightColor (in category 'theme') -----
>>>   textHighlightColor
>>> +       ^ Color blue muchLighter alpha: 0.7!
>>> -       ^ self subclassResponsibility!
>>>
>>>
>