The Trunk: System-fbs.584.mcz

Frank Shearar uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-fbs.584.mcz

==================== Summary ====================

Name: System-fbs.584
Author: fbs
Time: 9 August 2013, 5:35:57.791 pm
UUID: 4a39339f-7bd6-ec4d-ad0d-96343e52b1d8
Ancestors: System-ul.583

Using FileServices means not depending on Tools.

=============== Diff against System-ul.583 ===============

Item was changed:
  ----- Method: DefaultExternalDropHandler>>servicesForFileNamed: (in category 'private') -----
  servicesForFileNamed: aString
  "private - answer a collection of file-services for the file named  
  aString"
  | allServices |
+ allServices := FileServices itemsForFile: aString.
- allServices := FileList itemsForFile: aString.
  ^ allServices
  reject: [:svc | self unwantedSelectors includes: svc selector]!

Item was changed:
  ----- Method: ExternalDropHandler class>>lookupServiceBasedHandler: (in category 'accessing') -----
  lookupServiceBasedHandler: dropStream
+ "The file was just dropped; let's do our job"
- "the file was just droped, let's do our job"
  | fileName services theOne |
  fileName := dropStream name.
 
+ services := (FileServices itemsForFile: fileName)
- services := (FileList itemsForFile: fileName)
  reject: [:svc | self unwantedSelectors includes: svc selector].
 
  "no service, default behavior"
  services isEmpty
  ifTrue: [^nil].
 
  theOne := self chooseServiceFrom: services.
  ^theOne
  ifNotNil: [ExternalDropHandler type: nil extension: nil action: [:stream | theOne performServiceFor: stream]]!

Item was changed:
  ----- Method: MczInstaller class>>registerForFileList (in category 'services') -----
  registerForFileList
+ Smalltalk at: #MCReader ifAbsent: [FileServices registerFileReader: self]!
- Smalltalk at: #MCReader ifAbsent: [FileList registerFileReader: self]!

Item was changed:
  ----- Method: SARInstaller class>>initialize (in category 'class initialization') -----
  initialize
  "SARInstaller initialize"
+ FileServices registerFileReader: self.!
- (FileList respondsTo: #registerFileReader:)
- ifTrue: [ FileList registerFileReader: self ]!

Item was changed:
  ----- Method: SARInstaller class>>unload (in category 'class initialization') -----
  unload
+ FileServices unregisterFileReader: self.!
-
- (FileList respondsTo: #unregisterFileReader:)
- ifTrue: [ FileList unregisterFileReader: self ]!

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi
Am 09.08.2013 um 18:34 schrieb [hidden email]:


Item was changed:
 ----- Method: MczInstaller class>>registerForFileList (in category 'services') -----
 registerForFileList
+ Smalltalk at: #MCReader ifAbsent: [FileServices registerFileReader: self]!
- - Smalltalk at: #MCReader ifAbsent: [FileList registerFileReader: self]!

Item was changed:
 ----- Method: SARInstaller class>>initialize (in category 'class initialization') -----
 initialize
  "SARInstaller initialize"
+ FileServices registerFileReader: self.!
- - (FileList respondsTo: #registerFileReader:)
- - ifTrue: [ FileList registerFileReader: self ]!

Item was changed:
 ----- Method: SARInstaller class>>unload (in category 'class initialization') -----
 unload
+ FileServices unregisterFileReader: self.!
- -
- - (FileList respondsTo: #unregisterFileReader:)
- - ifTrue: [ FileList unregisterFileReader: self

Shouldn't those go into Monticello?

Best
        -Tobias
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.20 (Darwin)

iEYEARECAAYFAlIFX+kACgkQcPVIrP6PLKvxrQCggf35KPq1sY0TQqVUCe2Fgbqg
PyUAnA3oHFG49NWalMas/3cp/LmQC45n
=v+p+
-----END PGP SIGNATURE-----

On 9 August 2013 22:32, Tobias Pape <[hidden email]> wrote:
I'm not sure what you mean. Are you asking if SARInstaller should go
into Monticello? I can see a strong argument for some kind of
"CodeLoader" package, to be broken out of System. I _don't_ think
Monticello should hold these though, just because they load code.

MczInstaller _sounds_ like it belongs in Monticello, but it's actually
a class that lets you load an mcz without having the Monticello
package loaded.

frank

Am 10.08.2013 um 08:23 schrieb Frank Shearar <[hidden email]>:


Ok, i agree fully with you. :)
Best
    -Tobias