Smalltalk › Squeak › Squeak - Dev

The Trunk: System-mt.1169.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

commits-2

The Trunk: System-mt.1169.mcz

Marcel Taeumel uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-mt.1169.mcz

==================== Summary ====================

Name: System-mt.1169
Author: mt
Time: 17 August 2020, 12:54:05.667289 pm
UUID: dfd26c6f-79f7-f146-95c1-78751d5f8f13
Ancestors: System-eem.1168

Clarify implementation of method timestamps.

Note that #hhmm24 cannot be used here, because it has no colon separator.

=============== Diff against System-eem.1168 ===============

Item was changed:
----- Method: Utilities class>>changeStamp (in category 'identification') -----
changeStamp
"Answer a string to be pasted into source code to mark who changed it and when."
^ self authorInitials , ' ' , Date today mmddyyyy, ' ',
+ (String streamContents: [:s | Time now print24: true showSeconds: false on: s])!
- ((String streamContents: [:s | Time now print24: true on: s]) copyFrom: 1 to: 5)!

Eliot Miranda-2

Re: The Trunk: System-mt.1169.mcz

> On Aug 17, 2020, at 3:54 AM, [hidden email] wrote:
>
> Marcel Taeumel uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-mt.1169.mcz
>
> ==================== Summary ====================
>
> Name: System-mt.1169
> Author: mt
> Time: 17 August 2020, 12:54:05.667289 pm
> UUID: dfd26c6f-79f7-f146-95c1-78751d5f8f13
> Ancestors: System-eem.1168
>
> Clarify implementation of method timestamps.
>
> Note that #hhmm24 cannot be used here, because it has no colon separator.
>
> =============== Diff against System-eem.1168 ===============
>
> Item was changed:
> ----- Method: Utilities class>>changeStamp (in category 'identification') -----
> changeStamp
> "Answer a string to be pasted into source code to mark who changed it and when."
> ^ self authorInitials , ' ' , Date today mmddyyyy, ' ',
> + (String streamContents: [:s | Time now print24: true showSeconds: false on: s])!
> - ((String streamContents: [:s | Time now print24: true on: s]) copyFrom: 1 to: 5)!
>
>

Christoph Thiede

Re: The Trunk: System-mt.1169.mcz

> this reminds me I think we also need something that answers an actual TimeStamp or DateAndTime instance for a CompiledMethod.

+1 for doing this. The current timeStamp string might be necessary from an implementation view, but from an object model view it is a shame that such an important object commits such primitive obsession. It would be so nice if you could do something like

CompiledMethod allInstances sorted: #dateTimeStamp asSortFunction

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von Eliot Miranda <[hidden email]>
Gesendet: Dienstag, 18. August 2020 17:13:53
An: [hidden email]
Betreff: Re: [squeak-dev] The Trunk: System-mt.1169.mcz

Hi Marcel, hi all,

     this reminds me I think we also need something that answers an actual TimeStamp or DateAndTime instance for a CompiledMethod. Unfortunately timeStamp is already in use as the selector for a method’s change stamp string. In an ideal world CompiledMethod>>#timeStamp would be renamed to CompiledMethod>>#changeStamp and CompiledMethod>>#timeStamp would answer a DateAndTime of either the method’s changeStamp time or the epoch, if it had none.

_,,,^..^,,,_ (phone)

> On Aug 17, 2020, at 3:54 AM, [hidden email] wrote:
>
> Marcel Taeumel uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-mt.1169.mcz
>
> ==================== Summary ====================
>
> Name: System-mt.1169
> Author: mt
> Time: 17 August 2020, 12:54:05.667289 pm
> UUID: dfd26c6f-79f7-f146-95c1-78751d5f8f13
> Ancestors: System-eem.1168
>
> Clarify implementation of method timestamps.
>
> Note that #hhmm24 cannot be used here, because it has no colon separator.
>
> =============== Diff against System-eem.1168 ===============
>
> Item was changed:
> ----- Method: Utilities class>>changeStamp (in category 'identification') -----
> changeStamp
>      "Answer a string to be pasted into source code to mark who changed it and when."
>      ^ self authorInitials , ' ' , Date today mmddyyyy, ' ',
> +        (String streamContents: [:s | Time now print24: true showSeconds: false on: s])!
> -        ((String streamContents: [:s | Time now print24: true on: s]) copyFrom: 1 to: 5)!
>
>

Carpe Squeak!