The Trunk: System-nice.638.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: System-nice.638.mcz

commits-2
Nicolas Cellier uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-nice.638.mcz

==================== Summary ====================

Name: System-nice.638
Author: nice
Time: 7 December 2013, 12:15:40.007 am
UUID: fda82750-d26d-4ec3-9863-333b0f49d3dc
Ancestors: System-fbs.637

Move updateStream stuff to UpdateStream package

=============== Diff against System-fbs.637 ===============

Item was removed:
- ----- Method: AutoStart class>>checkForUpdates (in category 'updating') -----
- checkForUpdates
- | availableUpdate updateServer |
- World ifNotNil:
- [ World install.
- ActiveHand position: 100 @ 100 ].
- HTTPClient isRunningInBrowser ifFalse: [ ^ self processUpdates ].
- availableUpdate := (Smalltalk namedArguments
- at: 'UPDATE'
- ifAbsent: [ '' ]) asInteger.
- availableUpdate ifNil: [ ^ false ].
- updateServer := Smalltalk namedArguments
- at: 'UPDATESERVER'
- ifAbsent:
- [ Smalltalk namedArguments
- at: 'UPDATE_SERVER'
- ifAbsent: [ 'Squeakland' ] ].
- Utilities setUpdateServer: updateServer.
- ^ SystemVersion checkAndApplyUpdates: availableUpdate!

Item was removed:
- ----- Method: SystemVersion class>>checkAndApplyUpdates: (in category 'updating') -----
- checkAndApplyUpdates: availableUpdate
- "SystemVersion checkAndApplyUpdates: nil"
-
- ^(availableUpdate isNil
- or: [availableUpdate > SystemVersion current highestUpdate])
- ifTrue: [
- (self confirm: 'There are updates available. Do you want to install them now?')
- ifFalse: [^false].
- Utilities
- readServerUpdatesThrough: availableUpdate
- saveLocally: false
- updateImage: true.
- Smalltalk snapshot: true andQuit: false.
- true]
- ifFalse: [false]!

Item was changed:
  Object subclass: #Utilities
  instanceVariableNames: ''
+ classVariableNames: 'AuthorInitials AuthorName CommonRequestStrings LastStats'
- classVariableNames: 'AuthorInitials AuthorName CommonRequestStrings LastStats UpdateDownloader UpdateUrlLists'
  poolDictionaries: ''
  category: 'System-Support'!
 
  !Utilities commentStamp: '<historical>' prior: 0!
  A repository for general and miscellaneous utilities; much of what is here are in effect global methods that don't naturally attach to anything else.  1/96 sw!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-nice.638.mcz

Frank Shearar-3
On 6 December 2013 23:16,  <[hidden email]> wrote:

> Nicolas Cellier uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-nice.638.mcz
>
> ==================== Summary ====================
>
> Name: System-nice.638
> Author: nice
> Time: 7 December 2013, 12:15:40.007 am
> UUID: fda82750-d26d-4ec3-9863-333b0f49d3dc
> Ancestors: System-fbs.637
>
> Move updateStream stuff to UpdateStream package
>
> =============== Diff against System-fbs.637 ===============
>
> Item was removed:
> - ----- Method: AutoStart class>>checkForUpdates (in category 'updating') -----
> - checkForUpdates
> -       | availableUpdate updateServer |
> -       World ifNotNil:
> -               [ World install.
> -               ActiveHand position: 100 @ 100 ].
> -       HTTPClient isRunningInBrowser ifFalse: [ ^ self processUpdates ].
> -       availableUpdate := (Smalltalk namedArguments
> -               at: 'UPDATE'
> -               ifAbsent: [ '' ]) asInteger.
> -       availableUpdate ifNil: [ ^ false ].
> -       updateServer := Smalltalk namedArguments
> -               at: 'UPDATESERVER'
> -               ifAbsent:
> -                       [ Smalltalk namedArguments
> -                               at: 'UPDATE_SERVER'
> -                               ifAbsent: [ 'Squeakland' ] ].
> -       Utilities setUpdateServer: updateServer.
> -       ^ SystemVersion checkAndApplyUpdates: availableUpdate!

This change just broke CI because my semishrunk trunk image doesn't
have UpdateStream, so I get a DNU in Autostart class >> #startUp:.

One possible remedy is to protect this call with "Preferences
updateFromServerAtStartup ifTrue:[]". How's that sound?

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-nice.638.mcz

Frank Shearar-3
On 8 December 2013 14:05, Frank Shearar <[hidden email]> wrote:

> On 6 December 2013 23:16,  <[hidden email]> wrote:
>> Nicolas Cellier uploaded a new version of System to project The Trunk:
>> http://source.squeak.org/trunk/System-nice.638.mcz
>>
>> ==================== Summary ====================
>>
>> Name: System-nice.638
>> Author: nice
>> Time: 7 December 2013, 12:15:40.007 am
>> UUID: fda82750-d26d-4ec3-9863-333b0f49d3dc
>> Ancestors: System-fbs.637
>>
>> Move updateStream stuff to UpdateStream package
>>
>> =============== Diff against System-fbs.637 ===============
>>
>> Item was removed:
>> - ----- Method: AutoStart class>>checkForUpdates (in category 'updating') -----
>> - checkForUpdates
>> -       | availableUpdate updateServer |
>> -       World ifNotNil:
>> -               [ World install.
>> -               ActiveHand position: 100 @ 100 ].
>> -       HTTPClient isRunningInBrowser ifFalse: [ ^ self processUpdates ].
>> -       availableUpdate := (Smalltalk namedArguments
>> -               at: 'UPDATE'
>> -               ifAbsent: [ '' ]) asInteger.
>> -       availableUpdate ifNil: [ ^ false ].
>> -       updateServer := Smalltalk namedArguments
>> -               at: 'UPDATESERVER'
>> -               ifAbsent:
>> -                       [ Smalltalk namedArguments
>> -                               at: 'UPDATE_SERVER'
>> -                               ifAbsent: [ 'Squeakland' ] ].
>> -       Utilities setUpdateServer: updateServer.
>> -       ^ SystemVersion checkAndApplyUpdates: availableUpdate!
>
> This change just broke CI because my semishrunk trunk image doesn't
> have UpdateStream, so I get a DNU in Autostart class >> #startUp:.
>
> One possible remedy is to protect this call with "Preferences
> updateFromServerAtStartup ifTrue:[]". How's that sound?

I've added UpdateStream to the semishrunk image in the meantime. (Must
do, since MorphicExtras depends on UpdateStream.)

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-nice.638.mcz

Nicolas Cellier
I hope it's a temporary dependency, as already underlined, it's not a very natural link in the package graph.


2013/12/8 Frank Shearar <[hidden email]>
On 8 December 2013 14:05, Frank Shearar <[hidden email]> wrote:
> On 6 December 2013 23:16,  <[hidden email]> wrote:
>> Nicolas Cellier uploaded a new version of System to project The Trunk:
>> http://source.squeak.org/trunk/System-nice.638.mcz
>>
>> ==================== Summary ====================
>>
>> Name: System-nice.638
>> Author: nice
>> Time: 7 December 2013, 12:15:40.007 am
>> UUID: fda82750-d26d-4ec3-9863-333b0f49d3dc
>> Ancestors: System-fbs.637
>>
>> Move updateStream stuff to UpdateStream package
>>
>> =============== Diff against System-fbs.637 ===============
>>
>> Item was removed:
>> - ----- Method: AutoStart class>>checkForUpdates (in category 'updating') -----
>> - checkForUpdates
>> -       | availableUpdate updateServer |
>> -       World ifNotNil:
>> -               [ World install.
>> -               ActiveHand position: 100 @ 100 ].
>> -       HTTPClient isRunningInBrowser ifFalse: [ ^ self processUpdates ].
>> -       availableUpdate := (Smalltalk namedArguments
>> -               at: 'UPDATE'
>> -               ifAbsent: [ '' ]) asInteger.
>> -       availableUpdate ifNil: [ ^ false ].
>> -       updateServer := Smalltalk namedArguments
>> -               at: 'UPDATESERVER'
>> -               ifAbsent:
>> -                       [ Smalltalk namedArguments
>> -                               at: 'UPDATE_SERVER'
>> -                               ifAbsent: [ 'Squeakland' ] ].
>> -       Utilities setUpdateServer: updateServer.
>> -       ^ SystemVersion checkAndApplyUpdates: availableUpdate!
>
> This change just broke CI because my semishrunk trunk image doesn't
> have UpdateStream, so I get a DNU in Autostart class >> #startUp:.
>
> One possible remedy is to protect this call with "Preferences
> updateFromServerAtStartup ifTrue:[]". How's that sound?

I've added UpdateStream to the semishrunk image in the meantime. (Must
do, since MorphicExtras depends on UpdateStream.)

frank