The Trunk: System-topa.1174.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: System-topa.1174.mcz

commits-2
Tobias Pape uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-topa.1174.mcz

==================== Summary ====================

Name: System-topa.1174
Author: topa
Time: 24 September 2020, 11:14:16.007835 pm
UUID: 8f692d9f-4973-4aac-b181-9a2643089f8a
Ancestors: System-eem.1173

Make it so that Theme fonts are looked up on usage, not on theme creation.

=============== Diff against System-eem.1173 ===============

Item was changed:
  ----- Method: CommunityTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: aUserInterfaceTheme
  "Set-up fonts."
  aUserInterfaceTheme
+ set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis italic emphasisCode];
+ set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+ set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+ set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode]!
- set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis italic emphasisCode);
- set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
- set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
- set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode)!

Item was changed:
  ----- Method: CommunityTheme class>>addDarkSyntaxHighlighting: (in category 'instance creation') -----
  addDarkSyntaxHighlighting: aUserInterfaceTheme
  "self createDark apply."
+ | normal bold italic underlined | normal  := TextEmphasis normal.  bold:=TextEmphasis bold.  italic:=TextEmphasis italic.  underlined := TextEmphasis underlined.
- | normal bold italic underlined darkMap | normal  := TextEmphasis normal.  bold:=TextEmphasis bold.  italic:=TextEmphasis italic.  underlined := TextEmphasis underlined.  darkMap := StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9.
  aUserInterfaceTheme
  set: #color for: #TextAction to: self dbBlue;
 
  set: #default for: #SHTextStylerST80 to: {self dbForeground};
  set: #invalid for: #SHTextStylerST80 to: {self dbInvalid};
  set: #excessCode for: #SHTextStylerST80 to: {self dbInvalid twiceDarker};
  "Descriptive text for humans, italicized."
  set: #comment for: #SHTextStylerST80 to: {self dbComment. italic};
  set: #unfinishedComment for: #SHTextStylerST80 to: {self dbComment darker. italic};
  set: #'$' for: #SHTextStylerST80 to: {self dbConstant};
  set: #character for: #SHTextStylerST80 to: {self dbConstant};
  set: #integer for: #SHTextStylerST80 to: {self dbConstant};
  set: #number for: #SHTextStylerST80 to: {self dbConstant};
  set: #- for: #SHTextStylerST80 to: {self dbForeground. bold};
  set: #= for: #SHTextStylerST80 to: {self dbForeground. bold};
  set: #symbol for: #SHTextStylerST80 to: {self dbBedrock};
  set: #stringSymbol for: #SHTextStylerST80 to: {self dbBedrock};
  set: #literalArray for: #SHTextStylerST80 to: {self dbForeground};
  set: #string for: #SHTextStylerST80 to: {self dbConstant};
  set: #unfinishedString for: #SHTextStylerST80 to: {self dbConstant darker};
  set: #assignment for: #SHTextStylerST80 to: {nil. bold};
  set: #ansiAssignment for: #SHTextStylerST80 to: {nil. bold};
  set: #literal for: #SHTextStylerST80 to: {nil. bold};
  set: #keyword for: #SHTextStylerST80 to: {self dbMessage};
  set: #binary for: #SHTextStylerST80 to: {self dbForeground. bold};
  set: #unary for: #SHTextStylerST80 to: {self dbMessage};
  set: #incompleteKeyword for: #SHTextStylerST80 to: {self dbMessage darker. {underlined. bold}};
  set: #incompleteBinary for: #SHTextStylerST80 to: {self dbMessage darker. underlined};
  set: #incompleteUnary for: #SHTextStylerST80 to: {self dbMessage darker. underlined};
  set: #undefinedKeyword for: #SHTextStylerST80 to: {self dbInvalid};
  set: #undefinedBinary for: #SHTextStylerST80 to: {self dbInvalid};
  set: #undefinedUnary for: #SHTextStylerST80 to: {self dbInvalid};
  "Delineate the selector (good for new users), and make the method look like a mini-document with a title."
  set: #patternKeyword for: #SHTextStylerST80 to: {self dbMessage lighter.  {bold. underlined}};
  set: #patternBinary for: #SHTextStylerST80 to: {nil. bold};
  set: #patternUnary for: #SHTextStylerST80 to: {self dbMessage lighter.  {bold. underlined}};
  set: #self for: #SHTextStylerST80 to: {self dbBedrock. bold};
  set: #super for: #SHTextStylerST80 to: {self dbBedrock. bold};
  set: #true for: #SHTextStylerST80 to: {self dbBedrock. bold};
  set: #false for: #SHTextStylerST80 to: {self dbBedrock. bold};
  set: #nil for: #SHTextStylerST80 to: {self dbBedrock. bold};
  set: #thisContext for: #SHTextStylerST80 to: {self dbBedrock. bold};
  set: #return for: #SHTextStylerST80 to: {self dbForeground. bold};
+ set: #patternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. ""};
+ set: #methodArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. ""};
- set: #patternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. "darkMap"};
- set: #methodArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. "darkMap"};
  set: #blockPatternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
  set: #blockArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
  set: #argument for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
  set: #blockArgColon for: #SHTextStylerST80 to: {self dbBedrock};
  set: #leftParenthesis for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
  set: #rightParenthesis for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
  set: #leftParenthesis1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
  set: #rightParenthesis1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
  set: #leftParenthesis2 for: #SHTextStylerST80 to: {self dbBedrock};
  set: #rightParenthesis2 for: #SHTextStylerST80 to: {self dbBedrock};
  set: #leftParenthesis3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
  set: #rightParenthesis3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
  set: #leftParenthesis4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
  set: #rightParenthesis4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
  set: #leftParenthesis5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
  set: #rightParenthesis5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
  set: #leftParenthesis6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
  set: #rightParenthesis6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
  set: #leftParenthesis7 for: #SHTextStylerST80 to: {Color yellow};
  set: #rightParenthesis7 for: #SHTextStylerST80 to: {Color yellow};
  set: #blockStart for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
  set: #blockEnd for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
  set: #blockStart1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
  set: #blockEnd1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
  set: #blockStart2 for: #SHTextStylerST80 to: {self dbBedrock};
  set: #blockEnd2 for: #SHTextStylerST80 to: {self dbBedrock};
  set: #blockStart3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
  set: #blockEnd3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
  set: #blockStart4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
  set: #blockEnd4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
  set: #blockStart5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
  set: #blockEnd5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
  set: #blockStart6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
  set: #blockEnd6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
  set: #blockStart7 for: #SHTextStylerST80 to: {Color yellow};
  set: #blockEnd7 for: #SHTextStylerST80 to: {Color yellow};
  set: #arrayStart for: #SHTextStylerST80 to: {self dbBedrock};
  set: #arrayEnd for: #SHTextStylerST80 to: {self dbBedrock};
  set: #arrayStart1 for: #SHTextStylerST80 to: {self dbForeground};
  set: #arrayEnd1 for: #SHTextStylerST80 to: {self dbForeground};
  set: #byteArrayStart for: #SHTextStylerST80 to: {self dbForeground};
  set: #byteArrayEnd for: #SHTextStylerST80 to: {self dbForeground};
  set: #byteArrayStart1 for: #SHTextStylerST80 to: {self dbForeground};
  set: #byteArrayEnd1 for: #SHTextStylerST80 to: {self dbForeground};
  set: #leftBrace for: #SHTextStylerST80 to: {self dbForeground};
  set: #rightBrace for: #SHTextStylerST80 to: {self dbForeground};
  set: #cascadeSeparator for: #SHTextStylerST80 to: {self dbForeground};
  set: #statementSeparator for: #SHTextStylerST80 to: {self dbForeground};
  set: #externalCallType for: #SHTextStylerST80 to: {self dbForeground};
  set: #externalCallTypePointerIndicator for: #SHTextStylerST80 to: {self dbForeground};
  set: #primitiveOrExternalCallStart for: #SHTextStylerST80 to: {self dbForeground};
  set: #primitiveOrExternalCallEnd for: #SHTextStylerST80 to: {self dbForeground};
  set: #methodTempBar for: #SHTextStylerST80 to: {self dbBedrock};
  set: #blockTempBar for: #SHTextStylerST80 to: {self dbBedrock};
  set: #blockArgsBar for: #SHTextStylerST80 to: {self dbBedrock};
  set: #primitive for: #SHTextStylerST80 to: {self dbGreen lighter. bold};
  set: #pragmaKeyword for: #SHTextStylerST80 to: {self dbGreen. bold};
  set: #pragmaUnary for: #SHTextStylerST80 to: {self dbGreen. bold};
  set: #pragmaBinary for: #SHTextStylerST80 to: {self dbGreen. bold};
  set: #externalFunctionCallingConvention for: #SHTextStylerST80 to: {self dbGreen. bold};
  set: #module for: #SHTextStylerST80 to: {self dbGreen. bold};
  set: #blockTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
  set: #blockPatternTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
  set: #instVar for: #SHTextStylerST80 to: {self dbYellow. normal };
  set: #workspaceVar for: #SHTextStylerST80 to: {self dbLabel. italic};
  set: #undefinedIdentifier for: #SHTextStylerST80 to: {self dbInvalid};
  set: #incompleteIdentifier for: #SHTextStylerST80 to: {self dbGray. underlined};
  set: #tempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
  set: #patternTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
  set: #poolConstant for: #SHTextStylerST80 to: {self dbConstant };
  set: #classVar for: #SHTextStylerST80 to: {self dbReference};
  set: #globalVar for: #SHTextStylerST80 to: {self dbClass. normal}.
  "And the text differ"
  aUserInterfaceTheme
  set: #insertTextAttributes for: #TextDiffBuilder to: { TextColor color: self dbRed };
  set: #removeTextAttributes for: #TextDiffBuilder to: { TextEmphasis struckOut. TextColor color: self dbBlue };
  set: #normalTextAttributes for: #TextDiffBuilder to: { TextEmphasis normal }.!

Item was changed:
  ----- Method: MonokaiTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: theme
 
  "Set-up fonts."
  theme
+ set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+ set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+ set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+ set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
- set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
- set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
- set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
- set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
  ----- Method: SolarizedTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: theme
 
  "Set-up fonts."
  theme
+ set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+ set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+ set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+ set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
- set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
- set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
- set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
- set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
  ----- Method: SolarizedTheme class>>addLightFonts: (in category 'instance creation') -----
  addLightFonts: theme
 
  "Set-up fonts."
  theme
+ set: #balloonHelpFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+ set: #standardButtonFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+ set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+ set: #haloLabelFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode].!
- set: #balloonHelpFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
- set: #standardButtonFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
- set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
- set: #haloLabelFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode).!

Item was changed:
  ----- Method: SqueakTheme class>>addFonts: (in category 'instance creation') -----
  addFonts: theme
 
  theme
+ set: #balloonHelpFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+ set: #standardButtonFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+ set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+ set: #haloLabelFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+ set: #standardFixedFont to: [TTCFont familyName: 'BitstreamVeraSansMono' pointSize: 12 emphasis: 0];
+ set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode].
- set: #balloonHelpFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
- set: #standardButtonFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
- set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
- set: #haloLabelFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
- set: #standardFixedFont to: (TTCFont familyName: 'BitstreamVeraSansMono' pointSize: 12 emphasis: 0);
- set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode).
  !

Item was changed:
  ----- Method: TrimTheme class>>addFonts: (in category 'instance creation') -----
  addFonts: theme
 
  "Set-up fonts."
  theme
+ set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+ set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+ set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+ set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+ set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
- set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
- set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
- set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
- set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
- set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
+ (PackageInfo named: 'System') postscript: 'UserInterfaceTheme cleanUpAndReset.'!
- (PackageInfo named: 'System') postscript: 'SystemNavigation initializeAuthors. "new: Tim Johnson (tcj)"'!


Reply | Threaded
Open this post in threaded view
|

Trunk broken (was: The Trunk: System-topa.1174.mcz)

Christoph Thiede

Hi Tobias, hi all,


this update just broke my image functionality sensitively! Right after loading System-topa.1174, the following happens to my fresh (!) trunk image the only adjustment to which I have applied being doing "Preferences changeFontSize: 12" once:


- The background image disappears, I'm seeing a single dull gray tone as a background instead

- Shout in all tools is broken (no syntax highlight any longer)

- Balloons are semi-transparent

- Dialog buttons have lost their color

- Also, the fonts look a bit larger now, but I cannot say whether I like the change or not.


I'm using a 202003021730 VM on Windows 10 64 bit.

None of these effects occurs if my font size is set to zero when loading the update.


I do not yet completely understand the changes you made, but IMO it would be a very good idea to remove this commit again from the trunk, if possible, and re-add it with an appropriate preamble and postload.


This screenshot shows the full extent of the crisis:



Best,

Christoph



Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 24. September 2020 23:13 Uhr
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: System-topa.1174.mcz
 
Tobias Pape uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-topa.1174.mcz

==================== Summary ====================

Name: System-topa.1174
Author: topa
Time: 24 September 2020, 11:14:16.007835 pm
UUID: 8f692d9f-4973-4aac-b181-9a2643089f8a
Ancestors: System-eem.1173

Make it so that Theme fonts are looked up on usage, not on theme creation.

=============== Diff against System-eem.1173 ===============

Item was changed:
  ----- Method: CommunityTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: aUserInterfaceTheme
         "Set-up fonts."
         aUserInterfaceTheme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis italic emphasisCode];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode]!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis italic emphasisCode);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode)!

Item was changed:
  ----- Method: CommunityTheme class>>addDarkSyntaxHighlighting: (in category 'instance creation') -----
  addDarkSyntaxHighlighting: aUserInterfaceTheme
         "self createDark apply."
+        | normal bold italic underlined | normal  := TextEmphasis normal.  bold:=TextEmphasis bold.  italic:=TextEmphasis italic.  underlined := TextEmphasis underlined.
-        | normal bold italic underlined darkMap | normal  := TextEmphasis normal.  bold:=TextEmphasis bold.  italic:=TextEmphasis italic.  underlined := TextEmphasis underlined.  darkMap := StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9.
         aUserInterfaceTheme
                 set: #color for: #TextAction to: self dbBlue;
        
                 set: #default for: #SHTextStylerST80 to: {self dbForeground};
                 set: #invalid for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #excessCode for: #SHTextStylerST80 to: {self dbInvalid twiceDarker};
                 "Descriptive text for humans, italicized."
                 set: #comment for: #SHTextStylerST80 to: {self dbComment. italic};
                 set: #unfinishedComment for: #SHTextStylerST80 to: {self dbComment darker. italic};
                 set: #'$' for: #SHTextStylerST80 to: {self dbConstant};
                 set: #character for: #SHTextStylerST80 to: {self dbConstant};
                 set: #integer for: #SHTextStylerST80 to: {self dbConstant};
                 set: #number for: #SHTextStylerST80 to: {self dbConstant};
                 set: #- for: #SHTextStylerST80 to: {self dbForeground. bold};
                 set: #= for: #SHTextStylerST80 to: {self dbForeground. bold};
                 set: #symbol for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #stringSymbol for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #literalArray for: #SHTextStylerST80 to: {self dbForeground};
                 set: #string for: #SHTextStylerST80 to: {self dbConstant};
                 set: #unfinishedString for: #SHTextStylerST80 to: {self dbConstant darker};
                 set: #assignment for: #SHTextStylerST80 to: {nil. bold};
                 set: #ansiAssignment for: #SHTextStylerST80 to: {nil. bold};
                 set: #literal for: #SHTextStylerST80 to: {nil. bold};
                 set: #keyword for: #SHTextStylerST80 to: {self dbMessage};
                 set: #binary for: #SHTextStylerST80 to: {self dbForeground. bold};
                 set: #unary for: #SHTextStylerST80 to: {self dbMessage};
                 set: #incompleteKeyword for: #SHTextStylerST80 to: {self dbMessage darker. {underlined. bold}};
                 set: #incompleteBinary for: #SHTextStylerST80 to: {self dbMessage darker. underlined};
                 set: #incompleteUnary for: #SHTextStylerST80 to: {self dbMessage darker. underlined};
                 set: #undefinedKeyword for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #undefinedBinary for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #undefinedUnary for: #SHTextStylerST80 to: {self dbInvalid};
                 "Delineate the selector (good for new users), and make the method look like a mini-document with a title."
                 set: #patternKeyword for: #SHTextStylerST80 to: {self dbMessage lighter.  {bold. underlined}};
                 set: #patternBinary for: #SHTextStylerST80 to: {nil. bold};
                 set: #patternUnary for: #SHTextStylerST80 to: {self dbMessage lighter.  {bold. underlined}};   
                 set: #self for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #super for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #true for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #false for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #nil for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #thisContext for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #return for: #SHTextStylerST80 to: {self dbForeground. bold};
+                set: #patternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. ""};  
+                set: #methodArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. ""};
-                set: #patternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. "darkMap"};   
-                set: #methodArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. "darkMap"};
                 set: #blockPatternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
                 set: #blockArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
                 set: #argument for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
                 set: #blockArgColon for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #leftParenthesis for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #rightParenthesis for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #leftParenthesis1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #rightParenthesis1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #leftParenthesis2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #rightParenthesis2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #leftParenthesis3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #rightParenthesis3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #leftParenthesis4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #rightParenthesis4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #leftParenthesis5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #rightParenthesis5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #leftParenthesis6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #rightParenthesis6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #leftParenthesis7 for: #SHTextStylerST80 to: {Color yellow};
                 set: #rightParenthesis7 for: #SHTextStylerST80 to: {Color yellow};
                 set: #blockStart for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #blockEnd for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #blockStart1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #blockEnd1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #blockStart2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockEnd2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockStart3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockEnd3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockStart4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockEnd4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockStart5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockEnd5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockStart6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockEnd6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockStart7 for: #SHTextStylerST80 to: {Color yellow};
                 set: #blockEnd7 for: #SHTextStylerST80 to: {Color yellow};                                                                                                                                                                                                                                                                                                      
                 set: #arrayStart for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #arrayEnd for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #arrayStart1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #arrayEnd1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayStart for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayEnd for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayStart1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayEnd1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #leftBrace for: #SHTextStylerST80 to: {self dbForeground};
                 set: #rightBrace for: #SHTextStylerST80 to: {self dbForeground};
                 set: #cascadeSeparator for: #SHTextStylerST80 to: {self dbForeground};
                 set: #statementSeparator for: #SHTextStylerST80 to: {self dbForeground};
                 set: #externalCallType for: #SHTextStylerST80 to: {self dbForeground};
                 set: #externalCallTypePointerIndicator for: #SHTextStylerST80 to: {self dbForeground};
                 set: #primitiveOrExternalCallStart for: #SHTextStylerST80 to: {self dbForeground};
                 set: #primitiveOrExternalCallEnd for: #SHTextStylerST80 to: {self dbForeground};
                 set: #methodTempBar for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockTempBar for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockArgsBar for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #primitive for: #SHTextStylerST80 to: {self dbGreen lighter. bold};
                 set: #pragmaKeyword for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #pragmaUnary for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #pragmaBinary for: #SHTextStylerST80 to: {self dbGreen. bold};                                                                    
                 set: #externalFunctionCallingConvention for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #module for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #blockTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #blockPatternTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #instVar for: #SHTextStylerST80 to: {self dbYellow. normal };
                 set: #workspaceVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #undefinedIdentifier for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #incompleteIdentifier for: #SHTextStylerST80 to: {self dbGray. underlined};
                 set: #tempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #patternTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #poolConstant for: #SHTextStylerST80 to: {self dbConstant };
                 set: #classVar for: #SHTextStylerST80 to: {self dbReference};
                 set: #globalVar for: #SHTextStylerST80 to: {self dbClass. normal}.
         "And the text differ"
         aUserInterfaceTheme    
                 set: #insertTextAttributes for: #TextDiffBuilder to: { TextColor color: self dbRed };
                 set: #removeTextAttributes for: #TextDiffBuilder to: { TextEmphasis struckOut. TextColor color: self dbBlue };
                 set: #normalTextAttributes for: #TextDiffBuilder to: { TextEmphasis normal }.!

Item was changed:
  ----- Method: MonokaiTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
  ----- Method: SolarizedTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
  ----- Method: SolarizedTheme class>>addLightFonts: (in category 'instance creation') -----
  addLightFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode).!

Item was changed:
  ----- Method: SqueakTheme class>>addFonts: (in category 'instance creation') -----
  addFonts: theme
 
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFixedFont to: [TTCFont familyName: 'BitstreamVeraSansMono' pointSize: 12 emphasis: 0];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode].
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFixedFont to: (TTCFont familyName: 'BitstreamVeraSansMono' pointSize: 12 emphasis: 0);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode).
  !

Item was changed:
  ----- Method: TrimTheme class>>addFonts: (in category 'instance creation') -----
  addFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
+ (PackageInfo named: 'System') postscript: 'UserInterfaceTheme cleanUpAndReset.'!
- (PackageInfo named: 'System') postscript: 'SystemNavigation initializeAuthors. "new: Tim Johnson (tcj)"'!




Carpe Squeak!
Reply | Threaded
Open this post in threaded view
|

Re: Trunk broken (was: The Trunk: System-topa.1174.mcz)

Tobias Pape
Hi

> On 25.09.2020, at 17:19, Thiede, Christoph <[hidden email]> wrote:
>
> Hi Tobias, hi all,
>
> this update just broke my image functionality sensitively! Right after loading System-topa.1174, the following happens to my fresh (!) trunk image the only adjustment to which I have applied being doing "Preferences changeFontSize: 12" once:
>
> - The background image disappears, I'm seeing a single dull gray tone as a background instead
> - Shout in all tools is broken (no syntax highlight any longer)
> - Balloons are semi-transparent
> - Dialog buttons have lost their color
> - Also, the fonts look a bit larger now, but I cannot say whether I like the change or not.
>
> I'm using a 202003021730 VM on Windows 10 64 bit.
> None of these effects occurs if my font size is set to zero when loading the update.
>
> I do not yet completely understand the changes you made, but IMO it would be a very good idea to remove this commit again from the trunk, if possible, and re-add it with an appropriate preamble and postload.
>
> This screenshot shows the full extent of the crisis:
>
>

Yea, Back it out.

I didn't realize font handling got so much more complex with the userinterfacethemes.

Ok, then no hidpi :)

-t

> Best,
> Christoph
>
> Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email]<[hidden email]>
> Gesendet: Donnerstag, 24. September 2020 23:13 Uhr
> An: [hidden email]; [hidden email]
> Betreff: [squeak-dev] The Trunk: System-topa.1174.mcz
>  
> Tobias Pape uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-topa.1174.mcz
>
> ==================== Summary ====================
>
> Name: System-topa.1174
> Author: topa
> Time: 24 September 2020, 11:14:16.007835 pm
> UUID: 8f692d9f-4973-4aac-b181-9a2643089f8a
> Ancestors: System-eem.1173
>
> Make it so that Theme fonts are looked up on usage, not on theme creation.
>
> =============== Diff against System-eem.1173 ===============
>
> Item was changed:
>   ----- Method: CommunityTheme class>>addDarkFonts: (in category 'instance creation') -----
>   addDarkFonts: aUserInterfaceTheme
>          "Set-up fonts."
>          aUserInterfaceTheme
> +                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis italic emphasisCode];
> +                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
> +                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
> +                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode]!
> -                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis italic emphasisCode);
> -                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
> -                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
> -                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode)!
>
> Item was changed:
>   ----- Method: CommunityTheme class>>addDarkSyntaxHighlighting: (in category 'instance creation') -----
>   addDarkSyntaxHighlighting: aUserInterfaceTheme
>          "self createDark apply."
> +        | normal bold italic underlined | normal  := TextEmphasis normal.  bold:=TextEmphasis bold.  italic:=TextEmphasis italic.  underlined := TextEmphasis underlined.
> -        | normal bold italic underlined darkMap | normal  := TextEmphasis normal.  bold:=TextEmphasis bold.  italic:=TextEmphasis italic.  underlined := TextEmphasis underlined.  darkMap := StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9.
>          aUserInterfaceTheme
>                  set: #color for: #TextAction to: self dbBlue;
>          
>                  set: #default for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #invalid for: #SHTextStylerST80 to: {self dbInvalid};
>                  set: #excessCode for: #SHTextStylerST80 to: {self dbInvalid twiceDarker};
>                  "Descriptive text for humans, italicized."
>                  set: #comment for: #SHTextStylerST80 to: {self dbComment. italic};
>                  set: #unfinishedComment for: #SHTextStylerST80 to: {self dbComment darker. italic};
>                  set: #'$' for: #SHTextStylerST80 to: {self dbConstant};
>                  set: #character for: #SHTextStylerST80 to: {self dbConstant};
>                  set: #integer for: #SHTextStylerST80 to: {self dbConstant};
>                  set: #number for: #SHTextStylerST80 to: {self dbConstant};
>                  set: #- for: #SHTextStylerST80 to: {self dbForeground. bold};
>                  set: #= for: #SHTextStylerST80 to: {self dbForeground. bold};
>                  set: #symbol for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #stringSymbol for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #literalArray for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #string for: #SHTextStylerST80 to: {self dbConstant};
>                  set: #unfinishedString for: #SHTextStylerST80 to: {self dbConstant darker};
>                  set: #assignment for: #SHTextStylerST80 to: {nil. bold};
>                  set: #ansiAssignment for: #SHTextStylerST80 to: {nil. bold};
>                  set: #literal for: #SHTextStylerST80 to: {nil. bold};
>                  set: #keyword for: #SHTextStylerST80 to: {self dbMessage};
>                  set: #binary for: #SHTextStylerST80 to: {self dbForeground. bold};
>                  set: #unary for: #SHTextStylerST80 to: {self dbMessage};
>                  set: #incompleteKeyword for: #SHTextStylerST80 to: {self dbMessage darker. {underlined. bold}};
>                  set: #incompleteBinary for: #SHTextStylerST80 to: {self dbMessage darker. underlined};
>                  set: #incompleteUnary for: #SHTextStylerST80 to: {self dbMessage darker. underlined};
>                  set: #undefinedKeyword for: #SHTextStylerST80 to: {self dbInvalid};
>                  set: #undefinedBinary for: #SHTextStylerST80 to: {self dbInvalid};
>                  set: #undefinedUnary for: #SHTextStylerST80 to: {self dbInvalid};
>                  "Delineate the selector (good for new users), and make the method look like a mini-document with a title."
>                  set: #patternKeyword for: #SHTextStylerST80 to: {self dbMessage lighter.  {bold. underlined}};
>                  set: #patternBinary for: #SHTextStylerST80 to: {nil. bold};
>                  set: #patternUnary for: #SHTextStylerST80 to: {self dbMessage lighter.  {bold. underlined}};    
>                  set: #self for: #SHTextStylerST80 to: {self dbBedrock. bold};
>                  set: #super for: #SHTextStylerST80 to: {self dbBedrock. bold};
>                  set: #true for: #SHTextStylerST80 to: {self dbBedrock. bold};
>                  set: #false for: #SHTextStylerST80 to: {self dbBedrock. bold};
>                  set: #nil for: #SHTextStylerST80 to: {self dbBedrock. bold};
>                  set: #thisContext for: #SHTextStylerST80 to: {self dbBedrock. bold};
>                  set: #return for: #SHTextStylerST80 to: {self dbForeground. bold};
> +                set: #patternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. ""};  
> +                set: #methodArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. ""};
> -                set: #patternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. "darkMap"};    
> -                set: #methodArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. "darkMap"};
>                  set: #blockPatternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
>                  set: #blockArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
>                  set: #argument for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
>                  set: #blockArgColon for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #leftParenthesis for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
>                  set: #rightParenthesis for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
>                  set: #leftParenthesis1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
>                  set: #rightParenthesis1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
>                  set: #leftParenthesis2 for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #rightParenthesis2 for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #leftParenthesis3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
>                  set: #rightParenthesis3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
>                  set: #leftParenthesis4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
>                  set: #rightParenthesis4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
>                  set: #leftParenthesis5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
>                  set: #rightParenthesis5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
>                  set: #leftParenthesis6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
>                  set: #rightParenthesis6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
>                  set: #leftParenthesis7 for: #SHTextStylerST80 to: {Color yellow};
>                  set: #rightParenthesis7 for: #SHTextStylerST80 to: {Color yellow};
>                  set: #blockStart for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
>                  set: #blockEnd for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
>                  set: #blockStart1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
>                  set: #blockEnd1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
>                  set: #blockStart2 for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #blockEnd2 for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #blockStart3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
>                  set: #blockEnd3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
>                  set: #blockStart4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
>                  set: #blockEnd4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
>                  set: #blockStart5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
>                  set: #blockEnd5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
>                  set: #blockStart6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
>                  set: #blockEnd6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
>                  set: #blockStart7 for: #SHTextStylerST80 to: {Color yellow};
>                  set: #blockEnd7 for: #SHTextStylerST80 to: {Color yellow};                                                                                                                                                                                                                                                                                                      
>                  set: #arrayStart for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #arrayEnd for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #arrayStart1 for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #arrayEnd1 for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #byteArrayStart for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #byteArrayEnd for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #byteArrayStart1 for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #byteArrayEnd1 for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #leftBrace for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #rightBrace for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #cascadeSeparator for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #statementSeparator for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #externalCallType for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #externalCallTypePointerIndicator for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #primitiveOrExternalCallStart for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #primitiveOrExternalCallEnd for: #SHTextStylerST80 to: {self dbForeground};
>                  set: #methodTempBar for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #blockTempBar for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #blockArgsBar for: #SHTextStylerST80 to: {self dbBedrock};
>                  set: #primitive for: #SHTextStylerST80 to: {self dbGreen lighter. bold};
>                  set: #pragmaKeyword for: #SHTextStylerST80 to: {self dbGreen. bold};
>                  set: #pragmaUnary for: #SHTextStylerST80 to: {self dbGreen. bold};
>                  set: #pragmaBinary for: #SHTextStylerST80 to: {self dbGreen. bold};                                                                    
>                  set: #externalFunctionCallingConvention for: #SHTextStylerST80 to: {self dbGreen. bold};
>                  set: #module for: #SHTextStylerST80 to: {self dbGreen. bold};
>                  set: #blockTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
>                  set: #blockPatternTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
>                  set: #instVar for: #SHTextStylerST80 to: {self dbYellow. normal };
>                  set: #workspaceVar for: #SHTextStylerST80 to: {self dbLabel. italic};
>                  set: #undefinedIdentifier for: #SHTextStylerST80 to: {self dbInvalid};
>                  set: #incompleteIdentifier for: #SHTextStylerST80 to: {self dbGray. underlined};
>                  set: #tempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
>                  set: #patternTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
>                  set: #poolConstant for: #SHTextStylerST80 to: {self dbConstant };
>                  set: #classVar for: #SHTextStylerST80 to: {self dbReference};
>                  set: #globalVar for: #SHTextStylerST80 to: {self dbClass. normal}.
>          "And the text differ"
>          aUserInterfaceTheme    
>                  set: #insertTextAttributes for: #TextDiffBuilder to: { TextColor color: self dbRed };
>                  set: #removeTextAttributes for: #TextDiffBuilder to: { TextEmphasis struckOut. TextColor color: self dbBlue };
>                  set: #normalTextAttributes for: #TextDiffBuilder to: { TextEmphasis normal }.!
>
> Item was changed:
>   ----- Method: MonokaiTheme class>>addDarkFonts: (in category 'instance creation') -----
>   addDarkFonts: theme
>  
>          "Set-up fonts."
>          theme
> +                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
> +                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
> +                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
> +                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
> -                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
> -                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
> -                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
> -                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!
>
> Item was changed:
>   ----- Method: SolarizedTheme class>>addDarkFonts: (in category 'instance creation') -----
>   addDarkFonts: theme
>  
>          "Set-up fonts."
>          theme
> +                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
> +                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
> +                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
> +                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
> -                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
> -                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
> -                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
> -                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!
>
> Item was changed:
>   ----- Method: SolarizedTheme class>>addLightFonts: (in category 'instance creation') -----
>   addLightFonts: theme
>  
>          "Set-up fonts."
>          theme
> +                set: #balloonHelpFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
> +                set: #standardButtonFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
> +                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
> +                set: #haloLabelFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode].!
> -                set: #balloonHelpFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
> -                set: #standardButtonFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
> -                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
> -                set: #haloLabelFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode).!
>
> Item was changed:
>   ----- Method: SqueakTheme class>>addFonts: (in category 'instance creation') -----
>   addFonts: theme
>  
>          theme
> +                set: #balloonHelpFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
> +                set: #standardButtonFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
> +                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
> +                set: #haloLabelFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
> +                set: #standardFixedFont to: [TTCFont familyName: 'BitstreamVeraSansMono' pointSize: 12 emphasis: 0];
> +                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode].
> -                set: #balloonHelpFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
> -                set: #standardButtonFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
> -                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
> -                set: #haloLabelFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
> -                set: #standardFixedFont to: (TTCFont familyName: 'BitstreamVeraSansMono' pointSize: 12 emphasis: 0);
> -                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode).
>   !
>
> Item was changed:
>   ----- Method: TrimTheme class>>addFonts: (in category 'instance creation') -----
>   addFonts: theme
>  
>          "Set-up fonts."
>          theme
> +                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
> +                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
> +                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
> +                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
> +                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
> -                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
> -                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
> -                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
> -                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
> -                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!
>
> Item was changed:
> + (PackageInfo named: 'System') postscript: 'UserInterfaceTheme cleanUpAndReset.'!
> - (PackageInfo named: 'System') postscript: 'SystemNavigation initializeAuthors. "new: Tim Johnson (tcj)"'!



Reply | Threaded
Open this post in threaded view
|

Re: Trunk broken (was: The Trunk: System-topa.1174.mcz)

marcel.taeumel
In reply to this post by Christoph Thiede
Hi Christoph,

in my image, too, the "Demo +"-Theme was not updated. Going back to "Squeak" and then hit "Extras > Themes & Colors > Set High-DPI Mode" fixed those issues in my image.

The bug is most likely in the full-copy of the current theme for the Demo/High-DPI mode. And UserInterfaceTheme class >> #cleanUpAndReset not considering that copy.

Best,
Marcel

Am 25.09.2020 17:19:22 schrieb Thiede, Christoph <[hidden email]>:

Hi Tobias, hi all,


this update just broke my image functionality sensitively! Right after loading System-topa.1174, the following happens to my fresh (!) trunk image the only adjustment to which I have applied being doing "Preferences changeFontSize: 12" once:


- The background image disappears, I'm seeing a single dull gray tone as a background instead

- Shout in all tools is broken (no syntax highlight any longer)

- Balloons are semi-transparent

- Dialog buttons have lost their color

- Also, the fonts look a bit larger now, but I cannot say whether I like the change or not.


I'm using a 202003021730 VM on Windows 10 64 bit.

None of these effects occurs if my font size is set to zero when loading the update.


I do not yet completely understand the changes you made, but IMO it would be a very good idea to remove this commit again from the trunk, if possible, and re-add it with an appropriate preamble and postload.


This screenshot shows the full extent of the crisis:



Best,

Christoph



Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 24. September 2020 23:13 Uhr
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: System-topa.1174.mcz
 
Tobias Pape uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-topa.1174.mcz

==================== Summary ====================

Name: System-topa.1174
Author: topa
Time: 24 September 2020, 11:14:16.007835 pm
UUID: 8f692d9f-4973-4aac-b181-9a2643089f8a
Ancestors: System-eem.1173

Make it so that Theme fonts are looked up on usage, not on theme creation.

=============== Diff against System-eem.1173 ===============

Item was changed:
  ----- Method: CommunityTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: aUserInterfaceTheme
         "Set-up fonts."
         aUserInterfaceTheme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis italic emphasisCode];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode]!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis italic emphasisCode);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode)!

Item was changed:
  ----- Method: CommunityTheme class>>addDarkSyntaxHighlighting: (in category 'instance creation') -----
  addDarkSyntaxHighlighting: aUserInterfaceTheme
         "self createDark apply."
+        | normal bold italic underlined | normal  := TextEmphasis normal.  bold:=TextEmphasis bold.  italic:=TextEmphasis italic.  underlined := TextEmphasis underlined.
-        | normal bold italic underlined darkMap | normal  := TextEmphasis normal.  bold:=TextEmphasis bold.  italic:=TextEmphasis italic.  underlined := TextEmphasis underlined.  darkMap := StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9.
         aUserInterfaceTheme
                 set: #color for: #TextAction to: self dbBlue;
        
                 set: #default for: #SHTextStylerST80 to: {self dbForeground};
                 set: #invalid for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #excessCode for: #SHTextStylerST80 to: {self dbInvalid twiceDarker};
                 "Descriptive text for humans, italicized."
                 set: #comment for: #SHTextStylerST80 to: {self dbComment. italic};
                 set: #unfinishedComment for: #SHTextStylerST80 to: {self dbComment darker. italic};
                 set: #'$' for: #SHTextStylerST80 to: {self dbConstant};
                 set: #character for: #SHTextStylerST80 to: {self dbConstant};
                 set: #integer for: #SHTextStylerST80 to: {self dbConstant};
                 set: #number for: #SHTextStylerST80 to: {self dbConstant};
                 set: #- for: #SHTextStylerST80 to: {self dbForeground. bold};
                 set: #= for: #SHTextStylerST80 to: {self dbForeground. bold};
                 set: #symbol for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #stringSymbol for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #literalArray for: #SHTextStylerST80 to: {self dbForeground};
                 set: #string for: #SHTextStylerST80 to: {self dbConstant};
                 set: #unfinishedString for: #SHTextStylerST80 to: {self dbConstant darker};
                 set: #assignment for: #SHTextStylerST80 to: {nil. bold};
                 set: #ansiAssignment for: #SHTextStylerST80 to: {nil. bold};
                 set: #literal for: #SHTextStylerST80 to: {nil. bold};
                 set: #keyword for: #SHTextStylerST80 to: {self dbMessage};
                 set: #binary for: #SHTextStylerST80 to: {self dbForeground. bold};
                 set: #unary for: #SHTextStylerST80 to: {self dbMessage};
                 set: #incompleteKeyword for: #SHTextStylerST80 to: {self dbMessage darker. {underlined. bold}};
                 set: #incompleteBinary for: #SHTextStylerST80 to: {self dbMessage darker. underlined};
                 set: #incompleteUnary for: #SHTextStylerST80 to: {self dbMessage darker. underlined};
                 set: #undefinedKeyword for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #undefinedBinary for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #undefinedUnary for: #SHTextStylerST80 to: {self dbInvalid};
                 "Delineate the selector (good for new users), and make the method look like a mini-document with a title."
                 set: #patternKeyword for: #SHTextStylerST80 to: {self dbMessage lighter.  {bold. underlined}};
                 set: #patternBinary for: #SHTextStylerST80 to: {nil. bold};
                 set: #patternUnary for: #SHTextStylerST80 to: {self dbMessage lighter.  {bold. underlined}};   
                 set: #self for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #super for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #true for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #false for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #nil for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #thisContext for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #return for: #SHTextStylerST80 to: {self dbForeground. bold};
+                set: #patternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. ""};  
+                set: #methodArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. ""};
-                set: #patternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. "darkMap"};   
-                set: #methodArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. "darkMap"};
                 set: #blockPatternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
                 set: #blockArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
                 set: #argument for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
                 set: #blockArgColon for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #leftParenthesis for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #rightParenthesis for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #leftParenthesis1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #rightParenthesis1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #leftParenthesis2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #rightParenthesis2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #leftParenthesis3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #rightParenthesis3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #leftParenthesis4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #rightParenthesis4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #leftParenthesis5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #rightParenthesis5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #leftParenthesis6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #rightParenthesis6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #leftParenthesis7 for: #SHTextStylerST80 to: {Color yellow};
                 set: #rightParenthesis7 for: #SHTextStylerST80 to: {Color yellow};
                 set: #blockStart for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #blockEnd for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #blockStart1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #blockEnd1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #blockStart2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockEnd2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockStart3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockEnd3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockStart4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockEnd4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockStart5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockEnd5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockStart6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockEnd6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockStart7 for: #SHTextStylerST80 to: {Color yellow};
                 set: #blockEnd7 for: #SHTextStylerST80 to: {Color yellow};                                                                                                                                                                                                                                                                                                      
                 set: #arrayStart for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #arrayEnd for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #arrayStart1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #arrayEnd1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayStart for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayEnd for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayStart1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayEnd1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #leftBrace for: #SHTextStylerST80 to: {self dbForeground};
                 set: #rightBrace for: #SHTextStylerST80 to: {self dbForeground};
                 set: #cascadeSeparator for: #SHTextStylerST80 to: {self dbForeground};
                 set: #statementSeparator for: #SHTextStylerST80 to: {self dbForeground};
                 set: #externalCallType for: #SHTextStylerST80 to: {self dbForeground};
                 set: #externalCallTypePointerIndicator for: #SHTextStylerST80 to: {self dbForeground};
                 set: #primitiveOrExternalCallStart for: #SHTextStylerST80 to: {self dbForeground};
                 set: #primitiveOrExternalCallEnd for: #SHTextStylerST80 to: {self dbForeground};
                 set: #methodTempBar for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockTempBar for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockArgsBar for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #primitive for: #SHTextStylerST80 to: {self dbGreen lighter. bold};
                 set: #pragmaKeyword for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #pragmaUnary for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #pragmaBinary for: #SHTextStylerST80 to: {self dbGreen. bold};                                                                    
                 set: #externalFunctionCallingConvention for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #module for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #blockTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #blockPatternTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #instVar for: #SHTextStylerST80 to: {self dbYellow. normal };
                 set: #workspaceVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #undefinedIdentifier for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #incompleteIdentifier for: #SHTextStylerST80 to: {self dbGray. underlined};
                 set: #tempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #patternTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #poolConstant for: #SHTextStylerST80 to: {self dbConstant };
                 set: #classVar for: #SHTextStylerST80 to: {self dbReference};
                 set: #globalVar for: #SHTextStylerST80 to: {self dbClass. normal}.
         "And the text differ"
         aUserInterfaceTheme    
                 set: #insertTextAttributes for: #TextDiffBuilder to: { TextColor color: self dbRed };
                 set: #removeTextAttributes for: #TextDiffBuilder to: { TextEmphasis struckOut. TextColor color: self dbBlue };
                 set: #normalTextAttributes for: #TextDiffBuilder to: { TextEmphasis normal }.!

Item was changed:
  ----- Method: MonokaiTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
  ----- Method: SolarizedTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
  ----- Method: SolarizedTheme class>>addLightFonts: (in category 'instance creation') -----
  addLightFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode).!

Item was changed:
  ----- Method: SqueakTheme class>>addFonts: (in category 'instance creation') -----
  addFonts: theme
 
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFixedFont to: [TTCFont familyName: 'BitstreamVeraSansMono' pointSize: 12 emphasis: 0];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode].
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFixedFont to: (TTCFont familyName: 'BitstreamVeraSansMono' pointSize: 12 emphasis: 0);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode).
  !

Item was changed:
  ----- Method: TrimTheme class>>addFonts: (in category 'instance creation') -----
  addFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
+ (PackageInfo named: 'System') postscript: 'UserInterfaceTheme cleanUpAndReset.'!
- (PackageInfo named: 'System') postscript: 'SystemNavigation initializeAuthors. "new: Tim Johnson (tcj)"'!




Reply | Threaded
Open this post in threaded view
|

Re: Trunk broken (was: The Trunk: System-topa.1174.mcz)

Christoph Thiede

Hi Marcel,


alright, that fixed it. Please see System-ct.1175, which should fix all affected images. Independently of that hotfix, we need to fix the copy issue. At the moment, I'm not yet familiar with this stuff ...


Best,

Christoph



Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 28. September 2020 12:56:24
An: squeak-dev; [hidden email]
Betreff: Re: [squeak-dev] Trunk broken (was: The Trunk: System-topa.1174.mcz)
 
Hi Christoph,

in my image, too, the "Demo +"-Theme was not updated. Going back to "Squeak" and then hit "Extras > Themes & Colors > Set High-DPI Mode" fixed those issues in my image.

The bug is most likely in the full-copy of the current theme for the Demo/High-DPI mode. And UserInterfaceTheme class >> #cleanUpAndReset not considering that copy.

Best,
Marcel

Am 25.09.2020 17:19:22 schrieb Thiede, Christoph <[hidden email]>:

Hi Tobias, hi all,


this update just broke my image functionality sensitively! Right after loading System-topa.1174, the following happens to my fresh (!) trunk image the only adjustment to which I have applied being doing "Preferences changeFontSize: 12" once:


- The background image disappears, I'm seeing a single dull gray tone as a background instead

- Shout in all tools is broken (no syntax highlight any longer)

- Balloons are semi-transparent

- Dialog buttons have lost their color

- Also, the fonts look a bit larger now, but I cannot say whether I like the change or not.


I'm using a 202003021730 VM on Windows 10 64 bit.

None of these effects occurs if my font size is set to zero when loading the update.


I do not yet completely understand the changes you made, but IMO it would be a very good idea to remove this commit again from the trunk, if possible, and re-add it with an appropriate preamble and postload.


This screenshot shows the full extent of the crisis:



Best,

Christoph



Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 24. September 2020 23:13 Uhr
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: System-topa.1174.mcz
 
Tobias Pape uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-topa.1174.mcz

==================== Summary ====================

Name: System-topa.1174
Author: topa
Time: 24 September 2020, 11:14:16.007835 pm
UUID: 8f692d9f-4973-4aac-b181-9a2643089f8a
Ancestors: System-eem.1173

Make it so that Theme fonts are looked up on usage, not on theme creation.

=============== Diff against System-eem.1173 ===============

Item was changed:
  ----- Method: CommunityTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: aUserInterfaceTheme
         "Set-up fonts."
         aUserInterfaceTheme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis italic emphasisCode];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode]!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis italic emphasisCode);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode)!

Item was changed:
  ----- Method: CommunityTheme class>>addDarkSyntaxHighlighting: (in category 'instance creation') -----
  addDarkSyntaxHighlighting: aUserInterfaceTheme
         "self createDark apply."
+        | normal bold italic underlined | normal  := TextEmphasis normal.  bold:=TextEmphasis bold.  italic:=TextEmphasis italic.  underlined := TextEmphasis underlined.
-        | normal bold italic underlined darkMap | normal  := TextEmphasis normal.  bold:=TextEmphasis bold.  italic:=TextEmphasis italic.  underlined := TextEmphasis underlined.  darkMap := StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9.
         aUserInterfaceTheme
                 set: #color for: #TextAction to: self dbBlue;
        
                 set: #default for: #SHTextStylerST80 to: {self dbForeground};
                 set: #invalid for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #excessCode for: #SHTextStylerST80 to: {self dbInvalid twiceDarker};
                 "Descriptive text for humans, italicized."
                 set: #comment for: #SHTextStylerST80 to: {self dbComment. italic};
                 set: #unfinishedComment for: #SHTextStylerST80 to: {self dbComment darker. italic};
                 set: #'$' for: #SHTextStylerST80 to: {self dbConstant};
                 set: #character for: #SHTextStylerST80 to: {self dbConstant};
                 set: #integer for: #SHTextStylerST80 to: {self dbConstant};
                 set: #number for: #SHTextStylerST80 to: {self dbConstant};
                 set: #- for: #SHTextStylerST80 to: {self dbForeground. bold};
                 set: #= for: #SHTextStylerST80 to: {self dbForeground. bold};
                 set: #symbol for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #stringSymbol for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #literalArray for: #SHTextStylerST80 to: {self dbForeground};
                 set: #string for: #SHTextStylerST80 to: {self dbConstant};
                 set: #unfinishedString for: #SHTextStylerST80 to: {self dbConstant darker};
                 set: #assignment for: #SHTextStylerST80 to: {nil. bold};
                 set: #ansiAssignment for: #SHTextStylerST80 to: {nil. bold};
                 set: #literal for: #SHTextStylerST80 to: {nil. bold};
                 set: #keyword for: #SHTextStylerST80 to: {self dbMessage};
                 set: #binary for: #SHTextStylerST80 to: {self dbForeground. bold};
                 set: #unary for: #SHTextStylerST80 to: {self dbMessage};
                 set: #incompleteKeyword for: #SHTextStylerST80 to: {self dbMessage darker. {underlined. bold}};
                 set: #incompleteBinary for: #SHTextStylerST80 to: {self dbMessage darker. underlined};
                 set: #incompleteUnary for: #SHTextStylerST80 to: {self dbMessage darker. underlined};
                 set: #undefinedKeyword for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #undefinedBinary for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #undefinedUnary for: #SHTextStylerST80 to: {self dbInvalid};
                 "Delineate the selector (good for new users), and make the method look like a mini-document with a title."
                 set: #patternKeyword for: #SHTextStylerST80 to: {self dbMessage lighter.  {bold. underlined}};
                 set: #patternBinary for: #SHTextStylerST80 to: {nil. bold};
                 set: #patternUnary for: #SHTextStylerST80 to: {self dbMessage lighter.  {bold. underlined}};   
                 set: #self for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #super for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #true for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #false for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #nil for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #thisContext for: #SHTextStylerST80 to: {self dbBedrock. bold};
                 set: #return for: #SHTextStylerST80 to: {self dbForeground. bold};
+                set: #patternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. ""};  
+                set: #methodArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. ""};
-                set: #patternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. "darkMap"};   
-                set: #methodArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter. TextEmphasis normal. "darkMap"};
                 set: #blockPatternArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
                 set: #blockArg for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
                 set: #argument for: #SHTextStylerST80 to: {self dbSelection twiceLighter};
                 set: #blockArgColon for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #leftParenthesis for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #rightParenthesis for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #leftParenthesis1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #rightParenthesis1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #leftParenthesis2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #rightParenthesis2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #leftParenthesis3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #rightParenthesis3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #leftParenthesis4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #rightParenthesis4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #leftParenthesis5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #rightParenthesis5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #leftParenthesis6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #rightParenthesis6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #leftParenthesis7 for: #SHTextStylerST80 to: {Color yellow};
                 set: #rightParenthesis7 for: #SHTextStylerST80 to: {Color yellow};
                 set: #blockStart for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #blockEnd for: #SHTextStylerST80 to: {self dbBedrock muchLighter};
                 set: #blockStart1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #blockEnd1 for: #SHTextStylerST80 to: {self dbBedrock twiceLighter};
                 set: #blockStart2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockEnd2 for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockStart3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockEnd3 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockStart4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockEnd4 for: #SHTextStylerST80 to: {self dbPurple muchLighter};
                 set: #blockStart5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockEnd5 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockStart6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockEnd6 for: #SHTextStylerST80 to: {self dbOrange muchLighter};
                 set: #blockStart7 for: #SHTextStylerST80 to: {Color yellow};
                 set: #blockEnd7 for: #SHTextStylerST80 to: {Color yellow};                                                                                                                                                                                                                                                                                                      
                 set: #arrayStart for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #arrayEnd for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #arrayStart1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #arrayEnd1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayStart for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayEnd for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayStart1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #byteArrayEnd1 for: #SHTextStylerST80 to: {self dbForeground};
                 set: #leftBrace for: #SHTextStylerST80 to: {self dbForeground};
                 set: #rightBrace for: #SHTextStylerST80 to: {self dbForeground};
                 set: #cascadeSeparator for: #SHTextStylerST80 to: {self dbForeground};
                 set: #statementSeparator for: #SHTextStylerST80 to: {self dbForeground};
                 set: #externalCallType for: #SHTextStylerST80 to: {self dbForeground};
                 set: #externalCallTypePointerIndicator for: #SHTextStylerST80 to: {self dbForeground};
                 set: #primitiveOrExternalCallStart for: #SHTextStylerST80 to: {self dbForeground};
                 set: #primitiveOrExternalCallEnd for: #SHTextStylerST80 to: {self dbForeground};
                 set: #methodTempBar for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockTempBar for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #blockArgsBar for: #SHTextStylerST80 to: {self dbBedrock};
                 set: #primitive for: #SHTextStylerST80 to: {self dbGreen lighter. bold};
                 set: #pragmaKeyword for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #pragmaUnary for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #pragmaBinary for: #SHTextStylerST80 to: {self dbGreen. bold};                                                                    
                 set: #externalFunctionCallingConvention for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #module for: #SHTextStylerST80 to: {self dbGreen. bold};
                 set: #blockTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #blockPatternTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #instVar for: #SHTextStylerST80 to: {self dbYellow. normal };
                 set: #workspaceVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #undefinedIdentifier for: #SHTextStylerST80 to: {self dbInvalid};
                 set: #incompleteIdentifier for: #SHTextStylerST80 to: {self dbGray. underlined};
                 set: #tempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #patternTempVar for: #SHTextStylerST80 to: {self dbLabel. italic};
                 set: #poolConstant for: #SHTextStylerST80 to: {self dbConstant };
                 set: #classVar for: #SHTextStylerST80 to: {self dbReference};
                 set: #globalVar for: #SHTextStylerST80 to: {self dbClass. normal}.
         "And the text differ"
         aUserInterfaceTheme    
                 set: #insertTextAttributes for: #TextDiffBuilder to: { TextColor color: self dbRed };
                 set: #removeTextAttributes for: #TextDiffBuilder to: { TextEmphasis struckOut. TextColor color: self dbBlue };
                 set: #normalTextAttributes for: #TextDiffBuilder to: { TextEmphasis normal }.!

Item was changed:
  ----- Method: MonokaiTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
  ----- Method: SolarizedTheme class>>addDarkFonts: (in category 'instance creation') -----
  addDarkFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
  ----- Method: SolarizedTheme class>>addLightFonts: (in category 'instance creation') -----
  addLightFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode).!

Item was changed:
  ----- Method: SqueakTheme class>>addFonts: (in category 'instance creation') -----
  addFonts: theme
 
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9];
+                set: #standardFixedFont to: [TTCFont familyName: 'BitstreamVeraSansMono' pointSize: 12 emphasis: 0];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode].
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9);
-                set: #standardFixedFont to: (TTCFont familyName: 'BitstreamVeraSansMono' pointSize: 12 emphasis: 0);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Bitmap DejaVu Sans' pointSize: 9 emphasized: TextEmphasis bold emphasisCode).
  !

Item was changed:
  ----- Method: TrimTheme class>>addFonts: (in category 'instance creation') -----
  addFonts: theme
 
         "Set-up fonts."
         theme
+                set: #balloonHelpFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardButtonFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7];
+                set: #standardCodeFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardFlapFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode];
+                set: #haloLabelFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardListFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardMenuFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #standardSystemFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9];
+                set: #windowTitleFont to: [StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9].!
-                set: #balloonHelpFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardButtonFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7);
-                set: #standardCodeFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardFlapFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 7 emphasized: TextEmphasis bold emphasisCode);
-                set: #haloLabelFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardListFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardMenuFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #standardSystemFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9);
-                set: #windowTitleFont to: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 9).!

Item was changed:
+ (PackageInfo named: 'System') postscript: 'UserInterfaceTheme cleanUpAndReset.'!
- (PackageInfo named: 'System') postscript: 'SystemNavigation initializeAuthors. "new: Tim Johnson (tcj)"'!




Carpe Squeak!