The Trunk: SystemReporter-mt.24.mcz

Marcel Taeumel uploaded a new version of SystemReporter to project The Trunk:
http://source.squeak.org/trunk/SystemReporter-mt.24.mcz

==================== Summary ====================

Name: SystemReporter-mt.24
Author: mt
Time: 18 May 2015, 10:16:53.323 am
UUID: 8a99a2df-13ea-6149-bcad-cb460f6c8e6b
Ancestors: SystemReporter-dtl.23

Fixed confirm-actions for all longer lasting operations in the system reporter: space analysis, tiny benchmarks, test runner. Support 'cancel' for all of them.

=============== Diff against SystemReporter-dtl.23 ===============

Item was changed:
  ----- Method: SystemReporter>>reportSpaceAnalysis: (in category 'reporting') -----
  reportSpaceAnalysis: aStream
 
  spaceAnalysisResult ifNil: [
+ (UIManager default
+ confirm: 'Running the space analysis\might take a few seconds.' withCRs translated
+ title: 'Continue?' translated)
+ ifFalse: [
+ categoriesSelected remove: #'Space Analysis'.
+ ^ self changed: #categorySelected ].
+
- UIManager inform: 'Running the Space Analysis\will take a few seconds' withCRs.
  spaceAnalysisResult := String streamContents: [ :stream |
  SpaceTally new printSpaceAnalysis: 1 onStream: stream ] ].
  self header: 'Space Analysis' on: aStream.
  aStream nextPutAll: spaceAnalysisResult; cr!

Item was changed:
  ----- Method: SystemReporter>>reportTestRunner: (in category 'reporting') -----
  reportTestRunner: aStream
+
+ testRunner ifNil: [
+ (UIManager default
+ confirm: 'Running all tests might\take a some minutes.' withCRs translated
+ title: 'Continue?')
+ ifTrue: [ testRunner := TestRunner new runAll ]
+ ifFalse:
+ [ categoriesSelected remove: #SUnit.
+ ^ self changed: #categorySelected ] ].
- testRunner ifNil:
- [ | runAllTests |
- runAllTests := UIManager confirm: 'Running all Tests\will take long time' withCRs.
- runAllTests
- ifTrue: [ testRunner := TestRunner new runAll ]
- ifFalse:
- [ categoriesSelected remove: #SUnit.
- ^ self changed: #categorySelected ] ].
  self
  header: 'SUnit Results'
  on: aStream.
  aStream nextPutAll: testRunner statusText ; cr ; cr.
  self
  header: 'Failed Tests'
  on: aStream.
  testRunner failedList do:
  [ : each | self
  printDebugExpressionFor: each
  on: aStream.
  aStream cr ].
  aStream cr.
  self
  header: 'Errors'
  on: aStream.
  testRunner errorList do:
  [ : each | self
  printDebugExpressionFor: each
  on: aStream.
  aStream cr ]!

Item was changed:
  ----- Method: SystemReporter>>reportTinyBenchmarks: (in category 'reporting') -----
  reportTinyBenchmarks: aStream
  tinyBenchmarksResult ifNil: [
+ (UIManager default
+ confirm: 'Running all benchmarks\might take a few seconds.' withCRs translated
+ title: 'Continue?' translated)
+ ifFalse: [
+ categoriesSelected remove: #'Tiny Benchmarks'.
+ ^ self changed: #categorySelected ].
+ Cursor wait showWhile: [tinyBenchmarksResult := 0 tinyBenchmarks]].
- UIManager inform: 'Running the Benchmarks\will take a few seconds' withCRs.
- tinyBenchmarksResult := 0 tinyBenchmarks].
  self header: 'Tiny Benchmarks' on: aStream.
  aStream nextPutAll: tinyBenchmarksResult; cr!

As for the current feature freeze: I got several complaints about triggering those tings in the system reporter by accident. So I regarded those things as kind of urgent. Please forgive my hasty response resp. commit. ;-)

Best,
Marcel