The Trunk: Tests-eem.390.mcz

Eliot Miranda uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-eem.390.mcz

==================== Summary ====================

Name: Tests-eem.390
Author: eem
Time: 24 December 2017, 11:22:43.968478 am
UUID: 743db14f-6dfb-4631-a4a0-688c8dfb700f
Ancestors: Tests-eem.389

Update DecompilerTests now that the nil mistakenly generated following a retrning if with a nil else is removed.


A note to Compiler/Decompiler maintainers:
11 decompiler failures remain.  Most are due to the macro transformations being done incrementally rather than once the full tree is available.  If the transformations were deferred then, for example, whileTrue:=>to:do: conversion where the index is used after the loop could be prevented because the transformer could notice the use of the index beyond the loop body.

=============== Diff against Tests-eem.389 ===============

Item was changed:
  DecompilerTests subclass: #DecompilerTestFailuresCollector
  instanceVariableNames: 'failures'
  classVariableNames: ''
  poolDictionaries: ''
  category: 'Tests-Compiler'!
 
+ !DecompilerTestFailuresCollector commentStamp: 'eem 12/24/2017 11:06' prior: 0!
- !DecompilerTestFailuresCollector commentStamp: '<historical>' prior: 0!
  (| dtfc |
  dtfc := DecompilerTestFailuresCollector new.
  (dtfc class superclass organization listAtCategoryNamed: #tests) do:
  [:s| dtfc perform: s].
  dtfc failures)
 
  (Transcript nextPut: ${.
  self do: [:mr| Transcript print: mr actualClass; nextPut: $.; space; store: mr methodSymbol; nextPut: $.; cr; flush].
  Transcript nextPut: $}; flush)
 
+ eem 12/24/2017 11:05
+ #(#BrowserCommentTextMorph #showPane #SyntaxErrorNotification)
+ #(#CodeHolder #getSelectorAndSendQuery:to:with: #SyntaxErrorNotification)
+ #(#DecompilerTests #testDecompileUnreachableParameter #Error)
+ #(#MVCToolBuilder #setLayout:in: #SyntaxErrorNotification)
+ #(#PNGReadWriter #copyPixelsGray: #SyntaxErrorNotification)
+ #(#SHMCClassDefinition #withAllSuperclassesDo: #SyntaxErrorNotification)
+
  eem 7/1/2009 16:13
  {AdditionalMethodState. #keysAndValuesDo:.
  AdditionalMethodState. #propertyKeysAndValuesDo:.
  AdditionalMethodState. #at:ifAbsent:.
  AdditionalMethodState. #removeKey:ifAbsent:.
  AdditionalMethodState. #at:ifAbsentPut:.
  AdditionalMethodState. #setMethod:.
  AdditionalMethodState. #at:put:.
  AdditionalMethodState. #pragmas.
  AdditionalMethodState. #includesProperty:.
  AdditionalMethodState. #properties.
  AdditionalMethodState. #hasLiteralSuchThat:.
  AdditionalMethodState. #propertyValueAt:ifAbsent:.
  AdditionalMethodState. #hasLiteralThorough:.
  Array. #hasLiteralSuchThat:.
  BitBltSimulation. #initDither8Lookup.
  BlockNode. #sizeCodeExceptLast:.
  BlockNode. #emitCodeExceptLast:encoder:.
  Categorizer. #changeFromCategorySpecs:.
  Categorizer. #elementCategoryDict.
  CColorPicker. #colors:.
  CCustomDrawListCostume. #drawListOn:in:.
  ChangeList. #browseCurrentVersionsOfSelections.
  ClosureTests. #testToDoInsideTemp.
  Cogit. #computeMaximumSizes.
  Cogit. #outputInstructionsAt:.
  Cogit. #generateMapAt:start:.
  CogVMSimulator. #printFrameThing:at:.
  CogVMSimulator. #str:n:cmp:.
  CoInterpreter. #validStackPageBaseFrames.
  CoInterpreter. #markAndTraceTraceLog.
  CoInterpreter. #mapTraceLog.
  CoInterpreter. #checkStackIntegrity.
  CoInterpreter. #mapStackPages.
  CoInterpreter. #updateStackZoneReferencesToCompiledCodePreCompaction.
  CoInterpreter. #ceActivateFailingPrimitiveMethod:.
  CoInterpreterStackPages. #initializeStack:numSlots:pageSize:stackLimitOffset:stackPageHeadroom:.
  CompiledMethod. #=.
  CompiledMethod. #getPreambleFrom:at:.
  CompiledMethod. #hasLiteralThorough:.
  CompiledMethod. #hasLiteralSuchThat:.
  CPopUpMenuCostume. #drawMenu:on:in:.
  CroquetParticipant. #dropFiles:.
  CTextParagraph. #selectionRectsFrom:to:.
  CWheelWidgetCostume. #drawOn:in:.
  Dictionary. #scanFor:.
  Float. #printPaddedWith:to:.
  FMSound. #mixSampleCount:into:startingAt:leftVol:rightVol:.
  Form. #transformColors:.
  FTPClient. #getDataInto:.
  GIFReadWriter. #nextImageWithPlugin.
  GraphMorph. #drawDataOn:.
  GZipReadStream. #on:from:to:.
  HTTPServiceDispatcher. #errorReportFor:stack:on:.
  HttpUrl. #checkAuthorization:retry:.
  Integer. #benchSwitch:.
  Interpreter. #primitiveClosureValueWithArgs.
  Interpreter. #primitivePerformAt:.
  Interpreter. #primitiveDoPrimitiveWithArgs.
  Interpreter. #primitiveNewMethod.
  InterpreterStackPages. #initializeStack:numSlots:pageSize:stackLimitOffset:stackPageHeadroom:.
  JPEGReadWriter. #decodeBlockInto:component:dcTable:acTable:.
  KeyedIdentitySet. #scanFor:.
  KeyedSet. #scanFor:.
  LargeIntegersPlugin. #isNormalized:.
  LargeIntegersPlugin. #cBytesCopyFrom:to:len:.
  LargeIntegersPlugin. #cDigitMultiply:len:with:len:into:.
  LiteralDictionary. #scanFor:.
  LoopedSampledSound. #mixSampleCount:into:startingAt:leftVol:rightVol:.
  MethodDictionary. #scanFor:.
  MP4BoxInfoParser. #parseMP4BoxOutput:.
  MP4BoxNHMLTrack. #computeDTSDeltas.
  MultiByteBinaryOrTextStream. #next:.
  MultiByteFileStream. #next:.
  MViewPane. #reconstructEnabledDocuments.
  MViewPane. #reconstructOpenDocuments.
  MViewPane. #reconstructSelectionList.
  NewParagraph. #selectionRectsFrom:to:.
  Object. #instanceFields.
  OldSocket. #getResponseNoLF.
  PasteUpMorph. #dropFiles:.
  PlotMorphGrid. #bestStep:.
  PluckedSound. #reset.
  PluggableDictionary. #scanFor:.
  PluggableSet. #scanFor:.
  PluggableTabButtonMorph. #calculateArcLengths.
  PluggableTabButtonMorph. #drawTabOn:.
  PNGReadWriter. #copyPixelsGray:.
  PNMReadWriter. #readPlainRGB.
  PNMReadWriter. #readBWreverse:.
  PNMReadWriter. #nextPutRGB:.
  PNMReadWriter. #nextPutBW:reverse:.
  PopUpMenu. #readKeyboard.
  QFloorFan. #initialize.
  QMinimalForum. #demoDesksUnused.
  QNetVidReorderingBuffer. #popFramesForCTS:.
  QNetVidTrackStreamer. #sampleIndexWithCTS:.
  QServiceProvider. #statusReport.
  QServicesPane. #forumMenuInto:.
  QUserListItem. #drawOn:in:.
  QVMProfiler. #computeHistograms:.
  QVMProfiler. #selectSymbolsInRange.
  QwaqParticipantUI. #onDropFiles:.
  RelativeInstructionPrinter. #print:.
  RemoteHandMorph. #appendNewDataToReceiveBuffer.
  SchizophrenicClosureFormatStackInterpreter. #primitiveClosureValueWithArgs.
  Set. #do:.
  Set. #scanFor:.
  SHParserST80. #isBinary.
  ShootoutMall. #processVisitors.
  ShortIntegerArray. #writeOn:.
  SparseLargeArray. #analyzeSpaceSaving.
  StackInterpreter. #validStackPageBaseFrames.
  StackInterpreter. #divorceAllFrames.
  StackInterpreter. #checkStackIntegrity.
  StackInterpreter. #primitiveDoPrimitiveWithArgs.
  StackInterpreter. #reverseDisplayFrom:to:.
  StackInterpreter. #printOop:.
  StackInterpreter. #mapStackPages.
  StackInterpreter. #primitiveNewMethod.
  StackInterpreter. #primitiveClosureValueWithArgs.
  StrikeFontSet. #displayStringR2L:on:from:to:at:kern:.
  String. #howManyMatch:.
  Text. #asHtmlFragmentTextStyle:useBreaks:.
  TextURL. #actOnClickFor:.
  TFractalTerrain. #heightAt:.
  TFractalTerrain. #makeFaces.
  TFractalTerrain. #makeVertices.
  TFractalTerrain. #makeTextureUV.
  TFractalTerrain. #makeVertexNormals.
  TFrame. #computeUnionSphere.
  TMethod. #emitCCommentOn:.
  TRFBStreamOutput. #handleRequest:.
  TTCFontReader. #processCharacterMappingTable:.
  TTContourConstruction. #segmentsDo:.
  TTensor. #projectionIntegrate:.
  TTFontReader. #processHorizontalMetricsTable:length:.
  TTFontReader. #processCharacterMappingTable:.
  TWaves. #step.
  Vector. #copyFrom:.
  Vector. #asVector3.
  VectorColor. #copyFrom:.
  WeakKeyDictionary. #scanForNil:.
  WeakKeyDictionary. #scanFor:.
  WeakSet. #scanFor:.
  WeakSet. #scanForLoadedSymbol:.
  }!

Item was changed:
  ----- Method: DecompilerTests>>decompilerFailures (in category 'utilities') -----
  decompilerFailures
  "Here is the list of failures: either a syntax error, a hard error or some failure to decompile correctly.
  Collected via
  DecompilerTestFailuresCollector new computeFailures."
 
  "class name, selector, error class name or nil"
  ^  #(
- #(Behavior toolIconSelector: TestFailure)
  #(BrowserCommentTextMorph showPane SyntaxErrorNotification)
  #(CodeHolder getSelectorAndSendQuery:to:with: SyntaxErrorNotification)
  #(DecompilerTests testDecompileUnreachableParameter Error)
- #(HttpUrl checkAuthorization:retry: TestFailure)
- #(MCConfigurationBrowser post SyntaxErrorNotification)
  #(MVCToolBuilder setLayout:in: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
- #(ParseNodeBuilder variable: TestFailure) "Almost fully returning if's result in a nil node."
  #(PNGReadWriter copyPixelsGray: SyntaxErrorNotification)
  #(ProtoObjectTest testIfNilIfNotNil SyntaxErrorNotification)
  #(ProtoObjectTest testIfNotNil SyntaxErrorNotification)
  #(ProtoObjectTest testIfNotNilIfNil SyntaxErrorNotification)
  #(SHMCClassDefinition withAllSuperclassesDo: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
- #(TextURL actOnClickFor: TestFailure)
  #(TTContourConstruction segmentsDo: SyntaxErrorNotification) "Worth fixing; these two are mistaken conversion from a whileTrue: to a to:do: but the index is used outside the whileTrue:"
+ #(TTFontReader processHorizontalMetricsTable:length: SyntaxErrorNotification))
+
+ !
- #(TTFontReader processHorizontalMetricsTable:length: SyntaxErrorNotification))!