The Trunk: Tests-fbs.192.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tests-fbs.192.mcz

commits-2
Frank Shearar uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-fbs.192.mcz

==================== Summary ====================

Name: Tests-fbs.192
Author: fbs
Time: 12 March 2013, 10:11:20.038 pm
UUID: d8f08adf-5340-44a4-b7c6-3c4e70e36c28
Ancestors: Tests-cwp.191

* The new Etoys classes brought new dependencies on Compression and ReleaseBuilder.
* My pulling out of the SmallLand colour schemes is now manifest in System's dependencies (induced via Preferences class >> #smallLand.

=============== Diff against Tests-cwp.191 ===============

Item was changed:
  ----- Method: PackageDependencyTest>>testEtoys (in category 'tests') -----
  testEtoys
  self testPackage: 'EToys' dependsExactlyOn: #(
  Balloon
  Collections
  Compiler
+ Compression
  Exceptions
  Files
  Graphics
  Kernel
  Morphic
  MorphicExtras
  Network
  Protocols
+ ReleaseBuilder
+ SUnit
  System
  'ToolBuilder-Kernel'
  Tools
- SUnit
  ).!

Item was changed:
  ----- Method: PackageDependencyTest>>testSystem (in category 'tests') -----
  testSystem
  self testPackage: 'System' dependsExactlyOn: #(
  Collections
  Compiler
  Compression
  Environments
  Exceptions
  Files
  GetText
  Graphics
  Kernel
  Monticello
  MonticelloConfigurations
  Morphic
  MorphicExtras
  Multilingual
  Network
  'PackageInfo-Base'
  Protocols
  Sound
+ 'SmallLand-ColorTheme'
  'ToolBuilder-Kernel'
  Tools
  TrueType
  ).!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-fbs.192.mcz

Bert Freudenberg
On 2013-03-12, at 22:11, [hidden email] wrote:

> Name: Tests-fbs.192
> Author: fbs
> Time: 12 March 2013, 10:11:20.038 pm
> UUID: d8f08adf-5340-44a4-b7c6-3c4e70e36c28
> Ancestors: Tests-cwp.191
>
> * The new Etoys classes brought new dependencies on Compression and ReleaseBuilder.


Hmm. I thought adding a "*etoys" category to ReleaseBuilderSqueakland might be convenient, because then I wouldn't have to touch the ReleaseBuilder package directly. If you think that's not a good idea, please let me know.

Similar for the project loading stuff. Do we consider this to be Etoys-specific?

- Bert -



Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-fbs.192.mcz

Frank Shearar-3
On 12 March 2013 22:22, Bert Freudenberg <[hidden email]> wrote:

> On 2013-03-12, at 22:11, [hidden email] wrote:
>
>> Name: Tests-fbs.192
>> Author: fbs
>> Time: 12 March 2013, 10:11:20.038 pm
>> UUID: d8f08adf-5340-44a4-b7c6-3c4e70e36c28
>> Ancestors: Tests-cwp.191
>>
>> * The new Etoys classes brought new dependencies on Compression and ReleaseBuilder.
>
>
> Hmm. I thought adding a "*etoys" category to ReleaseBuilderSqueakland might be convenient, because then I wouldn't have to touch the ReleaseBuilder package directly. If you think that's not a good idea, please let me know.

I don't think these are bad dependencies: I consider Etoys to be
"application level" for want of a better term. Things depending on
Etoys I'd consider a problem.

Maybe ReleaseBuilderSqueakland should move to a new package,
SmallLand-ReleaseBuilder? There are a few other Squeakland things,
like Preferences class >> #smallLandBigFonts and friends. Those could
go in a new package called SmallLand-Preferences.

frank

> Similar for the project loading stuff. Do we consider this to be Etoys-specific?
>
> - Bert -
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-fbs.192.mcz

Bert Freudenberg

On 2013-03-13, at 00:08, Frank Shearar <[hidden email]> wrote:

> On 12 March 2013 22:22, Bert Freudenberg <[hidden email]> wrote:
>> On 2013-03-12, at 22:11, [hidden email] wrote:
>>
>>> Name: Tests-fbs.192
>>> Author: fbs
>>> Time: 12 March 2013, 10:11:20.038 pm
>>> UUID: d8f08adf-5340-44a4-b7c6-3c4e70e36c28
>>> Ancestors: Tests-cwp.191
>>>
>>> * The new Etoys classes brought new dependencies on Compression and ReleaseBuilder.
>>
>>
>> Hmm. I thought adding a "*etoys" category to ReleaseBuilderSqueakland might be convenient, because then I wouldn't have to touch the ReleaseBuilder package directly. If you think that's not a good idea, please let me know.
>
> I don't think these are bad dependencies: I consider Etoys to be
> "application level" for want of a better term. Things depending on
> Etoys I'd consider a problem.

Okay.

> Maybe ReleaseBuilderSqueakland should move to a new package,
> SmallLand-ReleaseBuilder? There are a few other Squeakland things,
> like Preferences class >> #smallLandBigFonts and friends. Those could
> go in a new package called SmallLand-Preferences.


Squeakland ~= SmallLand.

None of the SmallLand stuff is in the Etoys image.

I though about making ReleaseBuilderEtoys, but then it felt awkward not to have the various release builders next to each other. OTOH, we should weed out the unused builders anyway.

- Bert -


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-fbs.192.mcz

Frank Shearar-3
On 13 March 2013 00:14, Bert Freudenberg <[hidden email]> wrote:

>
> On 2013-03-13, at 00:08, Frank Shearar <[hidden email]> wrote:
>
>> On 12 March 2013 22:22, Bert Freudenberg <[hidden email]> wrote:
>>> On 2013-03-12, at 22:11, [hidden email] wrote:
>>>
>>>> Name: Tests-fbs.192
>>>> Author: fbs
>>>> Time: 12 March 2013, 10:11:20.038 pm
>>>> UUID: d8f08adf-5340-44a4-b7c6-3c4e70e36c28
>>>> Ancestors: Tests-cwp.191
>>>>
>>>> * The new Etoys classes brought new dependencies on Compression and ReleaseBuilder.
>>>
>>>
>>> Hmm. I thought adding a "*etoys" category to ReleaseBuilderSqueakland might be convenient, because then I wouldn't have to touch the ReleaseBuilder package directly. If you think that's not a good idea, please let me know.
>>
>> I don't think these are bad dependencies: I consider Etoys to be
>> "application level" for want of a better term. Things depending on
>> Etoys I'd consider a problem.
>
> Okay.
>
>> Maybe ReleaseBuilderSqueakland should move to a new package,
>> SmallLand-ReleaseBuilder? There are a few other Squeakland things,
>> like Preferences class >> #smallLandBigFonts and friends. Those could
>> go in a new package called SmallLand-Preferences.
>
>
> Squeakland ~= SmallLand.

OK. So there are a few other SmallLand things like Preferences class
>> #smallLandBigFonts that could go into a new package called
SmallLand-Preferences :)

> None of the SmallLand stuff is in the Etoys image.

So Etoys have already ripped out the SmallLand stuff? OK, that means
they're prime candidates for de-trunking (as per our previously
discussed approach for a stripped core that has stuff loaded in by
CI).

frank

> I though about making ReleaseBuilderEtoys, but then it felt awkward not to have the various release builders next to each other. OTOH, we should weed out the unused builders anyway.
>
> - Bert -

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-fbs.192.mcz

Karl Ramberg
Couldnt much of this SmallLand stuff go under a Themes package ?
One could have different themes for the style of font and colors ?
 
Karl


 
On Wed, Mar 13, 2013 at 12:30 PM, Frank Shearar <[hidden email]> wrote:
On 13 March 2013 00:14, Bert Freudenberg <[hidden email]> wrote:
>
> On 2013-03-13, at 00:08, Frank Shearar <[hidden email]> wrote:
>
>> On 12 March 2013 22:22, Bert Freudenberg <[hidden email]> wrote:
>>> On 2013-03-12, at 22:11, [hidden email] wrote:
>>>
>>>> Name: Tests-fbs.192
>>>> Author: fbs
>>>> Time: 12 March 2013, 10:11:20.038 pm
>>>> UUID: d8f08adf-5340-44a4-b7c6-3c4e70e36c28
>>>> Ancestors: Tests-cwp.191
>>>>
>>>> * The new Etoys classes brought new dependencies on Compression and ReleaseBuilder.
>>>
>>>
>>> Hmm. I thought adding a "*etoys" category to ReleaseBuilderSqueakland might be convenient, because then I wouldn't have to touch the ReleaseBuilder package directly. If you think that's not a good idea, please let me know.
>>
>> I don't think these are bad dependencies: I consider Etoys to be
>> "application level" for want of a better term. Things depending on
>> Etoys I'd consider a problem.
>
> Okay.
>
>> Maybe ReleaseBuilderSqueakland should move to a new package,
>> SmallLand-ReleaseBuilder? There are a few other Squeakland things,
>> like Preferences class >> #smallLandBigFonts and friends. Those could
>> go in a new package called SmallLand-Preferences.
>
>
> Squeakland ~= SmallLand.

OK. So there are a few other SmallLand things like Preferences class
>> #smallLandBigFonts that could go into a new package called
SmallLand-Preferences :)

> None of the SmallLand stuff is in the Etoys image.

So Etoys have already ripped out the SmallLand stuff? OK, that means
they're prime candidates for de-trunking (as per our previously
discussed approach for a stripped core that has stuff loaded in by
CI).

frank

> I though about making ReleaseBuilderEtoys, but then it felt awkward not to have the various release builders next to each other. OTOH, we should weed out the unused builders anyway.
>
> - Bert -




Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-fbs.192.mcz

Bert Freudenberg
In reply to this post by Frank Shearar-3
On 2013-03-13, at 12:30, Frank Shearar <[hidden email]> wrote:

> On 13 March 2013 00:14, Bert Freudenberg <[hidden email]> wrote:
>
>> None of the SmallLand stuff is in the Etoys image.
>
> So Etoys have already ripped out the SmallLand stuff?

No. SmallLand contributions got in for Squeak 3.9 IIRC, the last major sync between Etoys and Trunk was in 3.8.

> OK, that means
> they're prime candidates for de-trunking (as per our previously
> discussed approach for a stripped core that has stuff loaded in by
> CI).
>
> frank


On 2013-03-13, at 13:13, karl ramberg <[hidden email]> wrote:

> Couldnt much of this SmallLand stuff go under a Themes package ?
> One could have different themes for the style of font and colors ?
>  
> Karl

That sounds better than making a SmallLand package.

- Bert -