Smalltalk › Squeak › Squeak - Dev

The Trunk: Tests-fbs.224.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

commits-2

The Trunk: Tests-fbs.224.mcz

Frank Shearar uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-fbs.224.mcz

==================== Summary ====================

Name: Tests-fbs.224
Author: fbs
Time: 26 June 2013, 12:40:25.578 pm
UUID: 3e0351c4-903b-4f74-9d53-2eae254fe5bb
Ancestors: Tests-fbs.223

Remove the test for http://bugs.squeak.org/view.php?id=7771. You can't make it an expected failure because it breaks testDecompilerInClassesDAtoDM.

The workaround of making testDecompilerInClassesDAtoDM clever enough to avoid this marker test just isn't worth it. It's recorded in the bugtracker anyway.

=============== Diff against Tests-fbs.223 ===============

Item was removed:
- ----- Method: DecompilerTests>>expectedFailures (in category 'testing') -----
- expectedFailures
- ^ #(testDecompileUnreachableParameter)!

Item was removed:
- ----- Method: DecompilerTests>>testDecompileUnreachableParameter (in category 'tests') -----
- testDecompileUnreachableParameter
- "DecompilerTests new testDecompileUnreachableParameter"
- "The call to #value: is unreachable because both blocks in the #ifTrue:ifFalse: send force a return."
- self shouldnt: [[self value: (true ifTrue: [^true] ifFalse: [^false])] decompile] raise: Error.!

Levente Uzonyi-2

Re: The Trunk: Tests-fbs.224.mcz

On Wed, 26 Jun 2013, [hidden email] wrote:

> Frank Shearar uploaded a new version of Tests to project The Trunk:
> http://source.squeak.org/trunk/Tests-fbs.224.mcz
>
> ==================== Summary ====================
>
> Name: Tests-fbs.224
> Author: fbs
> Time: 26 June 2013, 12:40:25.578 pm
> UUID: 3e0351c4-903b-4f74-9d53-2eae254fe5bb
> Ancestors: Tests-fbs.223
>
> Remove the test for http://bugs.squeak.org/view.php?id=7771. You can't make it an expected failure because it breaks testDecompilerInClassesDAtoDM.
>
> The workaround of making testDecompilerInClassesDAtoDM clever enough to avoid this marker test just isn't worth it. It's recorded in the bugtracker anyway.

There's already a workaround for that. Just add an entry to
DecompilerTests >> #decompilerFailures.

Levente

>
> =============== Diff against Tests-fbs.223 ===============
>
> Item was removed:
> - ----- Method: DecompilerTests>>expectedFailures (in category 'testing') -----
> - expectedFailures
> - ^ #(testDecompileUnreachableParameter)!
>
> Item was removed:
> - ----- Method: DecompilerTests>>testDecompileUnreachableParameter (in category 'tests') -----
> - testDecompileUnreachableParameter
> - "DecompilerTests new testDecompileUnreachableParameter"
> - "The call to #value: is unreachable because both blocks in the #ifTrue:ifFalse: send force a return."
> - self shouldnt: [[self value: (true ifTrue: [^true] ifFalse: [^false])] decompile] raise: Error.!
>
>
>

Frank Shearar-3

Re: The Trunk: Tests-fbs.224.mcz

On 27 June 2013 17:16, Levente Uzonyi <[hidden email]> wrote:

> On Wed, 26 Jun 2013, [hidden email] wrote:
>
>> Frank Shearar uploaded a new version of Tests to project The Trunk:
>> http://source.squeak.org/trunk/Tests-fbs.224.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tests-fbs.224
>> Author: fbs
>> Time: 26 June 2013, 12:40:25.578 pm
>> UUID: 3e0351c4-903b-4f74-9d53-2eae254fe5bb
>> Ancestors: Tests-fbs.223
>>
>> Remove the test for http://bugs.squeak.org/view.php?id=7771. You can't
>> make it an expected failure because it breaks testDecompilerInClassesDAtoDM.
>>
>> The workaround of making testDecompilerInClassesDAtoDM clever enough to
>> avoid this marker test just isn't worth it. It's recorded in the bugtracker
>> anyway.
>
>
> There's already a workaround for that. Just add an entry to DecompilerTests
>>> #decompilerFailures.

Ah! I'll take a look at that!

frank