The Trunk: Tests-mt.415.mcz

Marcel Taeumel uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-mt.415.mcz

==================== Summary ====================

Name: Tests-mt.415
Author: mt
Time: 4 September 2019, 4:57:55.602738 pm
UUID: 9676f86d-11c2-4977-85ad-44c5808ad780
Ancestors: Tests-mt.414

Fixes some compiler tests and cleans up decompiler-tests baseline.

I will put a fix for the Decompiler into the inbox right away. :-)

=============== Diff against Tests-mt.414 ===============

Item was changed:
  ----- Method: CompilerNotifyingTest>>setUpForErrorsIn: (in category 'initialize-release') -----
  setUpForErrorsIn: aTextWithErrorsEnclosedInBackQuote
  "Extract the expectedErrors, the expectedErrorPositions and set up a TextMorph containing the text without errors.
  each section separated by % in aTextWithErrorsEnclosedInBackQuote will be evaluated separately.
  The expected error message should lie in aTextWithErrorsEnclosedInBackQuote at the expected position, and enclosed in back quotes."
  text := aTextWithErrorsEnclosedInBackQuote.
+
+ "Enclose error messages in double quotes to support syntax highlighting."
+ text := text copyReplaceAll: '` ' with: '` "'.
+ text := text copyReplaceAll: '>`' with: '>"`'.
+
  morph := TextMorph new contents: self initializeTextWithoutError asText.!

Item was changed:
  ----- Method: CompilerNotifyingTest>>testMissingExpression (in category 'tests') -----
  testMissingExpression
+ self setUpForErrorsIn: '| x | x := ` Expression expected ->`'.
- self setUpForErrorsIn: '| x | x := ` Expression expected ->'.
  self enumerateAllSelections!

Item was added:
+ ----- Method: DecompilerTestFailuresCollector class>>isAbstract (in category 'as yet unclassified') -----
+ isAbstract
+
+ ^ true!

Item was changed:
  ----- Method: DecompilerTests>>basePackagePrefixes (in category 'utilities') -----
  basePackagePrefixes
+
+ ^ #(
+ 'Kernel' "includes KernelTests"
+ 'Collections' "includes CollectionsTests"
+ 'Chronology'
+ 'Compiler'
+ 'Environments'
+ 'Traits'
+ 'PackageInfo'
+
+ 'Graphics' "includes GraphicsTests"
+ 'Balloon' "includes BalloonTests"
+ 'TrueType'
+
+ 'Sound'
+
+ 'Network' "includes NetworkTests"
+ 'WebClient'
+ 'SqueakSSL'
+ 'XML'
+
- ^#("'Balloon'" "AbstractAnimation>>prologue: in Balloon3D-Wonderland-Time breaks the test"
- 'Chronology' 'Collections' 'CommandLine' 'Compiler' 'Compression'
- 'Environments' 'Exceptions'
  'Files'
+ 'Compression'
- 'GetText' 'Graphics' 'Help-' 'HelpSystem-'
- 'Installer-Core'
- 'Kernel-' 'KernelTests-'
- 'Monticello'
- 'Morphic-' 'MorphicExtras-' 'MorphicExtrasTests-' 'MorphicTests-'
- 'Multilingual' 'MultilingualTests'
- 'Nebraska' 'Network' 'NetworkTests'
- 'PackageInfo-Base' 'PreferenceBrowser' 'Protocols'
  'Regex'
+ 'System'
+
+ 'ST80' "includes ST80Tests"
+ 'Morphic' "includes MorphicTests and MorphicExtras"
+ 'Etoys'
+
+ 'Installer'
+ 'Monticello'
+ 'VersionNumber'
+ 'UpdateStream'
+ 'SMBase'
+ 'SMLoader'
+ 'Squeak-Version'
+
+ 'GetText'
+ 'Multilingual' "includes MultilingualTests"
+ 'Help' "includes HelpSystem"
+
+ 'ToolBuilder'
+ 'Tools'
+ 'CommandLine'
+ 'Nebraska'
+ 'PreferenceBrowser'
+ 'Protocols'
+ 'SUnit'
+ 'ScriptLoader'
+ 'Services'
+ 'Shout'
+  
+ 'Tests'
  'ReleaseBuilder'
+ )!
- 'SMBase' 'SMLoader' 'ST80' 'ST80Tests' 'ST80Tools' 'SUnit' 'ScriptLoader' 'Services-Base' 'Shout'
- 'Sound' 'Squeak-Version' 'SqueakSSL' 'System'
- 'Tests' 'ToolBuilder' 'Tools' 'Traits' 'TrueType'
- 'Universes' 'UpdateStream' 'VersionNumber'
- 'WebClient-'
- 'XML-')!

Item was changed:
  ----- Method: DecompilerTests>>decompilerFailures (in category 'utilities') -----
  decompilerFailures
  "Here is the list of failures: either a syntax error, a hard error or some failure to decompile correctly.
  Collected initially via
  DecompilerTestFailuresCollector new computeFailures.
  But can be maintained manually."
 
  "class name, selector, error class name or nil"
  ^#(
  #(BrowserCommentTextMorph showPane SyntaxErrorNotification)
  #(CodeHolder getSelectorAndSendQuery:to:with: SyntaxErrorNotification)
  #(DecompilerTests testDecompileUnreachableParameter Error)
  #(MVCToolBuilder setLayout:in: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
- #(Pen web AssertionFailure) "needs a recompile to compute remote temps correctly (repeat now inlined)"
  #(PNGReadWriter copyPixelsGray: SyntaxErrorNotification)
- #(Random roll: AssertionFailure) "needs a recompile to compute remote temps correctly (repeat now inlined)"
  #(SHMCClassDefinition withAllSuperclassesDo: SyntaxErrorNotification)), "same-name block-local temps in optimized blocks"
  (Scanner allowBlockArgumentAssignment
  ifTrue: [#()]
  ifFalse:
  [#(
  #(NebraskaSenderMorph hideField: SyntaxErrorNotification)) "assigns into block argument"])!