Smalltalk › Squeak › Squeak - Dev

The Trunk: Tests-nice.459.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

commits-2

The Trunk: Tests-nice.459.mcz

Nicolas Cellier uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-nice.459.mcz

==================== Summary ====================

Name: Tests-nice.459
Author: nice
Time: 29 April 2021, 10:30:03.551961 pm
UUID: 67799656-9640-e447-b665-6f74573e3716
Ancestors: Tests-nice.458

For some reason, ImageSegmentTest>>testContextsShouldBeWritableToaFile interact badly with progress bar, resulting in a context that cannotReturn:
Workaround by temporarily suppressing progress.

=============== Diff against Tests-nice.458 ===============

Item was changed:
----- Method: ImageSegmentTest>>testContextsShouldBeWritableToaFile (in category 'tests') -----
testContextsShouldBeWritableToaFile
"This should not throw an exception"
+ [NativeImageSegment new
- NativeImageSegment new
copyFromRoots: {thisContext. thisContext copyStack} sizeHint: 100;
extract;
writeToFile: 'ContextChain';
+ yourself] on: ProgressInitiationException do: [:e | e resumeSuppressingProgress]
- yourself

"TODO: write assertions showing that something meaningful actually happened."

"TODO: bring them back in again"!

Nicolas Cellier

Re: The Trunk: Tests-nice.459.mcz

>
> Nicolas Cellier uploaded a new version of Tests to project The Trunk:
> http://source.squeak.org/trunk/Tests-nice.459.mcz
>
> ==================== Summary ====================
>
> Name: Tests-nice.459
> Author: nice
> Time: 29 April 2021, 10:30:03.551961 pm
> UUID: 67799656-9640-e447-b665-6f74573e3716
> Ancestors: Tests-nice.458
>
> For some reason, ImageSegmentTest>>testContextsShouldBeWritableToaFile interact badly with progress bar, resulting in a context that cannotReturn:
> Workaround by temporarily suppressing progress.
>
> =============== Diff against Tests-nice.458 ===============
>
> Item was changed:
> ----- Method: ImageSegmentTest>>testContextsShouldBeWritableToaFile (in category 'tests') -----
> testContextsShouldBeWritableToaFile
> "This should not throw an exception"
> + [NativeImageSegment new
> - NativeImageSegment new
> copyFromRoots: {thisContext. thisContext copyStack} sizeHint: 100;
> extract;
> writeToFile: 'ContextChain';
> + yourself] on: ProgressInitiationException do: [:e | e resumeSuppressingProgress]
> - yourself
>
> "TODO: write assertions showing that something meaningful actually happened."
>
> "TODO: bring them back in again"!
>
>

Christoph Thiede

Re: The Trunk: Tests-nice.459.mcz

(General note: I think we should use #flag: for code like this. This seems to be the most likely chance to me that any further volunteer will find and resolve the defect if we forget it. :-))

Von: Squeak-dev <[hidden email]> im Auftrag von Nicolas Cellier <[hidden email]>
Gesendet: Donnerstag, 29. April 2021 22:53:49
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] The Trunk: Tests-nice.459.mcz

Hmm no, this does not solve anything.
It happened to work once or twice, but no more...
It's impossible to debug, some doesNotUnderstand: occurs that install
and set state to #inactive, but debugger interacts and is causing more
doesNotUnderstand:

Le jeu. 29 avr. 2021 à 22:30, <[hidden email]> a écrit :
>
> Nicolas Cellier uploaded a new version of Tests to project The Trunk:
> http://source.squeak.org/trunk/Tests-nice.459.mcz
>
> ==================== Summary ====================
>
> Name: Tests-nice.459
> Author: nice
> Time: 29 April 2021, 10:30:03.551961 pm
> UUID: 67799656-9640-e447-b665-6f74573e3716
> Ancestors: Tests-nice.458
>
> For some reason, ImageSegmentTest>>testContextsShouldBeWritableToaFile interact badly with progress bar, resulting in a context that cannotReturn:
> Workaround by temporarily suppressing progress.
>
> =============== Diff against Tests-nice.458 ===============
>
> Item was changed:
>   ----- Method: ImageSegmentTest>>testContextsShouldBeWritableToaFile (in category 'tests') -----
>   testContextsShouldBeWritableToaFile
>         "This should not throw an exception"
> +       [NativeImageSegment new
> -       NativeImageSegment new
>                 copyFromRoots: {thisContext. thisContext copyStack} sizeHint: 100;
>                 extract;
>                 writeToFile: 'ContextChain';
> +               yourself] on: ProgressInitiationException do: [:e | e resumeSuppressingProgress]
> -               yourself
>
>         "TODO: write assertions showing that something meaningful actually happened."
>
>         "TODO: bring them back in again"!
>
>

Carpe Squeak!