The Trunk: Tests-topa.302.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tests-topa.302.mcz

commits-2
Tobias Pape uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-topa.302.mcz

==================== Summary ====================

Name: Tests-topa.302
Author: topa
Time: 5 September 2014, 9:07:38.083 pm
UUID: 34ca6d97-e886-4970-a84e-84b544ce5526
Ancestors: Tests-fbs.301

Adapt tests to Monticelo-topa.599

=============== Diff against Tests-fbs.301 ===============

Item was changed:
  ----- Method: MCWorkingCopyTest>>assertNameWhenSavingTo:is: (in category 'asserting') -----
  assertNameWhenSavingTo: aRepository is: aString
  | name |
  name := nil.
  [aRepository storeVersion: workingCopy newVersion]
  on: MCVersionNameAndMessageRequest
+ do: [:n |
+ n patchBlock value.
+ name := n suggestedName. n resume: (Array with: name with: '' with: Set new)].
- do: [:n | name := n suggestedName. n resume: (Array with: name with: '')].
  self assert: name = aString!

Item was changed:
  ----- Method: MCWorkingCopyTest>>assertNumberWhenSavingTo:is: (in category 'asserting') -----
  assertNumberWhenSavingTo: aRepository is: aNumber
  | name |
  name := nil.
  [aRepository storeVersion: workingCopy newVersion]
  on: MCVersionNameAndMessageRequest
+ do: [:n |
+ n patchBlock value.
+ name := n suggestedName. n resume: (Array with: name with: '' with: Set new)].
- do: [:n | name := n suggestedName. n resume: (Array with: name with: '')].
  self assert: name = (self packageName, '-', Utilities authorInitials, '.', aNumber asString)!

Item was changed:
  ----- Method: MCWorkingCopyTest>>snapshot (in category 'actions') -----
  snapshot
  | version |
  [version := workingCopy newVersion]
  on: MCVersionNameAndMessageRequest
+ do: [:n |
+ n patchBlock value.
+ n resume: (Array with: n suggestedName with: '' with: Set new)].
- do: [:n | n resume: (Array with: n suggestedName with: '')].
  versions at: version info put: version.
  ^ version!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-topa.302.mcz

Frank Shearar-3
On 5 September 2014 20:07,  <[hidden email]> wrote:

> Tobias Pape uploaded a new version of Tests to project The Trunk:
> http://source.squeak.org/trunk/Tests-topa.302.mcz
>
> ==================== Summary ====================
>
> Name: Tests-topa.302
> Author: topa
> Time: 5 September 2014, 9:07:38.083 pm
> UUID: 34ca6d97-e886-4970-a84e-84b544ce5526
> Ancestors: Tests-fbs.301
>
> Adapt tests to Monticelo-topa.599
>
> =============== Diff against Tests-fbs.301 ===============

Dang, here I am late to the party!

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-topa.302.mcz

Tobias Pape

On 05.09.2014, at 22:04, Frank Shearar <[hidden email]> wrote:

> On 5 September 2014 20:07,  <[hidden email]> wrote:
>> Tobias Pape uploaded a new version of Tests to project The Trunk:
>> http://source.squeak.org/trunk/Tests-topa.302.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tests-topa.302
>> Author: topa
>> Time: 5 September 2014, 9:07:38.083 pm
>> UUID: 34ca6d97-e886-4970-a84e-84b544ce5526
>> Ancestors: Tests-fbs.301
>>
>> Adapt tests to Monticelo-topa.599
>>
>> =============== Diff against Tests-fbs.301 ===============
>
> Dang, here I am late to the party!
Considering https://github.com/dalehenrich/metacello-work/issues/262#issuecomment-54672329

I think I need to robustify .599 :D

I just downloaded the CI image and ran the tests,
And for the envrionment load test I get this Prompt:

        The pool dictionary MCMockAPoolDictionary does not exist. Do you want it automatically created?

Can someone enlighten me?

Best
        -Tobias



signature.asc (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-topa.302.mcz

Nicolas Cellier


2014-09-05 22:20 GMT+02:00 Tobias Pape <[hidden email]>:

On 05.09.2014, at 22:04, Frank Shearar <[hidden email]> wrote:

> On 5 September 2014 20:07,  <[hidden email]> wrote:
>> Tobias Pape uploaded a new version of Tests to project The Trunk:
>> http://source.squeak.org/trunk/Tests-topa.302.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tests-topa.302
>> Author: topa
>> Time: 5 September 2014, 9:07:38.083 pm
>> UUID: 34ca6d97-e886-4970-a84e-84b544ce5526
>> Ancestors: Tests-fbs.301
>>
>> Adapt tests to Monticelo-topa.599
>>
>> =============== Diff against Tests-fbs.301 ===============
>
> Dang, here I am late to the party!

Considering https://github.com/dalehenrich/metacello-work/issues/262#issuecomment-54672329

I think I need to robustify .599 :D

I just downloaded the CI image and ran the tests,
And for the envrionment load test I get this Prompt:

        The pool dictionary MCMockAPoolDictionary does not exist. Do you want it automatically created?

Can someone enlighten me?

Best
        -Tobias


This is due to introduction of Namespace.
I have sent questions publicly about it in this mailing list... Then gave up, it is unanswered since May!

http://lists.squeakfoundation.org/pipermail/squeak-dev/2014-May/178411.html

Nicolas




Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-topa.302.mcz

Nicolas Cellier


2014-09-08 8:31 GMT+02:00 Nicolas Cellier <[hidden email]>:


2014-09-05 22:20 GMT+02:00 Tobias Pape <[hidden email]>:

On 05.09.2014, at 22:04, Frank Shearar <[hidden email]> wrote:

> On 5 September 2014 20:07,  <[hidden email]> wrote:
>> Tobias Pape uploaded a new version of Tests to project The Trunk:
>> http://source.squeak.org/trunk/Tests-topa.302.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tests-topa.302
>> Author: topa
>> Time: 5 September 2014, 9:07:38.083 pm
>> UUID: 34ca6d97-e886-4970-a84e-84b544ce5526
>> Ancestors: Tests-fbs.301
>>
>> Adapt tests to Monticelo-topa.599
>>
>> =============== Diff against Tests-fbs.301 ===============
>
> Dang, here I am late to the party!

Considering https://github.com/dalehenrich/metacello-work/issues/262#issuecomment-54672329

I think I need to robustify .599 :D

I just downloaded the CI image and ran the tests,
And for the envrionment load test I get this Prompt:

        The pool dictionary MCMockAPoolDictionary does not exist. Do you want it automatically created?

Can someone enlighten me?

Best
        -Tobias


This is due to introduction of Namespace.
I have sent questions publicly about it in this mailing list... Then gave up, it is unanswered since May!

http://lists.squeakfoundation.org/pipermail/squeak-dev/2014-May/178411.html

Nicolas

Does this subject really has a chilling effect?



Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-topa.302.mcz

Frank Shearar-3
On 11 September 2014 22:11, Nicolas Cellier
<[hidden email]> wrote:

>
>
> 2014-09-08 8:31 GMT+02:00 Nicolas Cellier
> <[hidden email]>:
>>
>>
>>
>> 2014-09-05 22:20 GMT+02:00 Tobias Pape <[hidden email]>:
>>>
>>>
>>> On 05.09.2014, at 22:04, Frank Shearar <[hidden email]> wrote:
>>>
>>> > On 5 September 2014 20:07,  <[hidden email]> wrote:
>>> >> Tobias Pape uploaded a new version of Tests to project The Trunk:
>>> >> http://source.squeak.org/trunk/Tests-topa.302.mcz
>>> >>
>>> >> ==================== Summary ====================
>>> >>
>>> >> Name: Tests-topa.302
>>> >> Author: topa
>>> >> Time: 5 September 2014, 9:07:38.083 pm
>>> >> UUID: 34ca6d97-e886-4970-a84e-84b544ce5526
>>> >> Ancestors: Tests-fbs.301
>>> >>
>>> >> Adapt tests to Monticelo-topa.599
>>> >>
>>> >> =============== Diff against Tests-fbs.301 ===============
>>> >
>>> > Dang, here I am late to the party!
>>>
>>> Considering
>>> https://github.com/dalehenrich/metacello-work/issues/262#issuecomment-54672329
>>>
>>> I think I need to robustify .599 :D
>>>
>>> I just downloaded the CI image and ran the tests,
>>> And for the envrionment load test I get this Prompt:
>>>
>>>         The pool dictionary MCMockAPoolDictionary does not exist. Do you
>>> want it automatically created?
>>>
>>> Can someone enlighten me?
>>>
>>> Best
>>>         -Tobias
>>>
>>>
>> This is due to introduction of Namespace.
>> I have sent questions publicly about it in this mailing list... Then gave
>> up, it is unanswered since May!
>>
>>
>> http://lists.squeakfoundation.org/pipermail/squeak-dev/2014-May/178411.html
>>
>> Nicolas
>>
> Does this subject really has a chilling effect?

I'm shivering in fear too badly to reply!

Um, having been embarrassed into taking a look - :) - I think using
#valueOf:ifAbsent: seems like the right thing to do. Precisely because
the use case looks an awful lot like that single sender in Parser >>
#externalFunctionDeclaration.

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-topa.302.mcz

Tobias Pape
In reply to this post by Nicolas Cellier
Hi,

On 11.09.2014, at 23:11, Nicolas Cellier <[hidden email]> wrote:

>
> Does this subject really has a chilling effect?

I just  have this email flagged so that I stumble over it in due time.
I hadn't had that time lately :(

Best
        -Tobias



signature.asc (1K) Download Attachment