The Trunk: Tests-topa.330.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tests-topa.330.mcz

commits-2
Tobias Pape uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-topa.330.mcz

==================== Summary ====================

Name: Tests-topa.330
Author: topa
Time: 1 September 2015, 2:42:05.272 pm
UUID: f8a88aaf-8f89-4359-b735-c97edb4b73b1
Ancestors: Tests-mt.329

Network rightfully depens on WebClient, now that it is our default HTTP(S) client.

=============== Diff against Tests-mt.329 ===============

Item was changed:
  ----- Method: PackageDependencyTest>>testNetwork (in category 'tests') -----
  testNetwork
  self testPackage: 'Network' dependsExactlyOn: #(
  Collections
  Compiler
  Compression
  Files
  Graphics
  Kernel
  Morphic
  System
  'ToolBuilder-Kernel'
+ 'WebClient-Core'
  ).!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-topa.330.mcz

Chris Muller-3
WebClient is an HTTP application, Network deals in low-level sockets.
Shouldn't WebClient depend on Network instead of vice-versa?

On Tue, Sep 1, 2015 at 7:42 AM,  <[hidden email]> wrote:

> Tobias Pape uploaded a new version of Tests to project The Trunk:
> http://source.squeak.org/trunk/Tests-topa.330.mcz
>
> ==================== Summary ====================
>
> Name: Tests-topa.330
> Author: topa
> Time: 1 September 2015, 2:42:05.272 pm
> UUID: f8a88aaf-8f89-4359-b735-c97edb4b73b1
> Ancestors: Tests-mt.329
>
> Network rightfully depens on WebClient, now that it is our default HTTP(S) client.
>
> =============== Diff against Tests-mt.329 ===============
>
> Item was changed:
>   ----- Method: PackageDependencyTest>>testNetwork (in category 'tests') -----
>   testNetwork
>         self testPackage: 'Network' dependsExactlyOn: #(
>                 Collections
>                 Compiler
>                 Compression
>                 Files
>                 Graphics
>                 Kernel
>                 Morphic
>                 System
>                 'ToolBuilder-Kernel'
> +               'WebClient-Core'
>         ).!
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-topa.330.mcz

Tobias Pape

On 01.09.2015, at 17:31, Chris Muller <[hidden email]> wrote:

> WebClient is an HTTP application, Network deals in low-level sockets.
> Shouldn't WebClient depend on Network instead of vice-versa?
>

Well, the “old” http client was directly in the networking package.
This dependency just happens to be because the override-methods from
WebClient-HTTP (that make WebClient the default HTTP client used by
Network) have been removed and WebClient is now hard-coded.

Best regards
        -Tobias

> On Tue, Sep 1, 2015 at 7:42 AM,  <[hidden email]> wrote:
>> Tobias Pape uploaded a new version of Tests to project The Trunk:
>> http://source.squeak.org/trunk/Tests-topa.330.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tests-topa.330
>> Author: topa
>> Time: 1 September 2015, 2:42:05.272 pm
>> UUID: f8a88aaf-8f89-4359-b735-c97edb4b73b1
>> Ancestors: Tests-mt.329
>>
>> Network rightfully depens on WebClient, now that it is our default HTTP(S) client.
>>
>> =============== Diff against Tests-mt.329 ===============
>>
>> Item was changed:
>>  ----- Method: PackageDependencyTest>>testNetwork (in category 'tests') -----
>>  testNetwork
>>        self testPackage: 'Network' dependsExactlyOn: #(
>>                Collections
>>                Compiler
>>                Compression
>>                Files
>>                Graphics
>>                Kernel
>>                Morphic
>>                System
>>                'ToolBuilder-Kernel'
>> +               'WebClient-Core'
>>        ).!