The Trunk: Tests-topa.333.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tests-topa.333.mcz

commits-2
Tobias Pape uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-topa.333.mcz

==================== Summary ====================

Name: Tests-topa.333
Author: topa
Time: 7 October 2015, 9:04:07.581 pm
UUID: 1224d066-f1f6-4e54-b2d8-235915d04ba4
Ancestors: Tests-topa.332

Expect MessageNotUnderstood for unknown prefs on Preferences, also, make the selector even more unlikely...

=============== Diff against Tests-topa.332 ===============

Item was changed:
  ----- Method: PreferencesTest>>test08DNUFallback (in category 'tests') -----
  test08DNUFallback
 
  sut setPreference: #foo toValue: 123.
  sut class removeSelectorSilently: #foo.
 
  self assert: (sut perform: #foo) = 123.
+ self should: [sut perform: #_unlikelyAndUnknownSelector] raise: MessageNotUnderstood.!
- self assert: (sut perform: #unknownSelector) isNil.!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-topa.333.mcz

Levente Uzonyi-2
On Wed, 7 Oct 2015, [hidden email] wrote:

> Tobias Pape uploaded a new version of Tests to project The Trunk:
> http://source.squeak.org/trunk/Tests-topa.333.mcz
>
> ==================== Summary ====================
>
> Name: Tests-topa.333
> Author: topa
> Time: 7 October 2015, 9:04:07.581 pm
> UUID: 1224d066-f1f6-4e54-b2d8-235915d04ba4
> Ancestors: Tests-topa.332
>
> Expect MessageNotUnderstood for unknown prefs on Preferences, also, make the selector even more unlikely...
>
> =============== Diff against Tests-topa.332 ===============
>
> Item was changed:
>  ----- Method: PreferencesTest>>test08DNUFallback (in category 'tests') -----
>  test08DNUFallback
>
>   sut setPreference: #foo toValue: 123.
>   sut class removeSelectorSilently: #foo.
>
>   self assert: (sut perform: #foo) = 123.
> + self should: [sut perform: #_unlikelyAndUnknownSelector] raise: MessageNotUnderstood.!

I think this symbol should be quoted, so that it can compile in images
where such selectors are not allowed.

Levente

> - self assert: (sut perform: #unknownSelector) isNil.!
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tests-topa.333.mcz

Tobias Pape

On 07.10.2015, at 23:27, Levente Uzonyi <[hidden email]> wrote:

> On Wed, 7 Oct 2015, [hidden email] wrote:
>
>> Tobias Pape uploaded a new version of Tests to project The Trunk:
>> http://source.squeak.org/trunk/Tests-topa.333.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tests-topa.333
>> Author: topa
>> Time: 7 October 2015, 9:04:07.581 pm
>> UUID: 1224d066-f1f6-4e54-b2d8-235915d04ba4
>> Ancestors: Tests-topa.332
>>
>> Expect MessageNotUnderstood for unknown prefs on Preferences, also, make the selector even more unlikely...
>>
>> =============== Diff against Tests-topa.332 ===============
>>
>> Item was changed:
>> ----- Method: PreferencesTest>>test08DNUFallback (in category 'tests') -----
>> test08DNUFallback
>>
>> sut setPreference: #foo toValue: 123.
>> sut class removeSelectorSilently: #foo.
>>
>> self assert: (sut perform: #foo) = 123.
>> + self should: [sut perform: #_unlikelyAndUnknownSelector] raise: MessageNotUnderstood.!
>
> I think this symbol should be quoted, so that it can compile in images where such selectors are not allowed.
>
> Levente
>
>> - self assert: (sut perform: #unknownSelector) isNil.!

ok :)