The Trunk: ToolBuilder-Kernel-fbs.58.mcz
Locked
 
|
Frank Shearar uploaded a new version of ToolBuilder-Kernel to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-fbs.58 Author: fbs Time: 31 October 2013, 10:18:57.495 pm UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb Ancestors: ToolBuilder-Kernel-dtl.57 Step 1 of moving control over display depth to the UIManagers. =============== Diff against ToolBuilder-Kernel-dtl.57 =============== Item was added: + ----- Method: UIManager>>newDisplayDepthNoRestore: (in category 'display') ----- + newDisplayDepthNoRestore: pixelSize + self subclassResponsibility.! Item was added: + ----- Method: UIManager>>restoreDisplay (in category 'display') ----- + restoreDisplay + self subclassResponsibility.! Item was added: + ----- Method: UIManager>>restoreDisplayAfter: (in category 'display') ----- + restoreDisplayAfter: aBlock + self subclassResponsibility.! |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
On 31 October 2013 22:19, <[hidden email]> wrote:
> Frank Shearar uploaded a new version of ToolBuilder-Kernel to project The Trunk: > http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz > > ==================== Summary ==================== > > Name: ToolBuilder-Kernel-fbs.58 > Author: fbs > Time: 31 October 2013, 10:18:57.495 pm > UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb > Ancestors: ToolBuilder-Kernel-dtl.57 > > Step 1 of moving control over display depth to the UIManagers. > > =============== Diff against ToolBuilder-Kernel-dtl.57 =============== So I think the next step is to make the DisplayScreen methods forward entirely to UIManagers. But getting this wrong means bad things. So I thought I'd check first that this will work out: * make the change * commit Graphics * change the update configuration map to load the UIManagers before Graphics. * copy Graphics to trunk Think it'll work? frank |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
Yes, but the other way is to commit a new mcm with the new UIManagers, but without Graphics changes. You then do not need to mess with load order... Unless I missed something.2013/10/31 Frank Shearar <[hidden email]>
|
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
In reply to this post by Frank Shearar-3
On Thu, 31 Oct 2013, Frank Shearar wrote:
> On 31 October 2013 22:19, <[hidden email]> wrote: >> Frank Shearar uploaded a new version of ToolBuilder-Kernel to project The Trunk: >> http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz >> >> ==================== Summary ==================== >> >> Name: ToolBuilder-Kernel-fbs.58 >> Author: fbs >> Time: 31 October 2013, 10:18:57.495 pm >> UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb >> Ancestors: ToolBuilder-Kernel-dtl.57 >> >> Step 1 of moving control over display depth to the UIManagers. >> >> =============== Diff against ToolBuilder-Kernel-dtl.57 =============== > > So I think the next step is to make the DisplayScreen methods forward > entirely to UIManagers. But getting this wrong means bad things. So I > thought I'd check first that this will work out: > * make the change > * commit Graphics > * change the update configuration map to load the UIManagers before Graphics. I consider changing the order of the packages in the configuration map a bad practice. The same thing can be achieved by simply creating a new mcm, which keeps the same package order, but specifies the version of the package which should be loaded first. How to get such map easily? Before you commit Graphics, browse the map, update from the image, and save. Then commit Graphics. > * copy Graphics to trunk > > Think it'll work? Hopefully. :) Levente > > frank > > |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
In reply to this post by Nicolas Cellier
I should read all mails before I start replying. :)
Levente On Thu, 31 Oct 2013, Nicolas Cellier wrote: > Yes, but the other way is to commit a new mcm with the new UIManagers, but without Graphics changes. > You then do not need to mess with load order... Unless I missed something. > > > 2013/10/31 Frank Shearar <[hidden email]> > On 31 October 2013 22:19, <[hidden email]> wrote: > > Frank Shearar uploaded a new version of ToolBuilder-Kernel to project The Trunk: > > http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz > > > > ==================== Summary ==================== > > > > Name: ToolBuilder-Kernel-fbs.58 > > Author: fbs > > Time: 31 October 2013, 10:18:57.495 pm > > UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb > > Ancestors: ToolBuilder-Kernel-dtl.57 > > > > Step 1 of moving control over display depth to the UIManagers. > > > > =============== Diff against ToolBuilder-Kernel-dtl.57 =============== > > So I think the next step is to make the DisplayScreen methods forward > entirely to UIManagers. But getting this wrong means bad things. So I > thought I'd check first that this will work out: > * make the change > * commit Graphics > * change the update configuration map to load the UIManagers before Graphics. > * copy Graphics to trunk > > Think it'll work? > > frank > > > > |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
The trick is to write the mail and then go to bed. In the morning, someone (some people) will have solved your problems! I'll publish two separate mcms.
Thanks! frank On 01 Nov 2013, at 0:44, Levente Uzonyi <[hidden email]> wrote: > I should read all mails before I start replying. :) > > > Levente > > On Thu, 31 Oct 2013, Nicolas Cellier wrote: > >> Yes, but the other way is to commit a new mcm with the new UIManagers, but without Graphics changes. >> You then do not need to mess with load order... Unless I missed something. >> 2013/10/31 Frank Shearar <[hidden email]> >> On 31 October 2013 22:19, <[hidden email]> wrote: >> > Frank Shearar uploaded a new version of ToolBuilder-Kernel to project The Trunk: >> > http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz >> > >> > ==================== Summary ==================== >> > >> > Name: ToolBuilder-Kernel-fbs.58 >> > Author: fbs >> > Time: 31 October 2013, 10:18:57.495 pm >> > UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb >> > Ancestors: ToolBuilder-Kernel-dtl.57 >> > >> > Step 1 of moving control over display depth to the UIManagers. >> > >> > =============== Diff against ToolBuilder-Kernel-dtl.57 =============== >> So I think the next step is to make the DisplayScreen methods forward >> entirely to UIManagers. But getting this wrong means bad things. So I >> thought I'd check first that this will work out: >> * make the change >> * commit Graphics >> * change the update configuration map to load the UIManagers before Graphics. >> * copy Graphics to trunk >> Think it'll work? >> frank > |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
Please, also remove the preamble and postscript in Graphics, it was a one shot workaround. 2013/11/1 Frank Shearar <[hidden email]> The trick is to write the mail and then go to bed. In the morning, someone (some people) will have solved your problems! I'll publish two separate mcms. |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
Nicely timed! I'm literally about to push up the new Graphics. Just
checking over the diff. frank On 1 November 2013 08:51, Nicolas Cellier <[hidden email]> wrote: > Please, also remove the preamble and postscript in Graphics, it was a one > shot workaround. > > > 2013/11/1 Frank Shearar <[hidden email]> >> >> The trick is to write the mail and then go to bed. In the morning, someone >> (some people) will have solved your problems! I'll publish two separate >> mcms. >> >> Thanks! >> >> frank >> >> On 01 Nov 2013, at 0:44, Levente Uzonyi <[hidden email]> wrote: >> >> > I should read all mails before I start replying. :) >> > >> > >> > Levente >> > >> > On Thu, 31 Oct 2013, Nicolas Cellier wrote: >> > >> >> Yes, but the other way is to commit a new mcm with the new UIManagers, >> >> but without Graphics changes. >> >> You then do not need to mess with load order... Unless I missed >> >> something. >> >> 2013/10/31 Frank Shearar <[hidden email]> >> >> On 31 October 2013 22:19, <[hidden email]> wrote: >> >> > Frank Shearar uploaded a new version of ToolBuilder-Kernel to >> >> project The Trunk: >> >> > http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz >> >> > >> >> > ==================== Summary ==================== >> >> > >> >> > Name: ToolBuilder-Kernel-fbs.58 >> >> > Author: fbs >> >> > Time: 31 October 2013, 10:18:57.495 pm >> >> > UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb >> >> > Ancestors: ToolBuilder-Kernel-dtl.57 >> >> > >> >> > Step 1 of moving control over display depth to the UIManagers. >> >> > >> >> > =============== Diff against ToolBuilder-Kernel-dtl.57 >> >> =============== >> >> So I think the next step is to make the DisplayScreen methods forward >> >> entirely to UIManagers. But getting this wrong means bad things. So I >> >> thought I'd check first that this will work out: >> >> * make the change >> >> * commit Graphics >> >> * change the update configuration map to load the UIManagers before >> >> Graphics. >> >> * copy Graphics to trunk >> >> Think it'll work? >> >> frank >> > >> > > > > |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
In reply to this post by Nicolas Cellier
On Fri, 1 Nov 2013, Nicolas Cellier wrote:
> Please, also remove the preamble and postscript in Graphics, it was a one shot workaround. Those won't be evaluated, unless they have changed. Levente > > > 2013/11/1 Frank Shearar <[hidden email]> > The trick is to write the mail and then go to bed. In the morning, someone (some people) will have solved your problems! I'll publish > two separate mcms. > > Thanks! > > frank > > On 01 Nov 2013, at 0:44, Levente Uzonyi <[hidden email]> wrote: > > > I should read all mails before I start replying. :) > > > > > > Levente > > > > On Thu, 31 Oct 2013, Nicolas Cellier wrote: > > > >> Yes, but the other way is to commit a new mcm with the new UIManagers, but without Graphics changes. > >> You then do not need to mess with load order... Unless I missed something. > >> 2013/10/31 Frank Shearar <[hidden email]> > >> On 31 October 2013 22:19, <[hidden email]> wrote: > >> > Frank Shearar uploaded a new version of ToolBuilder-Kernel to project The Trunk: > >> > http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz > >> > > >> > ==================== Summary ==================== > >> > > >> > Name: ToolBuilder-Kernel-fbs.58 > >> > Author: fbs > >> > Time: 31 October 2013, 10:18:57.495 pm > >> > UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb > >> > Ancestors: ToolBuilder-Kernel-dtl.57 > >> > > >> > Step 1 of moving control over display depth to the UIManagers. > >> > > >> > =============== Diff against ToolBuilder-Kernel-dtl.57 =============== > >> So I think the next step is to make the DisplayScreen methods forward > >> entirely to UIManagers. But getting this wrong means bad things. So I > >> thought I'd check first that this will work out: > >> * make the change > >> * commit Graphics > >> * change the update configuration map to load the UIManagers before Graphics. > >> * copy Graphics to trunk > >> Think it'll work? > >> frank > > > > > > |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
On 1 November 2013 13:02, Levente Uzonyi <[hidden email]> wrote:
> On Fri, 1 Nov 2013, Nicolas Cellier wrote: > >> Please, also remove the preamble and postscript in Graphics, it was a one >> shot workaround. > > > Those won't be evaluated, unless they have changed. But it's a good practice to follow, because otherwise someone else hacking on Graphics that needs a preamble doesn't have to wonder about whether or not the existing code's still needed. frank > Levente > > >> >> >> 2013/11/1 Frank Shearar <[hidden email]> >> The trick is to write the mail and then go to bed. In the morning, >> someone (some people) will have solved your problems! I'll publish >> two separate mcms. >> >> Thanks! >> >> frank >> >> On 01 Nov 2013, at 0:44, Levente Uzonyi <[hidden email]> wrote: >> >> > I should read all mails before I start replying. :) >> > >> > >> > Levente >> > >> > On Thu, 31 Oct 2013, Nicolas Cellier wrote: >> > >> >> Yes, but the other way is to commit a new mcm with the new >> UIManagers, but without Graphics changes. >> >> You then do not need to mess with load order... Unless I missed >> something. >> >> 2013/10/31 Frank Shearar <[hidden email]> >> >> On 31 October 2013 22:19, <[hidden email]> >> wrote: >> >> > Frank Shearar uploaded a new version of ToolBuilder-Kernel >> to project The Trunk: >> >> > >> http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz >> >> > >> >> > ==================== Summary ==================== >> >> > >> >> > Name: ToolBuilder-Kernel-fbs.58 >> >> > Author: fbs >> >> > Time: 31 October 2013, 10:18:57.495 pm >> >> > UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb >> >> > Ancestors: ToolBuilder-Kernel-dtl.57 >> >> > >> >> > Step 1 of moving control over display depth to the >> UIManagers. >> >> > >> >> > =============== Diff against ToolBuilder-Kernel-dtl.57 >> =============== >> >> So I think the next step is to make the DisplayScreen methods >> forward >> >> entirely to UIManagers. But getting this wrong means bad things. >> So I >> >> thought I'd check first that this will work out: >> >> * make the change >> >> * commit Graphics >> >> * change the update configuration map to load the UIManagers >> before Graphics. >> >> * copy Graphics to trunk >> >> Think it'll work? >> >> frank |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
On Fri, 1 Nov 2013, Frank Shearar wrote:
> On 1 November 2013 13:02, Levente Uzonyi <[hidden email]> wrote: >> On Fri, 1 Nov 2013, Nicolas Cellier wrote: >> >>> Please, also remove the preamble and postscript in Graphics, it was a one >>> shot workaround. >> >> >> Those won't be evaluated, unless they have changed. > > But it's a good practice to follow, because otherwise someone else > hacking on Graphics that needs a preamble doesn't have to wonder about > whether or not the existing code's still needed. When you change these scripts, you should remove the previous stuff altogether, since these scripts are always intended to be run once. Levente > > frank > >> Levente >> >> >>> >>> >>> 2013/11/1 Frank Shearar <[hidden email]> >>> The trick is to write the mail and then go to bed. In the morning, >>> someone (some people) will have solved your problems! I'll publish >>> two separate mcms. >>> >>> Thanks! >>> >>> frank >>> >>> On 01 Nov 2013, at 0:44, Levente Uzonyi <[hidden email]> wrote: >>> >>> > I should read all mails before I start replying. :) >>> > >>> > >>> > Levente >>> > >>> > On Thu, 31 Oct 2013, Nicolas Cellier wrote: >>> > >>> >> Yes, but the other way is to commit a new mcm with the new >>> UIManagers, but without Graphics changes. >>> >> You then do not need to mess with load order... Unless I missed >>> something. >>> >> 2013/10/31 Frank Shearar <[hidden email]> >>> >> On 31 October 2013 22:19, <[hidden email]> >>> wrote: >>> >> > Frank Shearar uploaded a new version of ToolBuilder-Kernel >>> to project The Trunk: >>> >> > >>> http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz >>> >> > >>> >> > ==================== Summary ==================== >>> >> > >>> >> > Name: ToolBuilder-Kernel-fbs.58 >>> >> > Author: fbs >>> >> > Time: 31 October 2013, 10:18:57.495 pm >>> >> > UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb >>> >> > Ancestors: ToolBuilder-Kernel-dtl.57 >>> >> > >>> >> > Step 1 of moving control over display depth to the >>> UIManagers. >>> >> > >>> >> > =============== Diff against ToolBuilder-Kernel-dtl.57 >>> =============== >>> >> So I think the next step is to make the DisplayScreen methods >>> forward >>> >> entirely to UIManagers. But getting this wrong means bad things. >>> So I >>> >> thought I'd check first that this will work out: >>> >> * make the change >>> >> * commit Graphics >>> >> * change the update configuration map to load the UIManagers >>> before Graphics. >>> >> * copy Graphics to trunk >>> >> Think it'll work? >>> >> frank > > |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
On 1 November 2013 15:31, Levente Uzonyi <[hidden email]> wrote:
> On Fri, 1 Nov 2013, Frank Shearar wrote: > >> On 1 November 2013 13:02, Levente Uzonyi <[hidden email]> wrote: >>> >>> On Fri, 1 Nov 2013, Nicolas Cellier wrote: >>> >>>> Please, also remove the preamble and postscript in Graphics, it was a >>>> one >>>> shot workaround. >>> >>> >>> >>> Those won't be evaluated, unless they have changed. >> >> >> But it's a good practice to follow, because otherwise someone else >> hacking on Graphics that needs a preamble doesn't have to wonder about >> whether or not the existing code's still needed. > > > When you change these scripts, you should remove the previous stuff > altogether, since these scripts are always intended to be run once. I thought that's what I was saying? Graphics' preamble now just has a comment saying what it's for (to run stuff before Graphics loads). Or do you mean deleting the preamble entirely? frank > Levente > > >> >> frank >> >>> Levente >>> >>> >>>> >>>> >>>> 2013/11/1 Frank Shearar <[hidden email]> >>>> The trick is to write the mail and then go to bed. In the morning, >>>> someone (some people) will have solved your problems! I'll publish >>>> two separate mcms. >>>> >>>> Thanks! >>>> >>>> frank >>>> >>>> On 01 Nov 2013, at 0:44, Levente Uzonyi <[hidden email]> wrote: >>>> >>>> > I should read all mails before I start replying. :) >>>> > >>>> > >>>> > Levente >>>> > >>>> > On Thu, 31 Oct 2013, Nicolas Cellier wrote: >>>> > >>>> >> Yes, but the other way is to commit a new mcm with the new >>>> UIManagers, but without Graphics changes. >>>> >> You then do not need to mess with load order... Unless I missed >>>> something. >>>> >> 2013/10/31 Frank Shearar <[hidden email]> >>>> >> On 31 October 2013 22:19, <[hidden email]> >>>> wrote: >>>> >> > Frank Shearar uploaded a new version of ToolBuilder-Kernel >>>> to project The Trunk: >>>> >> > >>>> http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz >>>> >> > >>>> >> > ==================== Summary ==================== >>>> >> > >>>> >> > Name: ToolBuilder-Kernel-fbs.58 >>>> >> > Author: fbs >>>> >> > Time: 31 October 2013, 10:18:57.495 pm >>>> >> > UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb >>>> >> > Ancestors: ToolBuilder-Kernel-dtl.57 >>>> >> > >>>> >> > Step 1 of moving control over display depth to the >>>> UIManagers. >>>> >> > >>>> >> > =============== Diff against ToolBuilder-Kernel-dtl.57 >>>> =============== >>>> >> So I think the next step is to make the DisplayScreen methods >>>> forward >>>> >> entirely to UIManagers. But getting this wrong means bad things. >>>> So I >>>> >> thought I'd check first that this will work out: >>>> >> * make the change >>>> >> * commit Graphics >>>> >> * change the update configuration map to load the UIManagers >>>> before Graphics. >>>> >> * copy Graphics to trunk >>>> >> Think it'll work? >>>> >> frank >> >> >> > |
Re: The Trunk: ToolBuilder-Kernel-fbs.58.mcz
|
|
On Fri, 1 Nov 2013, Frank Shearar wrote:
> On 1 November 2013 15:31, Levente Uzonyi <[hidden email]> wrote: >> On Fri, 1 Nov 2013, Frank Shearar wrote: >> >>> On 1 November 2013 13:02, Levente Uzonyi <[hidden email]> wrote: >>>> >>>> On Fri, 1 Nov 2013, Nicolas Cellier wrote: >>>> >>>>> Please, also remove the preamble and postscript in Graphics, it was a >>>>> one >>>>> shot workaround. >>>> >>>> >>>> >>>> Those won't be evaluated, unless they have changed. >>> >>> >>> But it's a good practice to follow, because otherwise someone else >>> hacking on Graphics that needs a preamble doesn't have to wonder about >>> whether or not the existing code's still needed. >> >> >> When you change these scripts, you should remove the previous stuff >> altogether, since these scripts are always intended to be run once. > > I thought that's what I was saying? Graphics' preamble now just has a > comment saying what it's for (to run stuff before Graphics loads). Or > do you mean deleting the preamble entirely? No, I meant that it's pointless to remove the preamble if you don't want to use it. But if you want to run something before package loading, then you should remove everything from the preamble before adding your code. Same is true for postscript too. Levente > > frank > >> Levente >> >> >>> >>> frank >>> >>>> Levente >>>> >>>> >>>>> >>>>> >>>>> 2013/11/1 Frank Shearar <[hidden email]> >>>>> The trick is to write the mail and then go to bed. In the morning, >>>>> someone (some people) will have solved your problems! I'll publish >>>>> two separate mcms. >>>>> >>>>> Thanks! >>>>> >>>>> frank >>>>> >>>>> On 01 Nov 2013, at 0:44, Levente Uzonyi <[hidden email]> wrote: >>>>> >>>>> > I should read all mails before I start replying. :) >>>>> > >>>>> > >>>>> > Levente >>>>> > >>>>> > On Thu, 31 Oct 2013, Nicolas Cellier wrote: >>>>> > >>>>> >> Yes, but the other way is to commit a new mcm with the new >>>>> UIManagers, but without Graphics changes. >>>>> >> You then do not need to mess with load order... Unless I missed >>>>> something. >>>>> >> 2013/10/31 Frank Shearar <[hidden email]> >>>>> >> On 31 October 2013 22:19, <[hidden email]> >>>>> wrote: >>>>> >> > Frank Shearar uploaded a new version of ToolBuilder-Kernel >>>>> to project The Trunk: >>>>> >> > >>>>> http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz >>>>> >> > >>>>> >> > ==================== Summary ==================== >>>>> >> > >>>>> >> > Name: ToolBuilder-Kernel-fbs.58 >>>>> >> > Author: fbs >>>>> >> > Time: 31 October 2013, 10:18:57.495 pm >>>>> >> > UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb >>>>> >> > Ancestors: ToolBuilder-Kernel-dtl.57 >>>>> >> > >>>>> >> > Step 1 of moving control over display depth to the >>>>> UIManagers. >>>>> >> > >>>>> >> > =============== Diff against ToolBuilder-Kernel-dtl.57 >>>>> =============== >>>>> >> So I think the next step is to make the DisplayScreen methods >>>>> forward >>>>> >> entirely to UIManagers. But getting this wrong means bad things. >>>>> So I >>>>> >> thought I'd check first that this will work out: >>>>> >> * make the change >>>>> >> * commit Graphics >>>>> >> * change the update configuration map to load the UIManagers >>>>> before Graphics. >>>>> >> * copy Graphics to trunk >>>>> >> Think it'll work? >>>>> >> frank >>> >>> >>> >> > > |
«
Return to Squeak - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |