The Trunk: ToolBuilder-MVC-nice.32.mcz

Nicolas Cellier uploaded a new version of ToolBuilder-MVC to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-MVC-nice.32.mcz

==================== Summary ====================

Name: ToolBuilder-MVC-nice.32
Author: nice
Time: 12 March 2013, 10:02:20.283 pm
UUID: daf12aae-1237-4665-955b-ef69eb6b42f2
Ancestors: ToolBuilder-MVC-dtl.31

Correct buildPluggableButton: label could be nil

=============== Diff against ToolBuilder-MVC-dtl.31 ===============

Item was changed:
  ----- Method: MVCToolBuilder>>buildPluggableButton: (in category 'pluggable widgets') -----
  buildPluggableButton: aSpec
  | widget label state |
  label := aSpec label.
  state := aSpec state.
  widget := PluggableButtonView on: aSpec model
  getState: (state isSymbol ifTrue:[state])
  action: aSpec action
  label: (label isSymbol ifTrue:[label]).
  self register: widget id: aSpec name.
+ label ifNotNil: [label isSymbol
- label isSymbol
  ifTrue: [widget label: (aSpec model perform: label)]
+ ifFalse: [widget label: label]].
- ifFalse: [widget label: label].
  self setFrame: aSpec frame in: widget.
+ parent ifNotNil: [parent addSubView: widget].
- parent ifNotNil:[parent addSubView: widget].
  ^widget!

On 12 March 2013 21:02,  <[hidden email]> wrote:
Excellent! I was just looking at that test failure in #223:
http://build.squeak.org/job/SqueakTrunk/223/testReport/ToolBuilder.MVC/MVCToolBuilderTests/testButtonFiresSymbol/

frank