Smalltalk › Squeak › Squeak - Dev

The Trunk: ToolBuilder-Morphic-ct.252.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

commits-2

The Trunk: ToolBuilder-Morphic-ct.252.mcz

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.252.mcz

==================== Summary ====================

Name: ToolBuilder-Morphic-ct.252
Author: ct
Time: 20 January 2020, 8:57:46.404972 pm
UUID: 2b311bcc-31ca-dc4d-8ebf-7a1cad07624e
Ancestors: ToolBuilder-Morphic-mt.251

Implement "browse/debug button action" properly on PluggabeButtonMorphPlus

=============== Diff against ToolBuilder-Morphic-mt.251 ===============

Item was added:
+ ----- Method: PluggableButtonMorphPlus>>browseImplementationOfActionSelector (in category 'debug menu') -----
+ browseImplementationOfActionSelector
+
+ action ifNotNil: [
+ ^ action outerContext method browse].
+ ^ super browseImplementationOfActionSelector!

Item was added:
+ ----- Method: PluggableButtonMorphPlus>>debugAction (in category 'debug menu') -----
+ debugAction
+
+ action ifNil: [^ super debugAction].
+ (Process
+ forBlock: [self performAction]
+ runUntil: [:context | context closure = action])
+ debugWithTitle: ('Debug button action "{1}" in model "{2}"' format: {self label. self target printString}).!

Christoph Thiede

Re: The Trunk: ToolBuilder-Morphic-ct.252.mcz

Hi Marcel,

thank you for reviewing all this stuff! :-)

Might this be a good point to push the discussion from http://forum.world.st/The-Inbox-System-ct-1149-mcz-td5114102.html again? It would allow us to rewrite the #debugAction implementation here as follows:

debugAction

action ifNil: [^ super debugAction].

[self performAction]

debugFromContextThat: [context closure = action]

title: ('Debug button action "{1}" in model "{2}"' format: {self label. self target printString}).

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 1. Oktober 2020 16:06 Uhr
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: ToolBuilder-Morphic-ct.252.mcz

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.252.mcz

==================== Summary ====================

Name: ToolBuilder-Morphic-ct.252
Author: ct
Time: 20 January 2020, 8:57:46.404972 pm
UUID: 2b311bcc-31ca-dc4d-8ebf-7a1cad07624e
Ancestors: ToolBuilder-Morphic-mt.251

Implement "browse/debug button action" properly on PluggabeButtonMorphPlus

=============== Diff against ToolBuilder-Morphic-mt.251 ===============

Item was added:
+ ----- Method: PluggableButtonMorphPlus>>browseImplementationOfActionSelector (in category 'debug menu') -----
+ browseImplementationOfActionSelector
+
+        action ifNotNil: [
+                ^ action outerContext method browse].
+        ^ super browseImplementationOfActionSelector!

Item was added:
+ ----- Method: PluggableButtonMorphPlus>>debugAction (in category 'debug menu') -----
+ debugAction
+
+        action ifNil: [^ super debugAction].
+        (Process
+                forBlock: [self performAction]
+                runUntil: [:context | context closure = action])
+                        debugWithTitle: ('Debug button action "{1}" in model "{2}"' format: {self label. self target printString}).!

Carpe Squeak!

marcel.taeumel

Re: The Trunk: ToolBuilder-Morphic-ct.252.mcz

Hi Chirstoph,

not sure I like the wording #debugFromContextThat:title:. On the plus side, we can remove the explicit reference to #Process.

Maybe consider what is already in the system:

Morph >> #firstOwnerSuchThat:

Object >> #hasLiteralSuchThat:

ChangeList >> #selectSuchThat:

Maybe #debugContextSuchThat:(withTitle:)?

Best,

Marcel

Am 01.10.2020 22:47:49 schrieb Thiede, Christoph <[hidden email]>:

Hi Marcel,

thank you for reviewing all this stuff! :-)

Might this be a good point to push the discussion from http://forum.world.st/The-Inbox-System-ct-1149-mcz-td5114102.html again? It would allow us to rewrite the #debugAction implementation here as follows:

debugAction

action ifNil: [^ super debugAction].

[self performAction]

debugFromContextThat: [context closure = action]

title: ('Debug button action "{1}" in model "{2}"' format: {self label. self target printString}).

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 1. Oktober 2020 16:06 Uhr
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: ToolBuilder-Morphic-ct.252.mcz

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.252.mcz

==================== Summary ====================

Name: ToolBuilder-Morphic-ct.252
Author: ct
Time: 20 January 2020, 8:57:46.404972 pm
UUID: 2b311bcc-31ca-dc4d-8ebf-7a1cad07624e
Ancestors: ToolBuilder-Morphic-mt.251

Implement "browse/debug button action" properly on PluggabeButtonMorphPlus

=============== Diff against ToolBuilder-Morphic-mt.251 ===============

Item was added:
+ ----- Method: PluggableButtonMorphPlus>>browseImplementationOfActionSelector (in category 'debug menu') -----
+ browseImplementationOfActionSelector
+
+        action ifNotNil: [
+                ^ action outerContext method browse].
+        ^ super browseImplementationOfActionSelector!

Item was added:
+ ----- Method: PluggableButtonMorphPlus>>debugAction (in category 'debug menu') -----
+ debugAction
+
+        action ifNil: [^ super debugAction].
+        (Process
+                forBlock: [self performAction]
+                runUntil: [:context | context closure = action])
+                        debugWithTitle: ('Debug button action "{1}" in model "{2}"' format: {self label. self target printString}).!