The Trunk: ToolBuilder-Morphic-mt.256.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: ToolBuilder-Morphic-mt.256.mcz

commits-2
Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.256.mcz

==================== Summary ====================

Name: ToolBuilder-Morphic-mt.256
Author: mt
Time: 3 April 2020, 5:50:25.120206 pm
UUID: 7666414e-e468-234e-9ad7-85db6d6cdb5e
Ancestors: ToolBuilder-Morphic-mt.255

Fixes a drag-and-drop bug in pluggable lists whose models do not provide a wantsDropSelector.

As you can see in #acceptDrop..., the pluggable list itself depends on the morph to be a TransferMorph. We might want to change #isKindOf: to #isTransferMorph or #respondsTo: in the future. Well, drag-and-drop is kind of important and it may deserve an #isTransferMorph in Morph to be added.

=============== Diff against ToolBuilder-Morphic-mt.255 ===============

Item was changed:
  ----- Method: PluggableListMorphPlus>>wantsDroppedMorph:event: (in category 'drag and drop') -----
  wantsDroppedMorph: aTransferMorph event: anEvent
 
  dropItemSelector ifNil: [^ false].
+ (aTransferMorph isKindOf: TransferMorph) ifFalse: [^ false].
  wantsDropSelector ifNil: [^ true].
 
- (aTransferMorph isKindOf: TransferMorph) ifFalse: [^ false].
-
  ^ model perform: wantsDropSelector withEnoughArguments: {
  aTransferMorph passenger.
  aTransferMorph dragTransferType.
  aTransferMorph source.
  aTransferMorph}!