The Trunk: Tools-bf.725.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tools-bf.725.mcz

commits-2
Bert Freudenberg uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-bf.725.mcz

==================== Summary ====================

Name: Tools-bf.725
Author: bf
Time: 6 September 2016, 5:52:33.688676 pm
UUID: 56a8eacc-9562-41ae-88b9-93faf2ab23c5
Ancestors: Tools-tfel.724

Fix 'textual references to dropped morphs' as suggested by Yakov.

=============== Diff against Tools-tfel.724 ===============

Item was changed:
  ----- Method: Workspace>>acceptDroppingMorph:event:inMorph: (in category 'drag and drop') -----
  acceptDroppingMorph: dropee event: evt inMorph: targetMorph
  "Return the dropee to its old position, and add a reference to it at the
  cursor point."
  | bindingName externalName reference |
  (dropee isKindOf: TransferMorph)
  ifTrue: [reference := dropee passenger.
  externalName := dropee passenger className]
  ifFalse: [reference := dropee.
+ externalName := dropee externalName].
- dropee externalName].
  externalName := externalName isOctetString
  ifTrue: [externalName]
  ifFalse: ['a' , externalName].
  bindingName := externalName withFirstCharacterDownshifted , reference identityHash printString.
  targetMorph correctSelectionWithString: bindingName , ' '.
  (self bindingOf: bindingName)
  value: reference.
  (dropee isKindOf: TransferMorph)
  ifFalse: [dropee rejectDropMorphEvent: evt].
  ^ true"success"!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tools-bf.725.mcz

Hannes Hirzel
Very useful fix when dealing with Morphc, thank you Yakov and Bert.

On Tue, 6 Sep 2016 15:52:39.672 0000, [hidden email]
<[hidden email]> wrote:

> Bert Freudenberg uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-bf.725.mcz
>
> ==================== Summary ====================
>
> Name: Tools-bf.725
> Author: bf
> Time: 6 September 2016, 5:52:33.688676 pm
> UUID: 56a8eacc-9562-41ae-88b9-93faf2ab23c5
> Ancestors: Tools-tfel.724
>
> Fix 'textual references to dropped morphs' as suggested by Yakov.
>
> =============== Diff against Tools-tfel.724 ===============
>
> Item was changed:
>   ----- Method: Workspace>>acceptDroppingMorph:event:inMorph: (in category
> 'drag and drop') -----
>   acceptDroppingMorph: dropee event: evt inMorph: targetMorph
>   "Return the dropee to its old position, and add a reference to it at the
>   cursor point."
>   | bindingName externalName reference |
>   (dropee isKindOf: TransferMorph)
>   ifTrue: [reference := dropee passenger.
>   externalName := dropee passenger className]
>   ifFalse: [reference := dropee.
> + externalName := dropee externalName].
> - dropee externalName].
>   externalName := externalName isOctetString
>   ifTrue: [externalName]
>   ifFalse: ['a' , externalName].
>   bindingName := externalName withFirstCharacterDownshifted , reference
> identityHash printString.
>   targetMorph correctSelectionWithString: bindingName , ' '.
>   (self bindingOf: bindingName)
>   value: reference.
>   (dropee isKindOf: TransferMorph)
>   ifFalse: [dropee rejectDropMorphEvent: evt].
>   ^ true"success"!
>
>
>