Chris Muller uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-cmm.501.mcz ==================== Summary ==================== Name: Tools-cmm.501 Author: cmm Time: 23 October 2013, 3:09:28.913 pm UUID: 91844028-c199-4119-8a22-1b06b1efbe77 Ancestors: Tools-cmm.500 RecentMessages fix and haircut. =============== Diff against Tools-cmm.500 =============== Item was changed: MessageSet subclass: #RecentMessageSet instanceVariableNames: '' + classVariableNames: '' - classVariableNames: 'NumberOfRecentSubmissionsToStore' poolDictionaries: '' category: 'Tools-Browser'! !RecentMessageSet commentStamp: 'sw 8/1/2002 17:40' prior: 0! RecentMessageSet is a message set that shows the most recently-submitted methods, in chronological order.! Item was removed: - ----- Method: RecentMessageSet class>>numberOfRecentSubmissionsToStore (in category 'preferences') ----- - numberOfRecentSubmissionsToStore - <preference: 'Number of recent submissions to store' - category: 'Tools' - description: 'Answer how many methods back the ''recent method submissions'' history should store' - type: #Number> - ^NumberOfRecentSubmissionsToStore - ifNil: [NumberOfRecentSubmissionsToStore := 30].! Item was removed: - ----- Method: RecentMessageSet>>maybeSetSelection (in category 'selection') ----- - maybeSetSelection - "After a browser's message list is changed, this message is dispatched to the model, to give it a chance to refigure a selection" - self messageListIndex: 1! Item was changed: ----- Method: RecentMessageSet>>reformulateList (in category 'update') ----- reformulateList - | myList | "Reformulate the receiver's list. Exclude methods now deleted" + self initializeMessageList: + (RecentMessages default methodReferences select: + [ : each | each isValid ]). + self messageListIndex: (messageList size min: 1). "0 or 1" - - myList := RecentMessages default methodReferences reversed select: [ :each | each isValid]. - self initializeMessageList: myList. - self messageListIndex: (messageList size min: 1). "0 or 1" self changed: #messageList. self changed: #messageListIndex! Item was changed: ----- Method: Utilities class>>browseRecentSubmissions (in category '*Tools') ----- browseRecentSubmissions + "Open up a browser on the most recent methods submitted in the image." - "Open up a browser on the most recent methods submitted in the image. 5/96 sw." - - "Utilities browseRecentSubmissions" - - | recentMessages | - recentMessages := RecentMessages default methodReferences reversed. ^ RecentMessageSet + openMessageList: RecentMessages default methodReferences - openMessageList: recentMessages name: 'Recent submissions -- youngest first ' + autoSelect: nil! - autoSelect: nil.! Item was changed: ----- Method: Utilities class>>openRecentSubmissionsBrowser (in category '*Tools') ----- openRecentSubmissionsBrowser "Open up a browser on the most recent methods submitted in the image; reuse any existing one found in the world." + self deprecated: 'use #browseRecentSubmissions'. + self browseRecentSubmissions! - - self currentWorld openRecentSubmissionsBrowser: nil! Item was changed: ----- Method: Utilities class>>recentSubmissionsWindow (in category '*Tools') ----- recentSubmissionsWindow "Answer a SystemWindow holding recent submissions" | recentMessages messageSet | + recentMessages := RecentMessages default methodReferences. - recentMessages := RecentMessages default methodReferences reversed. messageSet := RecentMessageSet messageList: recentMessages. messageSet autoSelectString: nil. ^ ToolBuilder build: messageSet "Utilities recentSubmissionsWindow openInHand" ! |
On 23 October 2013 21:09, <[hidden email]> wrote:
> Chris Muller uploaded a new version of Tools to project The Trunk: > http://source.squeak.org/trunk/Tools-cmm.501.mcz > > ==================== Summary ==================== > > Name: Tools-cmm.501 > Author: cmm > Time: 23 October 2013, 3:09:28.913 pm > UUID: 91844028-c199-4119-8a22-1b06b1efbe77 > Ancestors: Tools-cmm.500 > > RecentMessages fix and haircut. Which part is the fix? What was broken? > =============== Diff against Tools-cmm.500 =============== > > Item was changed: > MessageSet subclass: #RecentMessageSet > instanceVariableNames: '' > + classVariableNames: '' > - classVariableNames: 'NumberOfRecentSubmissionsToStore' > poolDictionaries: '' > category: 'Tools-Browser'! > > !RecentMessageSet commentStamp: 'sw 8/1/2002 17:40' prior: 0! > RecentMessageSet is a message set that shows the most recently-submitted methods, in chronological order.! > > Item was removed: > - ----- Method: RecentMessageSet class>>numberOfRecentSubmissionsToStore (in category 'preferences') ----- > - numberOfRecentSubmissionsToStore > - <preference: 'Number of recent submissions to store' > - category: 'Tools' > - description: 'Answer how many methods back the ''recent method submissions'' history should store' > - type: #Number> > - ^NumberOfRecentSubmissionsToStore > - ifNil: [NumberOfRecentSubmissionsToStore := 30].! I don't understand the point of removing this preference? frank |
On Thu, Oct 24, 2013 at 7:26 AM, Frank Shearar <[hidden email]> wrote:
> On 23 October 2013 21:09, <[hidden email]> wrote: >> Chris Muller uploaded a new version of Tools to project The Trunk: >> http://source.squeak.org/trunk/Tools-cmm.501.mcz >> >> ==================== Summary ==================== >> >> Name: Tools-cmm.501 >> Author: cmm >> Time: 23 October 2013, 3:09:28.913 pm >> UUID: 91844028-c199-4119-8a22-1b06b1efbe77 >> Ancestors: Tools-cmm.500 >> >> RecentMessages fix and haircut. > > Which part is the fix? What was broken? The methods list was being #reverse'd from several external locations, but the order should be maintained internally. I thought I had all the #reverse calls removed but I guess I had missed this one. >> =============== Diff against Tools-cmm.500 =============== >> >> Item was changed: >> MessageSet subclass: #RecentMessageSet >> instanceVariableNames: '' >> + classVariableNames: '' >> - classVariableNames: 'NumberOfRecentSubmissionsToStore' >> poolDictionaries: '' >> category: 'Tools-Browser'! >> >> !RecentMessageSet commentStamp: 'sw 8/1/2002 17:40' prior: 0! >> RecentMessageSet is a message set that shows the most recently-submitted methods, in chronological order.! >> >> Item was removed: >> - ----- Method: RecentMessageSet class>>numberOfRecentSubmissionsToStore (in category 'preferences') ----- >> - numberOfRecentSubmissionsToStore >> - <preference: 'Number of recent submissions to store' >> - category: 'Tools' >> - description: 'Answer how many methods back the ''recent method submissions'' history should store' >> - type: #Number> >> - ^NumberOfRecentSubmissionsToStore >> - ifNil: [NumberOfRecentSubmissionsToStore := 30].! > > I don't understand the point of removing this preference? The preference is still there -- I'm not sure how it got into Tools, I thought it was always in System and that's where it still is. Just the class-var was removed. Since RecentMessages is a Singleton, the class-var was redundant. |
On 24 October 2013 16:25, Chris Muller <[hidden email]> wrote:
> On Thu, Oct 24, 2013 at 7:26 AM, Frank Shearar <[hidden email]> wrote: >> On 23 October 2013 21:09, <[hidden email]> wrote: >>> Chris Muller uploaded a new version of Tools to project The Trunk: >>> http://source.squeak.org/trunk/Tools-cmm.501.mcz >>> >>> ==================== Summary ==================== >>> >>> Name: Tools-cmm.501 >>> Author: cmm >>> Time: 23 October 2013, 3:09:28.913 pm >>> UUID: 91844028-c199-4119-8a22-1b06b1efbe77 >>> Ancestors: Tools-cmm.500 >>> >>> RecentMessages fix and haircut. >> >> Which part is the fix? What was broken? > > The methods list was being #reverse'd from several external locations, > but the order should be maintained internally. I thought I had all > the #reverse calls removed but I guess I had missed this one. > >>> =============== Diff against Tools-cmm.500 =============== >>> >>> Item was changed: >>> MessageSet subclass: #RecentMessageSet >>> instanceVariableNames: '' >>> + classVariableNames: '' >>> - classVariableNames: 'NumberOfRecentSubmissionsToStore' >>> poolDictionaries: '' >>> category: 'Tools-Browser'! >>> >>> !RecentMessageSet commentStamp: 'sw 8/1/2002 17:40' prior: 0! >>> RecentMessageSet is a message set that shows the most recently-submitted methods, in chronological order.! >>> >>> Item was removed: >>> - ----- Method: RecentMessageSet class>>numberOfRecentSubmissionsToStore (in category 'preferences') ----- >>> - numberOfRecentSubmissionsToStore >>> - <preference: 'Number of recent submissions to store' >>> - category: 'Tools' >>> - description: 'Answer how many methods back the ''recent method submissions'' history should store' >>> - type: #Number> >>> - ^NumberOfRecentSubmissionsToStore >>> - ifNil: [NumberOfRecentSubmissionsToStore := 30].! >> >> I don't understand the point of removing this preference? > > The preference is still there -- I'm not sure how it got into Tools, I > thought it was always in System and that's where it still is. > > Just the class-var was removed. Since RecentMessages is a Singleton, > the class-var was redundant. The problem was that I completely failed to notice "Set" at the end of "RecentMessageSet". Actually, I thought I'd removed this class var from RecentMessageSet, but clearly not. My bad! frank |
Free forum by Nabble | Edit this page |