The Trunk: Tools-cmm.634.mcz

Chris Muller uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-cmm.634.mcz

==================== Summary ====================

Name: Tools-cmm.634
Author: cmm
Time: 5 October 2015, 1:39:05.231 pm
UUID: 1b9e0e4c-f728-48ff-9046-54b7f7c302d0
Ancestors: Tools-cmm.620, Tools-eem.633

- IDE, please stop forcing a message category selection just because I accepted a method.  If I want that, I'll simply press the hot-key, Shift+Command+C.

=============== Diff against Tools-eem.633 ===============

Item was changed:
  ----- Method: Browser>>compileMessage:notifying: (in category 'code pane') -----
  compileMessage: aText notifying: aController
  "Compile the code that was accepted by the user, placing the compiled method into an appropriate message category.  Return true if the compilation succeeded, else false."
-
  | fallBackCategoryName originalSelectorName result fallBackMethodName |
+ self selectedMessageCategoryName = ClassOrganizer allCategory
-
- self selectedMessageCategoryName ifNil:
- [ self selectOriginalCategoryForCurrentMethod
- ifFalse:["Select the '--all--' category"
- self messageCategoryListIndex: 1]].
-
-
- self selectedMessageCategoryName asSymbol = ClassOrganizer allCategory
  ifTrue:
  [ "User tried to save a method while the ALL category was selected"
  fallBackCategoryName := selectedMessageCategoryName.
  fallBackMethodName := selectedMessageName.
  editSelection == #newMessage
  ifTrue:
  [ "Select the 'as yet unclassified' category"
  selectedMessageCategoryName := nil.
  (result := self defineMessageFrom: aText notifying: aController)
  ifNil:
  ["Compilation failure:  reselect the original category & method"
  selectedMessageCategoryName := fallBackCategoryName.
  selectedMessageName := fallBackMethodName]
  ifNotNil:
  [self setSelector: result]]
  ifFalse:
  [originalSelectorName := self selectedMessageName.
  self setOriginalCategoryIndexForCurrentMethod.
  selectedMessageName := fallBackMethodName := originalSelectorName.
  (result := self defineMessageFrom: aText notifying: aController)
  ifNotNil:
  [self setSelector: result]
  ifNil:
  [ "Compilation failure:  reselect the original category & method"
  selectedMessageCategoryName := fallBackCategoryName.
  selectedMessageName := fallBackMethodName.
  ^ result notNil]].
  self changed: #messageCategoryList.
  ^ result notNil]
  ifFalse:
  [ "User tried to save a method while the ALL category was NOT selected"
  ^ (self defineMessageFrom: aText notifying: aController) notNil]!

This introduces a regression because changed methods now get the "nil" category if no category is selected... :-/

Additionally, you cannot simply adopt another methods category for a new method by simple replacing and saving the source.

Best,
Marcel

In my testing, its actually the "as yet unclassified" category (maybe
nil under the covers).

I just did a fix which strikes a balance.  I really don't want it to
change my list (non)selection, but at least now it will select the
category of the method being overtyped so the user doesn't have to
categorize method separately afterward.

On Tue, Nov 10, 2015 at 3:51 AM, marcel.taeumel <[hidden email]> wrote:

> change my list (non)selection, but at least now it will select the

it will ASSIGN (not select) the category of the method being overtyped...

This is much better.

BUT: Now, you cannot accept a method without overwriting another method's sources. That is, you cannot work with the method template anymore... ;)

--> Key not found: nil.

Best,
Marcel