The Trunk: Tools-cmm.703.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tools-cmm.703.mcz

commits-2
Chris Muller uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-cmm.703.mcz

==================== Summary ====================

Name: Tools-cmm.703
Author: cmm
Time: 2 June 2016, 5:41:56.679756 pm
UUID: 9e4c33b5-dae7-4884-9e46-22a4833bebd7
Ancestors: Tools-eem.702

- Corrected menu hot-key indication for 'show category' -- it's (Y) not (C).
- Upgraded it to 'toggle category selection', which is really useful given that browsers spawned via Cmd+b come with category automatically selected.

=============== Diff against Tools-eem.702 ===============

Item was removed:
- ----- Method: Browser>>selectOriginalCategoryForCurrentMethod (in category 'message category list') -----
- selectOriginalCategoryForCurrentMethod
- "private - Select the message category for the current method.
-
- Note:  This should only be called when somebody tries to save  
- a method that they are modifying while ALL is selected.
-
- Returns: true on success, false on failure."
- | aSymbol selectorName |
- aSymbol := self categoryOfCurrentMethod.
- selectorName := self selectedMessageName.
- (aSymbol notNil and: [aSymbol ~= ClassOrganizer allCategory])
- ifTrue:
- [selectedMessageCategoryName := aSymbol.
- selectedMessageName := selectorName.
- self changed: #messageCategorySelectionChanged.
- self changed: #messageCategoryListIndex. "update my selection"
- self changed: #messageList.
- self changed: #messageListIndex.
- ^ true].
- ^ false!

Item was changed:
  ----- Method: Browser>>shiftedMessageListMenu: (in category 'message functions') -----
  shiftedMessageListMenu: aMenu
  <messageListMenuShifted: true>
  "Fill aMenu with the items appropriate when the shift key is held down"
 
  aMenu addStayUpItem.
  aMenu addList: #(
  ('toggle diffing (D)' toggleDiffing)
  ('implementors of sent messages' browseAllMessages)
  -
  ('local senders of...' browseLocalSendersOfMessages)
  ('local implementors of...' browseLocalImplementors)
  -
  ('spawn sub-protocol' spawnProtocol)
  ('spawn full protocol' spawnFullProtocol)
  -
  ('sample instance' makeSampleInstance)
  ('inspect instances' inspectInstances)
  ('inspect subinstances' inspectSubInstances)).
 
  self addExtraShiftedItemsTo: aMenu.
  aMenu addList: #(
  -
  ('change category...' changeCategory)).
 
  self canShowMultipleMessageCategories ifTrue: [aMenu addList:
+ #(('toggle category selection (Y)' showHomeCategory))].
- #(('show category (C)' showHomeCategory))].
  aMenu addList: #(
  -
  ('change sets with this method' findMethodInChangeSets)
  ('revert to previous version' revertToPreviousVersion)
  ('remove from current change set' removeFromCurrentChanges)
  ('revert & remove from changes' revertAndForget)
  ('add to current change set' adoptMessageInCurrentChangeset)
  ('copy up or copy down...' copyUpOrCopyDown)).
  ^ aMenu
  !

Item was changed:
  ----- Method: Browser>>showHomeCategory (in category 'message category functions') -----
  showHomeCategory
  "Show the home category of the selected method.  This is only really useful if one is in a tool that supports the showing of categories.  Thus, it's good in browsers and hierarchy browsers but not in message-list browsers"
 
  | aSelector |
  self okToChange ifTrue:
  [(aSelector := self selectedMessageName) ifNotNil:
+ [self toggleCategorySelectionForCurrentMethod.
- [self selectOriginalCategoryForCurrentMethod.
  self selectedMessageName: aSelector]]!

Item was added:
+ ----- Method: Browser>>toggleCategorySelectionForCurrentMethod (in category 'message category list') -----
+ toggleCategorySelectionForCurrentMethod
+ | methodCategory selectorName |
+ methodCategory := self categoryOfCurrentMethod.
+ selectorName := self selectedMessageName.
+ (methodCategory notNil and:
+ [ methodCategory ~= ClassOrganizer allCategory and: [ methodCategory ~= selectedMessageCategoryName ] ])
+ ifTrue:
+ [ selectedMessageCategoryName := methodCategory.
+ selectedMessageName := selectorName.
+ self changed: #messageCategorySelectionChanged.
+ self changed: #messageCategoryListIndex.
+ "update my selection"
+ self changed: #messageList.
+ self changed: #messageListIndex ]
+ ifFalse:
+ [ methodCategory = selectedMessageCategoryName ifTrue:
+ [ selectedMessageCategoryName := nil.
+ self
+ changed: #messageCategorySelectionChanged ;
+ changed: #messageCategoryListIndex ;
+ changed: #messageList ] ]!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tools-cmm.703.mcz

Chris Muller-3
Not sure if Lexicon needs any changes, its menu is broken right now,
and I didn't have time to investigate that.

On Thu, Jun 2, 2016 at 5:42 PM,  <[hidden email]> wrote:

> Chris Muller uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-cmm.703.mcz
>
> ==================== Summary ====================
>
> Name: Tools-cmm.703
> Author: cmm
> Time: 2 June 2016, 5:41:56.679756 pm
> UUID: 9e4c33b5-dae7-4884-9e46-22a4833bebd7
> Ancestors: Tools-eem.702
>
> - Corrected menu hot-key indication for 'show category' -- it's (Y) not (C).
> - Upgraded it to 'toggle category selection', which is really useful given that browsers spawned via Cmd+b come with category automatically selected.
>
> =============== Diff against Tools-eem.702 ===============
>
> Item was removed:
> - ----- Method: Browser>>selectOriginalCategoryForCurrentMethod (in category 'message category list') -----
> - selectOriginalCategoryForCurrentMethod
> -       "private - Select the message category for the current method.
> -
> -        Note:  This should only be called when somebody tries to save
> -        a method that they are modifying while ALL is selected.
> -
> -        Returns: true on success, false on failure."
> -       | aSymbol selectorName |
> -       aSymbol := self categoryOfCurrentMethod.
> -       selectorName := self selectedMessageName.
> -       (aSymbol notNil and: [aSymbol ~= ClassOrganizer allCategory])
> -               ifTrue:
> -                       [selectedMessageCategoryName := aSymbol.
> -                       selectedMessageName := selectorName.
> -                       self changed: #messageCategorySelectionChanged.
> -                       self changed: #messageCategoryListIndex.        "update my selection"
> -                       self changed: #messageList.
> -                       self changed: #messageListIndex.
> -                       ^ true].
> -       ^ false!
>
> Item was changed:
>   ----- Method: Browser>>shiftedMessageListMenu: (in category 'message functions') -----
>   shiftedMessageListMenu: aMenu
>         <messageListMenuShifted: true>
>         "Fill aMenu with the items appropriate when the shift key is held down"
>
>         aMenu addStayUpItem.
>         aMenu addList: #(
>                 ('toggle diffing (D)'                                           toggleDiffing)
>                 ('implementors of sent messages'                        browseAllMessages)
>                 -
>                 ('local senders of...'                                          browseLocalSendersOfMessages)
>                 ('local implementors of...'                             browseLocalImplementors)
>                 -
>                 ('spawn sub-protocol'                                   spawnProtocol)
>                 ('spawn full protocol'                                  spawnFullProtocol)
>                 -
>                 ('sample instance'                                              makeSampleInstance)
>                 ('inspect instances'                                            inspectInstances)
>                 ('inspect subinstances'                                 inspectSubInstances)).
>
>         self addExtraShiftedItemsTo: aMenu.
>         aMenu addList: #(
>                 -
>                 ('change category...'                                   changeCategory)).
>
>         self canShowMultipleMessageCategories ifTrue: [aMenu addList:
> +                #(('toggle category selection (Y)'                                             showHomeCategory))].
> -                #(('show category (C)'                                         showHomeCategory))].
>         aMenu addList: #(
>                 -
>                 ('change sets with this method'                 findMethodInChangeSets)
>                 ('revert to previous version'                           revertToPreviousVersion)
>                 ('remove from current change set'               removeFromCurrentChanges)
>                 ('revert & remove from changes'         revertAndForget)
>                 ('add to current change set'                            adoptMessageInCurrentChangeset)
>                 ('copy up or copy down...'                              copyUpOrCopyDown)).
>         ^ aMenu
>   !
>
> Item was changed:
>   ----- Method: Browser>>showHomeCategory (in category 'message category functions') -----
>   showHomeCategory
>         "Show the home category of the selected method.  This is only really useful if one is in a tool that supports the showing of categories.  Thus, it's good in browsers and hierarchy browsers but not in message-list browsers"
>
>         | aSelector |
>         self okToChange ifTrue:
>                 [(aSelector := self selectedMessageName) ifNotNil:
> +                       [self toggleCategorySelectionForCurrentMethod.
> -                       [self selectOriginalCategoryForCurrentMethod.
>                         self selectedMessageName: aSelector]]!
>
> Item was added:
> + ----- Method: Browser>>toggleCategorySelectionForCurrentMethod (in category 'message category list') -----
> + toggleCategorySelectionForCurrentMethod
> +       | methodCategory selectorName |
> +       methodCategory := self categoryOfCurrentMethod.
> +       selectorName := self selectedMessageName.
> +       (methodCategory notNil and:
> +               [ methodCategory ~= ClassOrganizer allCategory and: [ methodCategory ~= selectedMessageCategoryName ] ])
> +               ifTrue:
> +                       [ selectedMessageCategoryName := methodCategory.
> +                       selectedMessageName := selectorName.
> +                       self changed: #messageCategorySelectionChanged.
> +                       self changed: #messageCategoryListIndex.
> +                       "update my selection"
> +                       self changed: #messageList.
> +                       self changed: #messageListIndex ]
> +               ifFalse:
> +                       [ methodCategory = selectedMessageCategoryName ifTrue:
> +                               [ selectedMessageCategoryName := nil.
> +                               self
> +                                        changed: #messageCategorySelectionChanged ;
> +                                        changed: #messageCategoryListIndex ;
> +                                        changed: #messageList ] ]!
>
>