The Trunk: Tools-cmm.744.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tools-cmm.744.mcz

commits-2
Chris Muller uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-cmm.744.mcz

==================== Summary ====================

Name: Tools-cmm.744
Author: cmm
Time: 27 February 2017, 2:57:13.398974 pm
UUID: 494d1583-1885-43b9-93ed-9aff5b4c3b1e
Ancestors: Tools-ul.743

Allow unfiltering of the message list even when no method is selected, via the message category toggle key (Command+Y).

=============== Diff against Tools-ul.743 ===============

Item was changed:
  ----- Method: Browser>>showHomeCategory (in category 'message category functions') -----
  showHomeCategory
+ "Select the category of the currently-selected method.  If it is already selected, or if no method is selected, deselect it to unfilter the message list."
- "Show the home category of the selected method.  This is only really useful if one is in a tool that supports the showing of categories.  Thus, it's good in browsers and hierarchy browsers but not in message-list browsers"
-
- | aSelector |
  self okToChange ifTrue:
+ [ | aSelector | ((aSelector := self selectedMessageName) notNil or: [ selectedMessageCategoryName notNil ]) ifTrue:
+ [ aSelector
+ ifNil: [ self selectMessageCategoryNamed: nil ]
+ ifNotNil: [ self toggleCategorySelectionForCurrentMethod ].
+ self selectedMessageName: aSelector ] ]!
- [(aSelector := self selectedMessageName) ifNotNil:
- [self toggleCategorySelectionForCurrentMethod.
- self selectedMessageName: aSelector]]!

Item was changed:
  ----- Method: CodeHolder>>messageListKey:from: (in category 'message list menu') -----
  messageListKey: aChar from: view
  "Respond to a Command key.  I am a model with a code pane, and I also
  have a listView that has a list of methods.  The view knows how to get
  the list and selection."
  | sel class |
  aChar == $D ifTrue: [^ self toggleDiffing].
  sel := self selectedMessageName.
  aChar == $m ifTrue:  "These next two put up a type in if no message selected"
  [^ self useSelector: sel orGetSelectorAndSendQuery: #browseAllImplementorsOf: to: self ].
  aChar == $n ifTrue:
  [^ self useSelector: sel orGetSelectorAndSendQuery: #browseAllCallsOn: to: self ].
  aChar == $d ifTrue: [^ self removeMessageFromBrowser].
  "The following require a class selection"
  (class := self selectedClassOrMetaClass) ifNil: [^ self arrowKey: aChar from: view].
  aChar == $b ifTrue: [^ ToolSet browse: class selector: sel].
  aChar == $N ifTrue: [^ self browseClassRefs].
  aChar == $i ifTrue: [^ self methodHierarchy].
  aChar == $h ifTrue: [^ self classHierarchy].
  aChar == $p ifTrue: [^ self browseFullProtocol].
  aChar == $r ifTrue: [^ self browseVariableReferences].
  aChar == $a ifTrue: [^ self browseVariableAssignments].
+ (aChar == $Y and: [self canShowMultipleMessageCategories])
+ ifTrue: [^ self showHomeCategory].
  "The following require a method selection"
  sel ifNotNil:
  [aChar == $o ifTrue: [^ self fileOutMessage].
  aChar == $c ifTrue: [^ self copySelector].
  aChar == $v ifTrue: [^ self browseVersions].
  aChar == $x ifTrue: [^ self removeMessage].
+ aChar == $C ifTrue: [ self copyReference ]].
- aChar == $C ifTrue: [ self copyReference ].
- (aChar == $Y and: [self canShowMultipleMessageCategories])
- ifTrue: [^ self showHomeCategory]].
  ^ self arrowKey: aChar from: view!