The Trunk: Tools-eem.431.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tools-eem.431.mcz

commits-2
Eliot Miranda uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-eem.431.mcz

==================== Summary ====================

Name: Tools-eem.431
Author: eem
Time: 17 December 2012, 11:24:24.985 am
UUID: 29a0510c-1922-4513-baef-e31de47670c7
Ancestors: Tools-fbs.430

Fix findAMonticelloBrowser (shift-cmd-O) to find existing
MBs, not always create new ones.

=============== Diff against Tools-fbs.430 ===============

Item was changed:
  ----- Method: PasteUpMorph>>findAMonticelloBrowser (in category '*Tools') -----
  findAMonticelloBrowser
+ (Smalltalk classNamed: #MCWorkingCopyBrowser) ifNotNil:
+ [:mc|
+ self
+ findAWindowSatisfying: [:aWindow | aWindow model isMemberOf: mc]
+ orMakeOneUsing: [mc open]]!
- (Smalltalk classNamed: #MCWorkingCopyBrowser) ifNotNil: [ : mc | mc open ]!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tools-eem.431.mcz

Chris Muller-3
It already does that if you set Reuse Windows preference true.


On Mon, Dec 17, 2012 at 1:24 PM,  <[hidden email]> wrote:

> Eliot Miranda uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-eem.431.mcz
>
> ==================== Summary ====================
>
> Name: Tools-eem.431
> Author: eem
> Time: 17 December 2012, 11:24:24.985 am
> UUID: 29a0510c-1922-4513-baef-e31de47670c7
> Ancestors: Tools-fbs.430
>
> Fix findAMonticelloBrowser (shift-cmd-O) to find existing
> MBs, not always create new ones.
>
> =============== Diff against Tools-fbs.430 ===============
>
> Item was changed:
>   ----- Method: PasteUpMorph>>findAMonticelloBrowser (in category '*Tools') -----
>   findAMonticelloBrowser
> +       (Smalltalk classNamed: #MCWorkingCopyBrowser) ifNotNil:
> +               [:mc|
> +               self
> +                       findAWindowSatisfying: [:aWindow | aWindow model isMemberOf: mc]
> +                       orMakeOneUsing: [mc open]]!
> -       (Smalltalk classNamed: #MCWorkingCopyBrowser) ifNotNil: [ : mc | mc open ]!
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tools-eem.431.mcz

Eliot Miranda-2



On Mon, Dec 17, 2012 at 12:03 PM, Chris Muller <[hidden email]> wrote:
It already does that if you set Reuse Windows preference true.

OK.  But this way makes the code resemble all the other findA... methods.  So I would keep my version. 


On Mon, Dec 17, 2012 at 1:24 PM,  <[hidden email]> wrote:
> Eliot Miranda uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-eem.431.mcz
>
> ==================== Summary ====================
>
> Name: Tools-eem.431
> Author: eem
> Time: 17 December 2012, 11:24:24.985 am
> UUID: 29a0510c-1922-4513-baef-e31de47670c7
> Ancestors: Tools-fbs.430
>
> Fix findAMonticelloBrowser (shift-cmd-O) to find existing
> MBs, not always create new ones.
>
> =============== Diff against Tools-fbs.430 ===============
>
> Item was changed:
>   ----- Method: PasteUpMorph>>findAMonticelloBrowser (in category '*Tools') -----
>   findAMonticelloBrowser
> +       (Smalltalk classNamed: #MCWorkingCopyBrowser) ifNotNil:
> +               [:mc|
> +               self
> +                       findAWindowSatisfying: [:aWindow | aWindow model isMemberOf: mc]
> +                       orMakeOneUsing: [mc open]]!
> -       (Smalltalk classNamed: #MCWorkingCopyBrowser) ifNotNil: [ : mc | mc open ]!
>
>




--
best,
Eliot