The Trunk: Tools-fbs.223.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tools-fbs.223.mcz

commits-2
Andreas Raab uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-fbs.223.mcz

==================== Summary ====================

Name: Tools-fbs.223
Author: fbs
Time: 3 April 2010, 9:02:45.34 pm
UUID: 89bca4a6-2d01-be41-bfe7-379f1bb06371
Ancestors: Tools-bp.220

Update Hierarchy Browser with fixed button height.

=============== Diff against Tools-bp.220 ===============

Item was changed:
  ----- Method: Browser>>switchesFrame: (in category 'initialize-release') -----
  switchesFrame: bottomFraction
+ ^self switchesFrame: bottomFraction fromLeft: 0.25 width: 0.25.!
- ^LayoutFrame new
- leftFraction: 0.25 offset: 0;
- topFraction: bottomFraction offset: self buttonHeight negated - 4;
- rightFraction: 0.5 offset: 0;
- bottomFraction: bottomFraction offset: 0!

Item was added:
+ ----- Method: Browser>>classListFrame:fromLeft:width: (in category 'initialize-release') -----
+ classListFrame: bottomFraction fromLeft: leftFraction width: rightFraction
+ ^LayoutFrame new
+ leftFraction: leftFraction offset: 0;
+ topFraction: 0 offset: 0;
+ rightFraction: (leftFraction + rightFraction) offset: 0;
+ bottomFraction: bottomFraction offset: self buttonHeight negated - 3!

Item was changed:
  ----- Method: Browser>>classListFrame: (in category 'initialize-release') -----
  classListFrame: bottomFraction
+ ^self classListFrame: bottomFraction fromLeft: 0.25 width: 0.25.!
- ^LayoutFrame new
- leftFraction: 0.25 offset: 0;
- topFraction: 0 offset: 0;
- rightFraction: 0.5 offset: 0;
- bottomFraction: bottomFraction offset: self buttonHeight negated - 3!

Item was changed:
  ----- Method: Browser>>openSystemCatEditString: (in category 'initialize-release') -----
  openSystemCatEditString: aString
  "Create a pluggable version of all the views for a Browser, including views and controllers.  The top list view is of the currently selected system class category--a single item list."
  "Example:
  Browser new browseAllClasses.
  "
  | builder max |
  builder := ToolBuilder default.
  max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4].
  ^self buildWindowWith: builder specs: {
  (0@0 corner: 1.0@0.08) -> [self buildSystemCatListSingletonWith: builder].
+ (self classListFrame: max fromLeft: 0 width: 0.333) -> [self buildClassListWith: builder].
+ (self switchesFrame: max fromLeft: 0 width: 0.333) -> [self buildSwitchesWith: builder].
- (0.0@0.08 corner: 0.333@(max-0.1)) -> [self buildClassListWith: builder].
- (0.0@(max-0.1) corner: 0.333@max) -> [self buildSwitchesWith: builder].
  (0.333@0.08 corner: 0.666@max) -> [self buildMessageCategoryListWith: builder].
  (0.666@0.08 corner: 1@max) -> [self buildMessageListWith: builder].
  (0@max corner: 1@1) -> [self buildCodePaneWith: builder].
  }!

Item was added:
+ ----- Method: Browser>>switchesFrame:fromLeft:width: (in category 'initialize-release') -----
+ switchesFrame: bottomFraction fromLeft: leftFraction width: rightFraction
+ ^LayoutFrame new
+ leftFraction: leftFraction offset: 0;
+ topFraction: bottomFraction offset: self buttonHeight negated - 4;
+ rightFraction: (leftFraction + rightFraction) offset: 0;
+ bottomFraction: bottomFraction offset: 0!


bpi
Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tools-fbs.223.mcz

bpi
This seems to have broken the layout of the Hierarchy Browser. See http://bugs.squeak.org/view.php?id=7494

Cheers,
Bernhard

Am 04.04.2010 um 07:08 schrieb [hidden email]:

> Andreas Raab uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-fbs.223.mcz
>
> ==================== Summary ====================
>
> Name: Tools-fbs.223
> Author: fbs
> Time: 3 April 2010, 9:02:45.34 pm
> UUID: 89bca4a6-2d01-be41-bfe7-379f1bb06371
> Ancestors: Tools-bp.220
>
> Update Hierarchy Browser with fixed button height.
>
> =============== Diff against Tools-bp.220 ===============
>
> Item was changed:
>  ----- Method: Browser>>switchesFrame: (in category 'initialize-release') -----
>  switchesFrame: bottomFraction
> + ^self switchesFrame: bottomFraction fromLeft: 0.25 width: 0.25.!
> - ^LayoutFrame new
> - leftFraction: 0.25 offset: 0;
> - topFraction: bottomFraction offset: self buttonHeight negated - 4;
> - rightFraction: 0.5 offset: 0;
> - bottomFraction: bottomFraction offset: 0!
>
> Item was added:
> + ----- Method: Browser>>classListFrame:fromLeft:width: (in category 'initialize-release') -----
> + classListFrame: bottomFraction fromLeft: leftFraction width: rightFraction
> + ^LayoutFrame new
> + leftFraction: leftFraction offset: 0;
> + topFraction: 0 offset: 0;
> + rightFraction: (leftFraction + rightFraction) offset: 0;
> + bottomFraction: bottomFraction offset: self buttonHeight negated - 3!
>
> Item was changed:
>  ----- Method: Browser>>classListFrame: (in category 'initialize-release') -----
>  classListFrame: bottomFraction
> + ^self classListFrame: bottomFraction fromLeft: 0.25 width: 0.25.!
> - ^LayoutFrame new
> - leftFraction: 0.25 offset: 0;
> - topFraction: 0 offset: 0;
> - rightFraction: 0.5 offset: 0;
> - bottomFraction: bottomFraction offset: self buttonHeight negated - 3!
>
> Item was changed:
>  ----- Method: Browser>>openSystemCatEditString: (in category 'initialize-release') -----
>  openSystemCatEditString: aString
>   "Create a pluggable version of all the views for a Browser, including views and controllers.  The top list view is of the currently selected system class category--a single item list."
>   "Example:
>   Browser new browseAllClasses.
>   "
>   | builder max |
>   builder := ToolBuilder default.
>   max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4].
>   ^self buildWindowWith: builder specs: {
>   (0@0 corner: 1.0@0.08) -> [self buildSystemCatListSingletonWith: builder].
> + (self classListFrame: max fromLeft: 0 width: 0.333) -> [self buildClassListWith: builder].
> + (self switchesFrame: max fromLeft: 0 width: 0.333) -> [self buildSwitchesWith: builder].
> - (0.0@0.08 corner: 0.333@(max-0.1)) -> [self buildClassListWith: builder].
> - (0.0@(max-0.1) corner: 0.333@max) -> [self buildSwitchesWith: builder].
>   (0.333@0.08 corner: 0.666@max) -> [self buildMessageCategoryListWith: builder].
>   (0.666@0.08 corner: 1@max) -> [self buildMessageListWith: builder].
>   (0@max corner: 1@1) -> [self buildCodePaneWith: builder].
>   }!
>
> Item was added:
> + ----- Method: Browser>>switchesFrame:fromLeft:width: (in category 'initialize-release') -----
> + switchesFrame: bottomFraction fromLeft: leftFraction width: rightFraction
> + ^LayoutFrame new
> + leftFraction: leftFraction offset: 0;
> + topFraction: bottomFraction offset: self buttonHeight negated - 4;
> + rightFraction: (leftFraction + rightFraction) offset: 0;
> + bottomFraction: bottomFraction offset: 0!
>
>


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tools-fbs.223.mcz

Frank Shearar
Ah yes, I see: the top of the left-most pane slides under the topmost pane.

I'll fix it today. (And sorry!)

frank

Bernhard Pieber wrote:

> This seems to have broken the layout of the Hierarchy Browser. See http://bugs.squeak.org/view.php?id=7494
>
> Cheers,
> Bernhard
>
> Am 04.04.2010 um 07:08 schrieb [hidden email]:
>
>> Andreas Raab uploaded a new version of Tools to project The Trunk:
>> http://source.squeak.org/trunk/Tools-fbs.223.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tools-fbs.223
>> Author: fbs
>> Time: 3 April 2010, 9:02:45.34 pm
>> UUID: 89bca4a6-2d01-be41-bfe7-379f1bb06371
>> Ancestors: Tools-bp.220
>>
>> Update Hierarchy Browser with fixed button height.
>>
>> =============== Diff against Tools-bp.220 ===============
>>
>> Item was changed:
>>  ----- Method: Browser>>switchesFrame: (in category 'initialize-release') -----
>>  switchesFrame: bottomFraction
>> + ^self switchesFrame: bottomFraction fromLeft: 0.25 width: 0.25.!
>> - ^LayoutFrame new
>> - leftFraction: 0.25 offset: 0;
>> - topFraction: bottomFraction offset: self buttonHeight negated - 4;
>> - rightFraction: 0.5 offset: 0;
>> - bottomFraction: bottomFraction offset: 0!
>>
>> Item was added:
>> + ----- Method: Browser>>classListFrame:fromLeft:width: (in category 'initialize-release') -----
>> + classListFrame: bottomFraction fromLeft: leftFraction width: rightFraction
>> + ^LayoutFrame new
>> + leftFraction: leftFraction offset: 0;
>> + topFraction: 0 offset: 0;
>> + rightFraction: (leftFraction + rightFraction) offset: 0;
>> + bottomFraction: bottomFraction offset: self buttonHeight negated - 3!
>>
>> Item was changed:
>>  ----- Method: Browser>>classListFrame: (in category 'initialize-release') -----
>>  classListFrame: bottomFraction
>> + ^self classListFrame: bottomFraction fromLeft: 0.25 width: 0.25.!
>> - ^LayoutFrame new
>> - leftFraction: 0.25 offset: 0;
>> - topFraction: 0 offset: 0;
>> - rightFraction: 0.5 offset: 0;
>> - bottomFraction: bottomFraction offset: self buttonHeight negated - 3!
>>
>> Item was changed:
>>  ----- Method: Browser>>openSystemCatEditString: (in category 'initialize-release') -----
>>  openSystemCatEditString: aString
>>   "Create a pluggable version of all the views for a Browser, including views and controllers.  The top list view is of the currently selected system class category--a single item list."
>>   "Example:
>>   Browser new browseAllClasses.
>>   "
>>   | builder max |
>>   builder := ToolBuilder default.
>>   max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4].
>>   ^self buildWindowWith: builder specs: {
>>   (0@0 corner: 1.0@0.08) -> [self buildSystemCatListSingletonWith: builder].
>> + (self classListFrame: max fromLeft: 0 width: 0.333) -> [self buildClassListWith: builder].
>> + (self switchesFrame: max fromLeft: 0 width: 0.333) -> [self buildSwitchesWith: builder].
>> - (0.0@0.08 corner: 0.333@(max-0.1)) -> [self buildClassListWith: builder].
>> - (0.0@(max-0.1) corner: 0.333@max) -> [self buildSwitchesWith: builder].
>>   (0.333@0.08 corner: 0.666@max) -> [self buildMessageCategoryListWith: builder].
>>   (0.666@0.08 corner: 1@max) -> [self buildMessageListWith: builder].
>>   (0@max corner: 1@1) -> [self buildCodePaneWith: builder].
>>   }!
>>
>> Item was added:
>> + ----- Method: Browser>>switchesFrame:fromLeft:width: (in category 'initialize-release') -----
>> + switchesFrame: bottomFraction fromLeft: leftFraction width: rightFraction
>> + ^LayoutFrame new
>> + leftFraction: leftFraction offset: 0;
>> + topFraction: bottomFraction offset: self buttonHeight negated - 4;
>> + rightFraction: (leftFraction + rightFraction) offset: 0;
>> + bottomFraction: bottomFraction offset: 0!
>>
>>
>
>
>
>