The Trunk: Tools-fbs.413.mcz

Frank Shearar uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-fbs.413.mcz

==================== Summary ====================

Name: Tools-fbs.413
Author: fbs
Time: 11 June 2012, 8:45:35.501 pm
UUID: 04131505-191d-4f46-ba9e-64195d2ed007
Ancestors: Tools-eem.412

#showComment is identical to #showingDocumentation, and only has 1 sender, compared to #showingDocumentation's 9 senders. Both these messages belong to CodeHolder's internal protocols (so only it and its descendants use these methods).

=============== Diff against Tools-eem.412 ===============

Item was changed:
  ----- Method: CodeHolder>>selectedMessage (in category 'message list') -----
  selectedMessage
  "Answer a copy of the source code for the selected message.  This generic version is probably actually never reached, since every subclass probably reimplements and does not send to super.  In time, ideally, most, or all, reimplementors would vanish and all would defer instead to a universal version right here.  Everything in good time."
 
  | class selector method |
  contents ifNotNil: [^ contents copy].
 
  self showingDecompile ifTrue:[^ self decompiledSourceIntoContents].
 
  class := self selectedClassOrMetaClass.
  (class isNil or: [(selector := self selectedMessageName) isNil]) ifTrue: [^ ''].
  method := class compiledMethodAt: selector ifAbsent: [^ '']. "method deleted while in another project"
  currentCompiledMethod := method.
 
+ ^ contents := (self showingDocumentation
- ^ contents := (self showComment
  ifFalse: [self sourceStringPrettifiedAndDiffed]
  ifTrue: [ self commentContents])
  copy asText makeSelectorBoldIn: class!

Item was removed:
- ----- Method: CodeHolder>>showComment (in category 'what to show') -----
- showComment
- "Answer whether the receiver should show documentation rather than, say, source code"
-
- ^ self contentsSymbol == #documentation
- !

On 11 June 2012 20:45,  <[hidden email]> wrote:
I suspect I haven't followed the full procedure for committing to
Trunk. What should I do with the Tools-fbs.413 in the Inbox? Do we
delete those, or...?

frank

On Mon, 18 Jun 2012, Frank Shearar wrote:

When I commit to the Inbox and it's time to push the package to the Trunk,
then I use the web interface to move the package from one repo to the
other. Since this package is already in the Trunk, just move it to the
Threated Inbox via the web interface. There are dedicated buttons for
these operations thanks to Bert.


Levente

>
> frank
>
>

On 18 June 2012 13:52, Levente Uzonyi <[hidden email]> wrote:
Great, thanks Levente! (And Bert!)

frank

> Levente
>
>>
>> frank
>>
>>
>

On 18 June 2012 14:19, Frank Shearar <[hidden email]> wrote:
I was too fast on the send button there. For things that _aren't_
going into Trunk - Tools-fbs.411, for instance - we still move those
guys into TreatedInbox because they've still been Treated? (And ditto
for _rejected_ submissions, I would imagine.) Since Treated is
"Packages from the Inbox that are dealt with are moved here."

frank

> frank
>
>> Levente
>>
>>>
>>> frank
>>>
>>>
>>