Frank Shearar uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-fbs.504.mcz ==================== Summary ==================== Name: Tools-fbs.504 Author: fbs Time: 30 November 2013, 11:05:52.941 pm UUID: 1591d949-a7a9-3148-8b42-215f7067e7e0 Ancestors: Tools-cmm.503 Move #browserShowsPackagePane to the new pragma style preference. =============== Diff against Tools-cmm.503 =============== Item was added: + ----- Method: SystemBrowser class>>browserShowsPackagePane (in category 'preferences') ----- + browserShowsPackagePane + <preference: 'Browser shows package pane' category: 'browsing' description: 'If true, then the various ''browse full'' and ''browse it'' commands (usually invoked via cmd-b) will open a Package Browser rather than a System Browser. The Package Browser includes a package pane which groups system categories into packages based on the initial portion of their category name.' type: #Boolean> + ^ SystemNavigation default browserClass == PackagePaneBrowser.! Item was added: + ----- Method: SystemBrowser class>>browserShowsPackagePane: (in category 'preferences') ----- + browserShowsPackagePane: aBoolean + | theOtherOne | + self registeredClasses size = 2 + ifTrue: [theOtherOne := (self registeredClasses copyWithout: PackagePaneBrowser) first] + ifFalse: [theOtherOne := nil]. + aBoolean + ifTrue: [self default: PackagePaneBrowser] + ifFalse: [self default: theOtherOne]. + SystemNavigation default browserClass: self default.! Item was removed: - ----- Method: SystemBrowser class>>initialize (in category 'class initialization') ----- - initialize - | pref | - pref := Preferences preferenceAt: #browserShowsPackagePane. - Preferences - addPreference: #browserShowsPackagePane - categories: pref categoryList - default: pref defaultValue - balloonHelp: pref helpString - projectLocal: pref localToProject - changeInformee: self - changeSelector: #packagePanePreferenceChanged - ! Item was removed: - ----- Method: SystemBrowser class>>packagePanePreferenceChanged (in category 'events') ----- - packagePanePreferenceChanged - | theOtherOne | - self registeredClasses size = 2 - ifTrue: [theOtherOne := (self registeredClasses copyWithout: PackagePaneBrowser) first] - ifFalse: [theOtherOne := nil]. - (Preferences valueOfFlag: #browserShowsPackagePane ifAbsent: [false]) - ifTrue: [self default: PackagePaneBrowser] - ifFalse: [self default: theOtherOne]. - SystemNavigation default browserClass: self default.! Item was removed: - ----- Method: SystemBrowser class>>unload (in category 'initialize-release') ----- - unload - | pref | - pref := Preferences preferenceAt: #browserShowsPackagePane. - Preferences - addPreference: #browserShowsPackagePane - categories: pref categoryList - default: pref defaultValue - balloonHelp: pref helpString - projectLocal: pref localToProject - changeInformee: nil - changeSelector: nil - ! Item was changed: + (PackageInfo named: 'Tools') postscript: 'Preferences removePreference: #browserShowsPackagePane'! - (PackageInfo named: 'Tools') postscript: 'Workspace allSubInstancesDo: [ :each | (each instVarNamed: #bindings) ifNil: [ each initializeBindings ] ]. - World initializeDesktopCommandKeySelectors. - RecentMessages startUp.'! |
This doesn't preserve the preference. I'll push a fix tonight, unless someone beats me to it. Er, I guess another config map's required to skip over the removal? Or should I just delete the commit and push a better one?
frank On 01 Dec 2013, at 10:03, [hidden email] wrote: > Frank Shearar uploaded a new version of Tools to project The Trunk: > http://source.squeak.org/trunk/Tools-fbs.504.mcz > > ==================== Summary ==================== > > Name: Tools-fbs.504 > Author: fbs > Time: 30 November 2013, 11:05:52.941 pm > UUID: 1591d949-a7a9-3148-8b42-215f7067e7e0 > Ancestors: Tools-cmm.503 > > Move #browserShowsPackagePane to the new pragma style preference. > > =============== Diff against Tools-cmm.503 =============== > > Item was added: > + ----- Method: SystemBrowser class>>browserShowsPackagePane (in category 'preferences') ----- > + browserShowsPackagePane > + <preference: 'Browser shows package pane' category: 'browsing' description: 'If true, then the various ''browse full'' and ''browse it'' commands (usually invoked via cmd-b) will open a Package Browser rather than a System Browser. The Package Browser includes a package pane which groups system categories into packages based on the initial portion of their category name.' type: #Boolean> > + ^ SystemNavigation default browserClass == PackagePaneBrowser.! > > Item was added: > + ----- Method: SystemBrowser class>>browserShowsPackagePane: (in category 'preferences') ----- > + browserShowsPackagePane: aBoolean > + | theOtherOne | > + self registeredClasses size = 2 > + ifTrue: [theOtherOne := (self registeredClasses copyWithout: PackagePaneBrowser) first] > + ifFalse: [theOtherOne := nil]. > + aBoolean > + ifTrue: [self default: PackagePaneBrowser] > + ifFalse: [self default: theOtherOne]. > + SystemNavigation default browserClass: self default.! > > Item was removed: > - ----- Method: SystemBrowser class>>initialize (in category 'class initialization') ----- > - initialize > - | pref | > - pref := Preferences preferenceAt: #browserShowsPackagePane. > - Preferences > - addPreference: #browserShowsPackagePane > - categories: pref categoryList > - default: pref defaultValue > - balloonHelp: pref helpString > - projectLocal: pref localToProject > - changeInformee: self > - changeSelector: #packagePanePreferenceChanged > - ! > > Item was removed: > - ----- Method: SystemBrowser class>>packagePanePreferenceChanged (in category 'events') ----- > - packagePanePreferenceChanged > - | theOtherOne | > - self registeredClasses size = 2 > - ifTrue: [theOtherOne := (self registeredClasses copyWithout: PackagePaneBrowser) first] > - ifFalse: [theOtherOne := nil]. > - (Preferences valueOfFlag: #browserShowsPackagePane ifAbsent: [false]) > - ifTrue: [self default: PackagePaneBrowser] > - ifFalse: [self default: theOtherOne]. > - SystemNavigation default browserClass: self default.! > > Item was removed: > - ----- Method: SystemBrowser class>>unload (in category 'initialize-release') ----- > - unload > - | pref | > - pref := Preferences preferenceAt: #browserShowsPackagePane. > - Preferences > - addPreference: #browserShowsPackagePane > - categories: pref categoryList > - default: pref defaultValue > - balloonHelp: pref helpString > - projectLocal: pref localToProject > - changeInformee: nil > - changeSelector: nil > - ! > > Item was changed: > + (PackageInfo named: 'Tools') postscript: 'Preferences removePreference: #browserShowsPackagePane'! > - (PackageInfo named: 'Tools') postscript: 'Workspace allSubInstancesDo: [ :each | (each instVarNamed: #bindings) ifNil: [ each initializeBindings ] ]. > - World initializeDesktopCommandKeySelectors. > - RecentMessages startUp.'! > > |
On 1 December 2013 10:06, Frank Shearar <[hidden email]> wrote:
> This doesn't preserve the preference. I'll push a fix tonight, unless someone beats me to it. Er, I guess another config map's required to skip over the removal? Or should I just delete the commit and push a better one? > I'm issuing a Tools-fbs.505 and will delete 504. 505's ancestor is 503. frank |
On 1 December 2013 22:58, Frank Shearar <[hidden email]> wrote:
> On 1 December 2013 10:06, Frank Shearar <[hidden email]> wrote: >> This doesn't preserve the preference. I'll push a fix tonight, unless someone beats me to it. Er, I guess another config map's required to skip over the removal? Or should I just delete the commit and push a better one? >> > I'm issuing a Tools-fbs.505 and will delete 504. 505's ancestor is 503. Done. frank |
Free forum by Nabble | Edit this page |