The Trunk: Tools-kfr.605.mcz

On 26.04.2015, at 17:36, [hidden email] wrote:

> Karl Ramberg uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-kfr.605.mcz
>
> ==================== Summary ====================
>
> Name: Tools-kfr.605
> Author: kfr
> Time: 26 April 2015, 7:35:58.715 pm
> UUID: 6b04a91f-7446-bd4f-979c-f445bfb1061b
> Ancestors: Tools-kfr.604
>
> Top pane in FileList had too little room
>
> =============== Diff against Tools-kfr.604 ===============
>
> Item was changed:
>  ----- Method: FileList>>buildWith: (in category 'toolbuilder') -----
>  buildWith: builder
>       "FileList open"
>       | windowSpec window |
>       windowSpec :=   self buildWindowWith: builder specs: {
> +             (0@0 corner: 1@0.1) -> [self buildPatternInputWith: builder].

I wouldn't like an input pane change height when I change the window height,
so probably an offset would do fine here?


> +             (0.25@0.1 corner: 1@0.5) -> [self buildFileListWith: builder].
> +             (0@0.1 corner: 0.25@1) -> [self buildDirectoryTreeWith: builder].
> -             (0@0 corner: 1@0.06) -> [self buildPatternInputWith: builder].
> -             (0.25@0.06 corner: 1@0.5) -> [self buildFileListWith: builder].
> -             (0@0.06 corner: 0.25@1) -> [self buildDirectoryTreeWith: builder].
>               (0.25@0.5 corner: 1@1) -> [self buildContentPaneWith: builder].
>       }.
>       window := builder build: windowSpec.
>       self changed: #selectedPath.
>       ^window!
>
>


Best regards
        -Tobias

Hi Karl
On 26.04.2015, at 19:55, karl ramberg <[hidden email]> wrote:

> Hi,
> Text in pane was obscured when FileList opened. It would resize when the whole window was resized. But it looked ugly like it was, so I changed it.
>

Don't get me wrong, you improved it. This just sparked another possible
improvement in my mind :)

Best regards
        -Tobias

> Karl
>
> On Sun, Apr 26, 2015 at 7:41 PM, Tobias Pape <[hidden email]> wrote:
>
> On 26.04.2015, at 17:36, [hidden email] wrote:
>
> > Karl Ramberg uploaded a new version of Tools to project The Trunk:
> > http://source.squeak.org/trunk/Tools-kfr.605.mcz
> >
> > ==================== Summary ====================
> >
> > Name: Tools-kfr.605
> > Author: kfr
> > Time: 26 April 2015, 7:35:58.715 pm
> > UUID: 6b04a91f-7446-bd4f-979c-f445bfb1061b
> > Ancestors: Tools-kfr.604
> >
> > Top pane in FileList had too little room
> >
> > =============== Diff against Tools-kfr.604 ===============
> >
> > Item was changed: