The Trunk: Tools-mt.1049.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tools-mt.1049.mcz

commits-2
Marcel Taeumel uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-mt.1049.mcz

==================== Summary ====================

Name: Tools-mt.1049
Author: mt
Time: 29 April 2021, 7:18:34.478575 pm
UUID: 65b976d3-5eaf-9247-8c06-675a97ef6890
Ancestors: Tools-mt.1048

In the ChangeSorter, don't be too harsh on the selection update when removing s selector from the change-set. Try to match the implementation-style of #forgetClass nearby.

=============== Diff against Tools-mt.1048 ===============

Item was changed:
  ----- Method: ChangeSorter>>forget (in category 'message list') -----
  forget
  "Drop this method from the changeSet"
 
+ | className index messageList |
  self okToChange ifFalse: [^ self].
+ currentSelector ifNil: [^ self].
+ className := self currentClassName.
+ index := self messageList indexOf: currentSelector.
+ myChangeSet
+ removeSelectorChanges: self selectedMessageName
+ class: self selectedClassOrMetaClass.
+ self changed: #classList.
+ self changed: #messageList.
+ (self classList includes: className)
+ ifFalse: ["Last entry removed"
+ self currentClassName: nil]
+ ifTrue: [
+ messageList := self messageList.
+ self currentSelector: (messageList isEmpty ifFalse:
+ [messageList at: (index min: messageList size)])].!
- currentSelector ifNotNil: [
- myChangeSet removeSelectorChanges: self selectedMessageName
- class: self selectedClassOrMetaClass.
- currentSelector := nil.
- self showChangeSet: myChangeSet]!