The Trunk: Tools-mt.594.mcz

Marcel Taeumel uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-mt.594.mcz

==================== Summary ====================

Name: Tools-mt.594
Author: mt
Time: 16 April 2015, 1:28:43.152 pm
UUID: aaea490f-cb19-5144-97c9-11795c2994da
Ancestors: Tools-mt.593

Updated proportions in hierarchy browser and file contents browser to avoid visual glitches in the worst case, which is:

- menu button visible in scroll bar
- arrow buttons visible in scroll bar
- horizontal scroll bar may be visible in pane and no retractable scroll bars enabled

Other configurations imply smaller minimal extents for scroll bars and scroll panes and thus fewer visual glitches in smaller windows.

Note: We still should -- someday -- update the ProportialLayout to stop shrinking windows below their minimum extent.

=============== Diff against Tools-mt.593 ===============

Item was changed:
  ----- Method: Browser>>openSystemCatEditString: (in category 'initialize-release') -----
  openSystemCatEditString: aString
  "Create a pluggable version of all the views for a Browser, including views and controllers.  The top list view is of the currently selected system class category--a single item list."
  "Example:
  Browser new browseAllClasses.
  "
  | builder catPaneHeight max |
+ catPaneHeight := 0.16.
- catPaneHeight := 0.08.
  builder := ToolBuilder default.
  max := self wantsOptionalButtons ifTrue:[0.32 + catPaneHeight] ifFalse:[0.4 + catPaneHeight].
  ^self buildWindowWith: builder specs: {
+ (0@0 corner: 1.0@catPaneHeight) -> [self buildSystemCatListSingletonWith: builder].
- (0@0 corner: 1.0@0.08) -> [self buildSystemCatListSingletonWith: builder].
  (self classListFrame: max fromTop: catPaneHeight fromLeft: 0 width: 0.333) -> [self buildClassListWith: builder].
  (self switchesFrame: max fromLeft: 0 width: 0.333) -> [self buildSwitchesWith: builder].
+ (0.333@catPaneHeight corner: 0.666@max) -> [self buildMessageCategoryListWith: builder].
+ (0.666@catPaneHeight corner: 1@max) -> [self buildMessageListWith: builder].
- (0.333@0.08 corner: 0.666@max) -> [self buildMessageCategoryListWith: builder].
- (0.666@0.08 corner: 1@max) -> [self buildMessageListWith: builder].
  (0@max corner: 1@1) -> [self buildCodePaneWith: builder].
  }!

Item was changed:
  ----- Method: FileContentsBrowser>>buildInfoViewWith: (in category 'toolbuilder') -----
  buildInfoViewWith: builder
  | textSpec |
+ textSpec := builder pluggableInputFieldSpec new.
- textSpec := builder pluggableTextSpec new.
  textSpec
  model: self;
  getText: #infoViewContents.
  ^textSpec!

Item was changed:
  ----- Method: FileContentsBrowser>>buildWith: (in category 'toolbuilder') -----
  buildWith: builder
  "Create a pluggable version of all the views for a Browser, including views and controllers."
+ | windowSpec buttonHeight |
+ buttonHeight := Preferences standardButtonFont height * 5/2.
- | windowSpec |
  self packages size = 1 ifTrue:[
  self systemCategoryListIndex: 1.
  windowSpec := self buildWindowWith: builder specs: {
+ (0@0 corner: 1.0@0.16) -> [self buildSystemCatListSingletonWith: builder].
+ (LayoutFrame
+ fractions: (0@0.16 corner: 0.34@0.45)
+ offsets: (0@0 corner: 0@ buttonHeight negated)) -> [self buildClassListWith: builder].
+ (LayoutFrame
+ fractions: (0@0.45 corner: 0.34@0.45)
+ offsets: (0@ buttonHeight negated corner: 0@0)) -> [self buildSwitchesWith: builder].
+ (0.34@0.16 corner: 0.67@0.45) -> [self buildMessageCategoryListWith: builder].
+ (0.67@0.16 corner: 1.0@0.45) -> [self buildMessageListWith: builder].
+ (0.0@0.45 corner: 1.0@0.9) -> [self buildCodePaneWith: builder].
- (0@0 corner: 1.0@0.06) -> [self buildSystemCatListSingletonWith: builder].
- (0@0.06 corner: 0.34@0.24) -> [self buildClassListWith: builder].
- (0@0.24 corner: 0.34@0.34) -> [self buildSwitchesWith: builder].
- (0.34@0.06 corner: 0.67@0.34) -> [self buildMessageCategoryListWith: builder].
- (0.67@0.06 corner: 1.0@0.34) -> [self buildMessageListWith: builder].
- (0.0@0.34 corner: 1.0@0.9) -> [self buildCodePaneWith: builder].
  (0.0@0.9 corner: 1.0@1.0) -> [self buildInfoViewWith: builder].
  }
  ] ifFalse:[
  windowSpec := self buildWindowWith: builder specs: {
  (0@0 corner: 0.25@0.4) -> [self buildSystemCategoryListWith: builder].
+ (LayoutFrame
+ fractions: (0.25@0 corner: 0.5@0.4)
+ offsets: (0@0 corner: 0@ buttonHeight negated)) -> [self buildClassListWith: builder].
+ (LayoutFrame
+ fractions: (0.25@0.4 corner: 0.5@0.4)
+ offsets: (0@ buttonHeight negated corner: 0@0)) -> [self buildSwitchesWith: builder].
- (0.25@0 corner: 0.5@0.3) -> [self buildClassListWith: builder].
- (0.25@0.3 corner: 0.5@0.4) -> [self buildSwitchesWith: builder].
  (0.5@0 corner: 0.75@0.4) -> [self buildMessageCategoryListWith: builder].
  (0.75@0 corner: 1.0@0.4) -> [self buildMessageListWith: builder].
  (0.0@0.4 corner: 1.0@0.9) -> [self buildCodePaneWith: builder].
  (0.0@0.9 corner: 1.0@1.0) -> [self buildInfoViewWith: builder].
  }
  ].
  ^ windowSpec
  !