The Trunk: Tools-mt.715.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tools-mt.715.mcz

commits-2
Marcel Taeumel uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-mt.715.mcz

==================== Summary ====================

Name: Tools-mt.715
Author: mt
Time: 12 August 2016, 10:06:15.482343 am
UUID: 8f32b216-0cc1-b14d-93e4-8eaa57fac339
Ancestors: Tools-mt.714

Fixes serious bug with balloon-help for message lists, which occured in the FileContentsBrowser with #balloonHelpInMessageLists preference enabled.

=============== Diff against Tools-mt.714 ===============

Item was changed:
  ----- Method: Browser>>messageHelpFor: (in category 'message list') -----
  messageHelpFor: aSelector
  "Show the first n lines of the sources code of the message behind aSelector."
 
  | source formatted iconHelp |
  Preferences balloonHelpInMessageLists ifFalse: [^ nil].
 
+ source := self selectedClassOrMetaClass sourceCodeAt: aSelector ifAbsent: [^ nil].
- source := (self selectedClassOrMetaClass compiledMethodAt: aSelector ifAbsent: [^ nil]) getSource.
  source lineCount > 5 ifTrue: [
  | sourceLines |
  sourceLines := (source asString lines copyFrom: 1 to: 5) asOrderedCollection.
  sourceLines add: ' [...]'.
  source := sourceLines joinSeparatedBy: Character cr].
 
 
  formatted := (Smalltalk classNamed: #SHTextStylerST80)
  ifNil: [ source asText ]
  ifNotNil: [ :SHTextStylerST80 |
  SHTextStylerST80 new
  classOrMetaClass: self selectedClassOrMetaClass;
  styledTextFor: source asText ].
  iconHelp := (self messageIconHelpFor: aSelector) ifNotEmpty: [:t |
  t , Character cr, Character cr].
  ^ iconHelp asText
  append: formatted;
  yourself!