The Trunk: Tools-mt.877.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tools-mt.877.mcz

commits-2
Marcel Taeumel uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-mt.877.mcz

==================== Summary ====================

Name: Tools-mt.877
Author: mt
Time: 14 August 2019, 3:42:42.929512 pm
UUID: c122e8e1-1a50-2b40-9abf-c2443ce59534
Ancestors: Tools-mt.876

Restore message icons in browsers. Same reason as the two commits before.

I am *very* sorry for the noise. :-(

=============== Diff against Tools-mt.876 ===============

Item was changed:
  ----- Method: Browser>>messageHelpAt: (in category 'message list') -----
  messageHelpAt: anIndex
  "Show the first n lines of the sources code of the selected message."
 
  | iconHelp selector method |
  Preferences balloonHelpInMessageLists ifFalse: [^ nil].
  self messageList size < anIndex ifTrue: [^ nil].
 
  "Items in the message list can be formatted texts."
+ self flag: #refactor.
  selector := Symbol lookup: (self messageList at: anIndex) asString.
  selector ifNil: [^ nil].
 
  method := self selectedClassOrMetaClass compiledMethodAt: selector ifAbsent: [^ nil].
  iconHelp := (self messageIconHelpFor: method selector) ifNotEmpty: [:t |
  t , Character cr, Character cr].
 
  ^ iconHelp asText
  append: (self messageHelpForMethod: method);
  yourself!

Item was changed:
  ----- Method: Browser>>messageIconAt: (in category 'message list') -----
  messageIconAt: anIndex
 
+ | selector |
  self class showMessageIcons ifFalse: [^ nil].
+
+ self flag: #refactor.
+ selector := Symbol lookup: (self messageList at: anIndex ifAbsent: [^nil]) asString.
+ selector ifNil: [^ self].
+
+ ^ self messageIconFor: selector!
- ^ self messageIconFor: (self messageList at: anIndex ifAbsent: [^nil]) asString!