The Trunk: Tools-nice.1034.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tools-nice.1034.mcz

commits-2
Nicolas Cellier uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-nice.1034.mcz

==================== Summary ====================

Name: Tools-nice.1034
Author: nice
Time: 10 April 2021, 10:41:23.083509 pm
UUID: fe72aa70-5707-479b-a576-e2950cfcf6a3
Ancestors: Tools-mt.1033

Quick fix for enabling search of references to a number or other literal from within a message list

Example:
86400 cmd+n
$a cmd+n
#(0) cmd+n

Note: it won't necessarily highlight numbers formatted differently like 16rFF for 255...
This would probably require AST based search.

=============== Diff against Tools-mt.1033 ===============

Item was changed:
  ----- Method: MessageTrace>>addParentMethodsSending: (in category 'building') -----
  addParentMethodsSending: selectorSymbol
 
  | methodsList |
  (methodsList := self systemNavigation allCallsOn: selectorSymbol) isEmpty
  ifTrue:
  [ ^(PopUpMenu labels: ' OK ')
  startUpWithCaption: 'There are no methods that send ', selectorSymbol ]
  ifFalse:
  [ self
  addParentMessages: methodsList
+ autoSelectString: selectorSymbol asString]!
- autoSelectString: selectorSymbol ]
- !


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tools-nice.1034.mcz

marcel.taeumel
Hi Nicolas,

nice catch!

Note that this fix applies to the "Message Trace" tool, which requires the "Trace Messages" preference to be enabled. The regular "Message Set" tool is not affected by this bug/fix. :-)

Best,
Marcel

Am 10.04.2021 22:41:38 schrieb [hidden email] <[hidden email]>:

Nicolas Cellier uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-nice.1034.mcz

==================== Summary ====================

Name: Tools-nice.1034
Author: nice
Time: 10 April 2021, 10:41:23.083509 pm
UUID: fe72aa70-5707-479b-a576-e2950cfcf6a3
Ancestors: Tools-mt.1033

Quick fix for enabling search of references to a number or other literal from within a message list

Example:
86400 cmd+n
$a cmd+n
#(0) cmd+n

Note: it won't necessarily highlight numbers formatted differently like 16rFF for 255...
This would probably require AST based search.

=============== Diff against Tools-mt.1033 ===============

Item was changed:
----- Method: MessageTrace>>addParentMethodsSending: (in category 'building') -----
addParentMethodsSending: selectorSymbol

| methodsList |
(methodsList := self systemNavigation allCallsOn: selectorSymbol) isEmpty
ifTrue:
[ ^(PopUpMenu labels: ' OK ')
startUpWithCaption: 'There are no methods that send ', selectorSymbol ]
ifFalse:
[ self
addParentMessages: methodsList
+ autoSelectString: selectorSymbol asString]!
- autoSelectString: selectorSymbol ]
- !