Smalltalk › Squeak › Squeak - Dev

The Trunk: Tools-nice.210.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Trunk: Tools-nice.210.mcz

Nicolas Cellier uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-nice.210.mcz

==================== Summary ====================

Name: Tools-nice.210
Author: nice
Time: 12 March 2010, 11:02:42.773 pm
UUID: 4b085222-d688-42bd-9471-df5771a211db
Ancestors: Tools-cmm.209

Let the debugger retain context selection when requested for fullStack.

Note: I don't like (self changed: #flash) for these reasons:
- it traverses all dependents (inefficient MVC like process)
- the text flash (not always, I don't know why), not the list from which the menu was triggered.

Maybe it would be better to disable the menu and the button when (contextStack last sender isNil).

=============== Diff against Tools-cmm.209 ===============

Item was changed:
----- Method: Debugger>>fullStack (in category 'context stack menu') -----
fullStack
"Change from displaying the minimal stack to a full one."

+ contextStack last sender isNil
- self contextStackList size > 20 "Already expanded"
ifTrue:
+ ["Already expanded"
+ self changed: #flash]
- [self changed: #flash]
ifFalse:
+ [| oldContextStackIndex |
+ oldContextStackIndex := contextStackIndex.
+ self fullyExpandStack.
+ oldContextStackIndex = contextStackIndex
+ ifFalse:
+ [self toggleContextStackIndex: oldContextStackIndex]]!
- [self contextStackIndex = 0 ifFalse: [
- self toggleContextStackIndex: self contextStackIndex].
- self fullyExpandStack]!

Item was changed:
----- Method: Debugger>>fullyExpandStack (in category 'context stack (message list)') -----
fullyExpandStack
+ "Expand the stack to include all of it, rather than the first four or five contexts.
+ Well, almost all of it, we better maintain sane limits too."
- "Expand the stack to include all of it, rather than the first four or five
- contexts."

self okToChange ifFalse: [^ self].
+ self newStack: (contextStackTop stackOfSize: contextStack size + 100000).
- self newStack: contextStackTop contextStack.
self changed: #contextStackList!

Chris Muller-3

Re: The Trunk: Tools-nice.210.mcz

Thanks for these changes Nicolas, I'm with you on the flashing and,
unless I'm about to format my hard-drive, I also don't really care for
software to ever "beep" at me.

I suppose this sort of thing runs deep for me, it's philosophical.
The software should just do my bidding, without question or intrusion,
and nothing additional please. Don't flash, beep, prompt, or tap me
on the shoulder. Software should go out of its way to make operation
of the software as efficient as possible, not get _in_ my way.
There's a difference..

(rambling..)

On Fri, Mar 12, 2010 at 4:02 PM, <[hidden email]> wrote:

> Nicolas Cellier uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-nice.210.mcz
>
> ==================== Summary ====================
>
> Name: Tools-nice.210
> Author: nice
> Time: 12 March 2010, 11:02:42.773 pm
> UUID: 4b085222-d688-42bd-9471-df5771a211db
> Ancestors: Tools-cmm.209
>
> Let the debugger retain context selection when requested for fullStack.
>
> Note: I don't like (self changed: #flash) for these reasons:
> - it traverses all dependents (inefficient MVC like process)
> - the text flash (not always, I don't know why), not the list from which the menu was triggered.
>
> Maybe it would be better to disable the menu and the button when (contextStack last sender isNil).
>
> =============== Diff against Tools-cmm.209 ===============
>
> Item was changed:
> ----- Method: Debugger>>fullStack (in category 'context stack menu') -----
> fullStack
> "Change from displaying the minimal stack to a full one."
>
> + contextStack last sender isNil
> - self contextStackList size > 20 "Already expanded"
> ifTrue:
> + ["Already expanded"
> + self changed: #flash]
> - [self changed: #flash]
> ifFalse:
> + [| oldContextStackIndex |
> + oldContextStackIndex := contextStackIndex.
> + self fullyExpandStack.
> + oldContextStackIndex = contextStackIndex
> + ifFalse:
> + [self toggleContextStackIndex: oldContextStackIndex]]!
> - [self contextStackIndex = 0 ifFalse: [
> - self toggleContextStackIndex: self contextStackIndex].
> - self fullyExpandStack]!
>
> Item was changed:
> ----- Method: Debugger>>fullyExpandStack (in category 'context stack (message list)') -----
> fullyExpandStack
> + "Expand the stack to include all of it, rather than the first four or five contexts.
> + Well, almost all of it, we better maintain sane limits too."
> - "Expand the stack to include all of it, rather than the first four or five
> - contexts."
>
> self okToChange ifFalse: [^ self].
> + self newStack: (contextStackTop stackOfSize: contextStack size + 100000).
> - self newStack: contextStackTop contextStack.
> self changed: #contextStackList!
>
>
>