The Trunk: Tools-nice.472.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Tools-nice.472.mcz

commits-2
Nicolas Cellier uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-nice.472.mcz

==================== Summary ====================

Name: Tools-nice.472
Author: nice
Time: 18 June 2013, 10:36:32.295 pm
UUID: 44e681e0-42bc-4490-afdc-37b505e70df4
Ancestors: Tools-eem.471

Why making one UI request to UIManager default and the other to Utilities?
Let's make the two  requests to UIManager default.

=============== Diff against Tools-eem.471 ===============

Item was changed:
  ----- Method: ChangeSorter>>rename (in category 'changeSet menu') -----
  rename
  "Store a new name string into the selected ChangeSet.  reject duplicate name; allow user to back out"
 
  | newName |
  newName := UIManager default request: 'New name for this change set'
  initialAnswer: myChangeSet name.
  (newName = myChangeSet name or: [newName size = 0]) ifTrue:
  [^ Beeper beep].
 
  (self class changeSetNamed: newName) ifNotNil:
+ [^ UIManager default inform: 'Sorry that name is already used'].
- [^ Utilities inform: 'Sorry that name is already used'].
 
  myChangeSet name: newName.
  self update.
  self changed: #mainButtonName.
  self changed: #relabel.!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Tools-nice.472.mcz

Frank Shearar-3
On 18 June 2013 21:36,  <[hidden email]> wrote:

> Nicolas Cellier uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-nice.472.mcz
>
> ==================== Summary ====================
>
> Name: Tools-nice.472
> Author: nice
> Time: 18 June 2013, 10:36:32.295 pm
> UUID: 44e681e0-42bc-4490-afdc-37b505e70df4
> Ancestors: Tools-eem.471
>
> Why making one UI request to UIManager default and the other to Utilities?
> Let's make the two  requests to UIManager default.
>
> =============== Diff against Tools-eem.471 ===============
>
> Item was changed:
>   ----- Method: ChangeSorter>>rename (in category 'changeSet menu') -----
>   rename
>         "Store a new name string into the selected ChangeSet.  reject duplicate name; allow user to back out"
>
>         | newName |
>         newName := UIManager default request: 'New name for this change set'
>                                                 initialAnswer: myChangeSet name.
>         (newName = myChangeSet name or: [newName size = 0]) ifTrue:
>                         [^ Beeper beep].
>
>         (self class changeSetNamed: newName) ifNotNil:
> +                       [^ UIManager default inform: 'Sorry that name is already used'].
> -                       [^ Utilities inform: 'Sorry that name is already used'].
>
>         myChangeSet name: newName.
>         self update.
>         self changed: #mainButtonName.
>         self changed: #relabel.!


Yay!

frank