The Trunk: ToolsTests-eem.84.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: ToolsTests-eem.84.mcz

commits-2
Eliot Miranda uploaded a new version of ToolsTests to project The Trunk:
http://source.squeak.org/trunk/ToolsTests-eem.84.mcz

==================== Summary ====================

Name: ToolsTests-eem.84
Author: eem
Time: 24 September 2018, 3:18:21.652672 pm
UUID: 249d8808-6c0c-4dd5-99fc-b2eb25d6fefe
Ancestors: ToolsTests-eem.83

Fix testAlphabetizeMessageCategories; sorting now separates out extensions, non-private categories and private categories.

=============== Diff against ToolsTests-eem.83 ===============

Item was changed:
  ----- Method: BrowserTest>>testAlphabetizeMessageCategories (in category 'as yet unclassified') -----
  testAlphabetizeMessageCategories
+ | categories |
  browser selectSystemCategory: browser class category.
  self deny: browser alphabetizeMessageCategories.
 
  browser selectClass: browser class.
  browser metaClassIndicated: false.
  self assert: browser alphabetizeMessageCategories.
+ categories := browser classOrMetaClassOrganizer categories.
+ self assert: (categories select: [:c| c first == $*]) isSorted.
+ self assert: (categories select: [:c| c beginsWith: 'private']) isSorted.
+ self assert: (categories reject: [:c| c first == $* or: [c beginsWith: 'private']]) isSorted.
- self assert: browser classOrMetaClassOrganizer categories isSorted.
 
  browser metaClassIndicated: true.
  self assert: browser alphabetizeMessageCategories.
  self assert: browser classOrMetaClassOrganizer categories isSorted.!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ToolsTests-eem.84.mcz

Tobias Pape
Hi,

> Gesendet: Dienstag, 25. September 2018 um 00:18 Uhr
> Von: [hidden email]
> An: [hidden email], [hidden email]
> Betreff: [squeak-dev] The Trunk: ToolsTests-eem.84.mcz
>
> Eliot Miranda uploaded a new version of ToolsTests to project The Trunk:
> http://source.squeak.org/trunk/ToolsTests-eem.84.mcz
>
> ==================== Summary ====================
>
> Name: ToolsTests-eem.84
> Author: eem
> Time: 24 September 2018, 3:18:21.652672 pm
> UUID: 249d8808-6c0c-4dd5-99fc-b2eb25d6fefe
> Ancestors: ToolsTests-eem.83
>
> Fix testAlphabetizeMessageCategories; sorting now separates out extensions, non-private categories and private categories.
>
> =============== Diff against ToolsTests-eem.83 ===============
>
> Item was changed:
>   ----- Method: BrowserTest>>testAlphabetizeMessageCategories (in category 'as yet unclassified') -----
>   testAlphabetizeMessageCategories
> + | categories |
>   browser selectSystemCategory: browser class category.
>   self deny: browser alphabetizeMessageCategories.
>  
>   browser selectClass: browser class.
>   browser metaClassIndicated: false.
>   self assert: browser alphabetizeMessageCategories.
> + categories := browser classOrMetaClassOrganizer categories.
> + self assert: (categories select: [:c| c first == $*]) isSorted.
> + self assert: (categories select: [:c| c beginsWith: 'private']) isSorted.

Interesting, I didn't know that we sorted private categories differently. Sounds handy :)

Best regards
    -Tobias


> + self assert: (categories reject: [:c| c first == $* or: [c beginsWith: 'private']]) isSorted.
> - self assert: browser classOrMetaClassOrganizer categories isSorted.
>  
>   browser metaClassIndicated: true.
>   self assert: browser alphabetizeMessageCategories.
>   self assert: browser classOrMetaClassOrganizer categories isSorted.!
>
>
>