The Trunk: ToolsTests-fbs.55.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: ToolsTests-fbs.55.mcz

commits-2
Frank Shearar uploaded a new version of ToolsTests to project The Trunk:
http://source.squeak.org/trunk/ToolsTests-fbs.55.mcz

==================== Summary ====================

Name: ToolsTests-fbs.55
Author: fbs
Time: 14 August 2012, 10:17:58.815 pm
UUID: b62da178-5c7f-4e7d-9b1d-f679c919d4bf
Ancestors: ToolsTests-fbs.54

The recent #tokenish changes changed the dependencies of Collections (because Scanner now uses Character), and breaking this test.

The moral of the story is that we should be checking the tools against mock data, which requires separating the UI from the data.

=============== Diff against ToolsTests-fbs.54 ===============

Item was changed:
  ----- Method: DependencyBrowserTest>>testClassList (in category 'testing - class list') -----
  testClassList
  "Warning!! When Collections' dependencies change, this test may start to fail!!"
  self assert: #() equals: browser classList description: 'classList before package selection'.
 
  browser packageListIndex: (browser packageList indexOf: #Collections).
  self assert: #() equals: browser classList description: 'classList after selecting Collections'.
 
  browser packageDepsIndex: (browser packageDeps indexOf: #Compiler).
  self assert: #() equals: browser classList description: 'classList after selecting Compiler'.
 
  browser classDepsIndex: (browser classDeps indexOf: #Scanner).
+ self assert: #(Character String Symbol 'Symbol class') equals: browser classList description: 'classList after selecting Scanner class'.
- self assert: #(String Symbol 'Symbol class') equals: browser classList description: 'classList after selecting Scanner class'.
 
  browser classListIndex: (browser classList indexOf: #Symbol).
+ self assert: #(Character String Symbol 'Symbol class') equals: browser classList description: 'classList after selecting Symbol class'.!
- self assert: #(String Symbol 'Symbol class') equals: browser classList description: 'classList after selecting Symbol class'.!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ToolsTests-fbs.55.mcz

Colin Putney-3
On Tue, Aug 14, 2012 at 2:18 PM, <[hidden email]> wrote:

> The recent #tokenish changes changed the dependencies of Collections
> (because Scanner now uses Character), and breaking this test.
>
> The moral of the story is that we should be checking the tools against
> mock data, which requires separating the UI from the data.

Yes.

Also, it hints that #tokenish should be part of the Compiler package.
Probably best to leave it be until 4.5, though.

Colin