The Trunk: ToolsTests-mt.96.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: ToolsTests-mt.96.mcz

commits-2
Marcel Taeumel uploaded a new version of ToolsTests to project The Trunk:
http://source.squeak.org/trunk/ToolsTests-mt.96.mcz

==================== Summary ====================

Name: ToolsTests-mt.96
Author: mt
Time: 15 May 2020, 10:17:11.552447 am
UUID: 60cf49eb-5d79-5244-8b92-930d37256988
Ancestors: ToolsTests-mt.95

Fixes tests for CompiledCodeInspector.

Hmm... Maybe #compiledCode would be a better accessor for BlockClosure? Comparing with #sourceCode?

=============== Diff against ToolsTests-mt.95 ===============

Item was changed:
  ----- Method: CompiledCodeInspectorTest>>createObject (in category 'running') -----
  createObject
  "Note that we cannot return the block directly but require the indirection of #evaluate: because the resulting block will be modified during the tests. A block directly embedded in this #createObject method, however, would be re-used across test runs."
 
  InnerTestObject := super createObject.
  ^ Compiler new
+ evaluate: '[String withAll: #[67 97 114 112 101] "Carpe", #Squeak, InnerTestObject printString] method'
- evaluate: '[String withAll: #[67 97 114 112 101] "Carpe", #Squeak, InnerTestObject printString] compiledBlock'
  in: nil
  to: self "Required for access to InnerTestObject"!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ToolsTests-mt.96.mcz

Christoph Thiede

Maybe #compiledCode would be a better accessor for BlockClosure?


+1 :-)

#method is really confusing if we expect a CompiledBlock.


Best,

Christoph


Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Freitag, 15. Mai 2020 10:17:13
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: ToolsTests-mt.96.mcz
 
Marcel Taeumel uploaded a new version of ToolsTests to project The Trunk:
http://source.squeak.org/trunk/ToolsTests-mt.96.mcz

==================== Summary ====================

Name: ToolsTests-mt.96
Author: mt
Time: 15 May 2020, 10:17:11.552447 am
UUID: 60cf49eb-5d79-5244-8b92-930d37256988
Ancestors: ToolsTests-mt.95

Fixes tests for CompiledCodeInspector.

Hmm... Maybe #compiledCode would be a better accessor for BlockClosure? Comparing with #sourceCode?

=============== Diff against ToolsTests-mt.95 ===============

Item was changed:
  ----- Method: CompiledCodeInspectorTest>>createObject (in category 'running') -----
  createObject
         "Note that we cannot return the block directly but require the indirection of #evaluate: because the resulting block will be modified during the tests. A block directly embedded in this #createObject method, however, would be re-used across test runs."
        
         InnerTestObject := super createObject.
         ^ Compiler new
+                evaluate: '[String withAll: #[67 97 114 112 101] "Carpe", #Squeak, InnerTestObject printString] method'
-                evaluate: '[String withAll: #[67 97 114 112 101] "Carpe", #Squeak, InnerTestObject printString] compiledBlock'
                 in: nil
                 to: self "Required for access to InnerTestObject"!




Carpe Squeak!