The Trunk: ToolsTests-mt.97.mcz

Marcel Taeumel uploaded a new version of ToolsTests to project The Trunk:
http://source.squeak.org/trunk/ToolsTests-mt.97.mcz

==================== Summary ====================

Name: ToolsTests-mt.97
Author: mt
Time: 12 June 2020, 12:53:45.299703 pm
UUID: fdb31778-cee3-5442-ba38-e3c12f80f610
Ancestors: ToolsTests-mt.96

Complements Tools-mt.975

=============== Diff against ToolsTests-mt.96 ===============

Item was changed:
  ----- Method: DependencyBrowserTest>>testClassList (in category 'tests - class list') -----
  testClassList
  "Warning!! When Collections' dependencies change, this test may start to fail!!"
  self assert: #() equals: browser classList description: 'classList before package selection'.
 
  browser packageListIndex: (browser packageList indexOf: #Collections).
  self
  assert: #()
+ equals: browser classList
- equals: browser classList
  description: 'classList after selecting Collections'.
 
  browser packageDepsIndex: (browser packageDeps indexOf: #Compiler).
  self
+ assert: browser classList notEmpty
- assert: #()
- equals: browser classList
  description: 'classList after selecting Compiler'.
 
  browser classDepsIndex: (browser classDeps indexOf: #Scanner).
  self
  assert: #(Character String Symbol 'Symbol class')
  equals: browser classList
  description: 'classList after selecting Scanner class'.
 
  browser classListIndex: (browser classList indexOf: #Symbol).
  self
  assert: #(Character String Symbol 'Symbol class')
  equals: browser classList
  description: 'classList after selecting Symbol class'.!

Item was changed:
  ----- Method: DependencyBrowserTest>>testSelectedMessageName (in category 'tests - message list') -----
  testSelectedMessageName
  "Warning!! When Collections' dependencies change, this test may start to fail!!"
  self assert: browser selectedMessageName isNil.
 
  browser packageListIndex: (browser packageList indexOf: #Collections).
  self assert: browser selectedMessageName isNil.
 
  browser packageDepsIndex: (browser packageDeps indexOf: #Compiler).
  self assert: browser selectedMessageName isNil.
 
  browser classDepsIndex: (browser classDeps indexOf: #Scanner).
  self assert: browser selectedMessageName isNil.
 
  browser classListIndex: (browser classList indexOf: #Symbol).
+ self assert: browser selectedMessageName == #storeOn:.
- self assert: browser selectedMessageName isNil.
 
  browser messageListIndex: 1.
  self assert: browser selectedMessageName == #storeOn:.
 
  browser messageListIndex: 0.
  self assert: browser selectedMessageName isNil.!

Item was changed:
  ----- Method: DependencyBrowserTest>>testSelectedMessageNameClassSide (in category 'tests - message list') -----
  testSelectedMessageNameClassSide
  "Warning!! When Collections' dependencies change, this test may start to fail!!"
  self assert: browser selectedMessageName isNil.
 
  browser packageListIndex: (browser packageList indexOf: #'Chronology-Core').
  self assert: browser selectedMessageName isNil.
 
  browser packageDepsIndex: (browser packageDeps indexOf: #Collections).
  self assert: browser selectedMessageName isNil.
 
  browser classDepsIndex: (browser classDeps indexOf: #Array).
  self assert: browser selectedMessageName isNil.
 
  browser classListIndex: (browser classList indexOf: #'DateAndTime').
+ self assert: browser selectedMessageName == #ticks.
- self assert: browser selectedMessageName isNil.
 
  browser messageListIndex: 1.
  self assert: browser selectedMessageName == #ticks.
  !

On 12/06/20 10:53 am, [hidden email] wrote:
> + self assert: browser selectedMessageName == #storeOn:.
Marcel,

Isn't assert:identical: better for such tests? If the assert fails, the
mismatched value can easily be seen in the debugger.

Regards .. Subbu