The Trunk: ToolsTests-nice.104.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: ToolsTests-nice.104.mcz

commits-2
Nicolas Cellier uploaded a new version of ToolsTests to project The Trunk:
http://source.squeak.org/trunk/ToolsTests-nice.104.mcz

==================== Summary ====================

Name: ToolsTests-nice.104
Author: nice
Time: 19 April 2021, 7:10:52.441183 pm
UUID: 1ddda785-3f79-1643-bdc5-bf74b3123646
Ancestors: ToolsTests-nice.103

Fix the somehow fragile testSelectedMessageName.

Serious tests would require some form of well controlled mocks, but is it really worth?

=============== Diff against ToolsTests-nice.103 ===============

Item was changed:
  ----- Method: DependencyBrowserTest>>testSelectedMessageName (in category 'tests - message list') -----
  testSelectedMessageName
  "Warning!! When Collections' dependencies change, this test may start to fail!!"
  self assert: browser selectedMessageName isNil.
 
  browser packageListIndex: (browser packageList indexOf: #Collections).
  self assert: browser selectedMessageName isNil.
 
  browser packageDepsIndex: (browser packageDeps indexOf: #Compiler).
  self assert: browser selectedMessageName isNil.
 
  browser classDepsIndex: (browser classDeps indexOf: #Scanner).
  self assert: browser selectedMessageName isNil.
 
  browser classListIndex: (browser classList indexOf: #Symbol).
+ self assert: browser selectedMessageName == #isMessageSelector.
- self assert: browser selectedMessageName == #storeOn:.
 
  browser messageListIndex: 1.
+ self assert: browser selectedMessageName == #isMessageSelector.
- self assert: browser selectedMessageName == #storeOn:.
 
  browser messageListIndex: 0.
  self assert: browser selectedMessageName isNil.!