The Trunk: WebClient-Core-tobe.121.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: WebClient-Core-tobe.121.mcz

commits-2
Marcel Taeumel uploaded a new version of WebClient-Core to project The Trunk:
http://source.squeak.org/trunk/WebClient-Core-tobe.121.mcz

==================== Summary ====================

Name: WebClient-Core-tobe.121
Author: tobe
Time: 7 May 2020, 9:23:39.84201 pm
UUID: c6e964fd-dbe1-41dc-8724-e9b825130b7e
Ancestors: WebClient-Core-tobe.120

ignore content as stated in rfc7230, if:
- we have a HEAD request
- code is 1xx
- code is 204 No Content
- code is 304 Not Modified

=============== Diff against WebClient-Core-nice.119 ===============

Item was changed:
  ----- Method: WebResponse>>getContent (in category 'private') -----
  getContent
+ "   Any response to a HEAD request and any response with a 1xx
+        (Informational), 204 (No Content), or 304 (Not Modified) status
+        code is always terminated by the first empty line after the
+        header fields, regardless of the header fields present in the
+        message, and thus cannot contain a message body.
+ - https://tools.ietf.org/html/rfc7230#section-3.3.3 "
+
+ (request method = 'HEAD' or: [(code between: 100 and: 199) or: [code = 204 or: [code = 304]]]) ifTrue:[^''].
- "Do not read any content if this was a HEAD request or code is 204 (no content)"
- (request method = 'HEAD' or: [code = 204]) ifTrue:[^''].
  ^super getContent!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: WebClient-Core-tobe.121.mcz

marcel.taeumel
Hi all!

I just backported this fix to 5.3, 5.2, and 5.1.

Best,
Marcel

Am 08.05.2020 08:56:32 schrieb [hidden email] <[hidden email]>:

Marcel Taeumel uploaded a new version of WebClient-Core to project The Trunk:
http://source.squeak.org/trunk/WebClient-Core-tobe.121.mcz

==================== Summary ====================

Name: WebClient-Core-tobe.121
Author: tobe
Time: 7 May 2020, 9:23:39.84201 pm
UUID: c6e964fd-dbe1-41dc-8724-e9b825130b7e
Ancestors: WebClient-Core-tobe.120

ignore content as stated in rfc7230, if:
- we have a HEAD request
- code is 1xx
- code is 204 No Content
- code is 304 Not Modified

=============== Diff against WebClient-Core-nice.119 ===============

Item was changed:
----- Method: WebResponse>>getContent (in category 'private') -----
getContent
+ " Any response to a HEAD request and any response with a 1xx
+ (Informational), 204 (No Content), or 304 (Not Modified) status
+ code is always terminated by the first empty line after the
+ header fields, regardless of the header fields present in the
+ message, and thus cannot contain a message body.
+ - https://tools.ietf.org/html/rfc7230#section-3.3.3 "
+
+ (request method = 'HEAD' or: [(code between: 100 and: 199) or: [code = 204 or: [code = 304]]]) ifTrue:[^''].
- "Do not read any content if this was a HEAD request or code is 204 (no content)"
- (request method = 'HEAD' or: [code = 204]) ifTrue:[^''].
^super getContent!