Smalltalk › Squeak › Squeak - Dev

Underscore assignments (was: Re: [squeak-dev] The Trunk: Graphics-nice.143.mcz)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Levente Uzonyi-2

Underscore assignments (was: Re: [squeak-dev] The Trunk: Graphics-nice.143.mcz)

On Tue, 13 Jul 2010, [hidden email] wrote:

> Nicolas Cellier uploaded a new version of Graphics to project The Trunk:
> http://source.squeak.org/trunk/Graphics-nice.143.mcz
>
> ==================== Summary ====================
>
> Name: Graphics-nice.143
> Author: nice
> Time: 13 July 2010, 8:53:47.189 pm
> UUID: 73b2435d-0711-4319-a602-5e5b997209d6
> Ancestors: Graphics-jcg.142
>
> _ -> :=

What about changing all underscore assignments to ansi in one shot with
the Refactoring Engine or the FixUnderscores utility?

Levente

>
> =============== Diff against Graphics-jcg.142 ===============
>
> Item was changed:
> ----- Method: Point>>normal (in category 'point functions') -----
> normal
> "Answer a Point representing the unit vector rotated 90 deg clockwise.
> For the zero point return a normal of -1@0 ."
>
> | n d |
>
> + n := y negated @ x.
> - n _ y negated @ x.
> (d := (n x * n x + (n y * n y))) = 0 ifTrue: [ ^ -1 @0 ] .
> ^n / d sqrt!
>
>
>

Nicolas Cellier

Re: Underscore assignments (was: Re: [squeak-dev] The Trunk: Graphics-nice.143.mcz)

2010/7/13 Levente Uzonyi <[hidden email]>

On Tue, 13 Jul 2010, [hidden email] wrote:

Nicolas Cellier uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-nice.143.mcz

==================== Summary ====================

Name: Graphics-nice.143
Author: nice
Time: 13 July 2010, 8:53:47.189 pm
UUID: 73b2435d-0711-4319-a602-5e5b997209d6
Ancestors: Graphics-jcg.142

_ -> :=

What about changing all underscore assignments to ansi in one shot with the Refactoring Engine or the FixUnderscores utility?

Yes, if you want. I don't know if the 1st preserves method stamps nor if the latter never fails...
Anyway, one should do this from a clean image.
Mine was not, so this was just the result of some random Browsing...

Nicolas

Levente

=============== Diff against Graphics-jcg.142 ===============

Item was changed:
----- Method: Point>>normal (in category 'point functions') -----
normal
"Answer a Point representing the unit vector rotated 90 deg clockwise.
For the zero point return a normal of -1@0 ."

| n d |

+ n := y negated @ x.
- n _ y negated @ x.
(d := (n x * n x + (n y * n y))) = 0 ifTrue: [ ^ -1 @0 ] .
^n / d sqrt!

Andreas.Raab

Re: Underscore assignments

On 7/13/2010 12:30 PM, Nicolas Cellier wrote:

>
>
> 2010/7/13 Levente Uzonyi <[hidden email] <mailto:[hidden email]>>
>
> On Tue, 13 Jul 2010, [hidden email]
> <mailto:[hidden email]> wrote:
>
> Nicolas Cellier uploaded a new version of Graphics to project
> The Trunk:
> http://source.squeak.org/trunk/Graphics-nice.143.mcz
>
> ==================== Summary ====================
>
> Name: Graphics-nice.143
> Author: nice
> Time: 13 July 2010, 8:53:47.189 pm
> UUID: 73b2435d-0711-4319-a602-5e5b997209d6
> Ancestors: Graphics-jcg.142
>
> _ -> :=
>
>
> What about changing all underscore assignments to ansi in one shot
> with the Refactoring Engine or the FixUnderscores utility?
>
>
> Yes, if you want. I don't know if the 1st preserves method stamps nor if
> the latter never fails...
> Anyway, one should do this from a clean image.

And keep in mind that updating class initializers will cause them to run
again when loaded. Might want to test this before the commit :-)

Cheers,
- Andreas

Chris Muller-3

Re: Underscore assignments (was: Re: [squeak-dev] The Trunk: Graphics-nice.143.mcz)

In reply to this post by Nicolas Cellier

>> What about changing all underscore assignments to ansi in one shot with
>> the Refactoring Engine or the FixUnderscores utility?
>>
>
> Yes, if you want. I don't know if the 1st preserves method stamps nor if the
> latter never fails...
> Anyway, one should do this from a clean image.
> Mine was not, so this was just the result of some random Browsing...

The first does NOT preserve method stamps. Please do not do it that
way. Any underscore-repair should be done with the FixUnderscores
package, which preserves the accounting information and works plenty
fine.

Thanks..
Chris

>
> Nicolas
>
>>
>> Levente
>>
>>>
>>> =============== Diff against Graphics-jcg.142 ===============
>>>
>>> Item was changed:
>>> ----- Method: Point>>normal (in category 'point functions') -----
>>> normal
>>> "Answer a Point representing the unit vector rotated 90 deg
>>> clockwise.
>>> For the zero point return a normal of -1@0 ."
>>>
>>> | n d |
>>>
>>> + n := y negated @ x.
>>> - n _ y negated @ x.
>>> (d := (n x * n x + (n y * n y))) = 0 ifTrue: [ ^ -1 @0 ] .
>>> ^n / d sqrt!
>>>
>>>
>>>
>>
>
>
>
>
>