UpdatingStringMorph broken in 5.3

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

UpdatingStringMorph broken in 5.3

Stéphane Rollandin
Hello,

If you do

  (UpdatingStringMorph on: Time selector: #now) openInHand.

in the trunk 5.3 image, the display will not get updated.

This can be fixed by adding a #changed in StringMorph>>#contents: as follow:


StringMorph>>#contents: newContents

        newContents isText
                ifTrue: [^ self initializeFromText: newContents].

        contents = newContents
                ifTrue: [^ self "no substantive change"].

        contents := newContents.
       
        self fitContents; changed


Maybe the #changed should be added to #fitContents itself. Can someone
check this?

Stef