Dave Lewis uploaded a new version of VMMaker to project VM Maker: http://www.squeaksource.com/VMMaker/VMMaker-dtl.191.mcz ==================== Summary ==================== Name: VMMaker-dtl.191 Author: dtl Time: 8 October 2010, 3:52:12 am UUID: f82f1668-dd8b-417b-b546-320e2a713272 Ancestors: VMMaker-dtl.190 VMMaker 4.3.5 Adopt JPEGReaderWriter2Plugin from oscog. JPEGReaderWriter2Plugin is gives incorrect results as reported by Bert: http://lists.squeakfoundation.org/pipermail/vm-dev/2010-September/005481.html And on my system, the plugin crashes the VM outright. JPEGReaderWriter2Plugin from oscog branch works correctly. Merging the differences did not produce a happy result, therefore adopt the working oscog version. Follow up may be required to add intended changes from John's 64-bit updates as detailed below: #primJPEGReadHeader:fromByteArray:errorMgr: The oscog version contains parameter type declarations that are missing from the vmmaker trunk. The oscog version is stamped 4/4/2006, so this is just something that did not get included in trunk. Oscog version is correct, adopt in in trunk. #primJPEGReadImage:fromByteArray:onForm:doDithering:errorMgr: Oscog contains type declarations missing from trunk. Trunk contains John's type declaration fixes for 64-bit. Merging the two does not produce a working version, therefore adopt oscog version. This update removes the changes that were introduced in John's update of 1/4/2010. #primJPEGWriteImage:onByteArray:form:quality:progressiveJPEG:errorMgr: Oscog contains type declarations missing from trunk. Trunk contains John's type declaration fixes for 64-bit. Merging the two does not produce a working version, therefore adopt oscog version.This update removes the changes that were introduced in John's update of 1/4/2010. |
Ok, well the off by one error (j=1) likely causes a crash because it would write a word off the end of the targeted form or array. If you fall back to the oscog version that won't run as a 64bit vm on a 32bit image. On 2010-10-08, at 2:54 PM, [hidden email] wrote: > > Dave Lewis uploaded a new version of VMMaker to project VM Maker: > http://www.squeaksource.com/VMMaker/VMMaker-dtl.191.mcz > > ==================== Summary ==================== > > Name: VMMaker-dtl.191 > Author: dtl > Time: 8 October 2010, 3:52:12 am > UUID: f82f1668-dd8b-417b-b546-320e2a713272 > Ancestors: VMMaker-dtl.190 > > VMMaker 4.3.5 > Adopt JPEGReaderWriter2Plugin from oscog. > > JPEGReaderWriter2Plugin is gives incorrect results as reported by Bert: > http://lists.squeakfoundation.org/pipermail/vm-dev/2010-September/005481.html > And on my system, the plugin crashes the VM outright. > > JPEGReaderWriter2Plugin from oscog branch works correctly. > > Merging the differences did not produce a happy result, therefore adopt the working oscog version. Follow up may be required to add intended changes from John's 64-bit updates as detailed below: > > #primJPEGReadHeader:fromByteArray:errorMgr: > The oscog version contains parameter type declarations that are missing from the vmmaker trunk. The oscog version is stamped 4/4/2006, so this is just something that did not get included in trunk. Oscog version is correct, adopt in in trunk. > > #primJPEGReadImage:fromByteArray:onForm:doDithering:errorMgr: > Oscog contains type declarations missing from trunk. Trunk contains John's type declaration fixes for 64-bit. Merging the two does not produce a working version, therefore adopt oscog version. This update removes the changes that were introduced in John's update of 1/4/2010. > > #primJPEGWriteImage:onByteArray:form:quality:progressiveJPEG:errorMgr: > Oscog contains type declarations missing from trunk. Trunk contains John's type declaration fixes for 64-bit. Merging the two does not produce a working version, therefore adopt oscog version.This update removes the changes that were introduced in John's update of 1/4/2010. > =========================================================================== John M. McIntosh <[hidden email]> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com =========================================================================== smime.p7s (5K) Download Attachment |
Free forum by Nabble | Edit this page |