Smalltalk › Pharo › Pharo Smalltalk Users

What should I do when I get a fogbugz "Fix review needed"?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Tim Mackinnon

Jul 22, 2014; 3:10pm

What should I do when I get a fogbugz "Fix review needed"?

If I report a bug in fogbugz and it later gets fixed, I get an email with the slice its fixed in.

So I’ve loaded the slice into the latest image - then I’ve done “merge” (I’m still not clear on whether I should do merge or load? I think I understand that I need merge to just get those fixes?).

Having retested my bug, and found that it has been fixed - I entered a comment saying which image version I tested it in, but then I’m not sure what I should do with the status?

Can someone just clarify that for me?

Tim

Nicolai Hess

Jul 22, 2014; 4:48pm

Re: What should I do when I get a fogbugz "Fix review needed"?

2014-07-22 17:10 GMT+02:00 Tim Mackinnon <[hidden email]>:

If I report a bug in fogbugz and it later gets fixed, I get an email with the slice its fixed in.

So I’ve loaded the slice into the latest image - then I’ve done “merge” (I’m still not clear on whether I should do merge or load? I think I understand that I need merge to just get those fixes?).

Having retested my bug, and found that it has been fixed - I entered a comment saying which image version I tested it in, but then I’m not sure what I should do with the status?

Can someone just clarify that for me?

Tim

Just wait:)

someone from the integrator team will include this change.
It depends on the current work for other issues that has to be done, free time and the issue priority.

Damien Cassou

Jul 23, 2014; 2:37pm

Re: What should I do when I get a fogbugz "Fix review needed"?

In reply to this post by Tim Mackinnon

On Tue, Jul 22, 2014 at 5:10 PM, Tim Mackinnon <[hidden email]> wrote:
> Can someone just clarify that for me?

you should also mark it as "fix reviewed"

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm."
Winston Churchill

Sean P. DeNigris

Jul 24, 2014; 1:31am

Re: What should I do when I get a fogbugz "Fix review needed"?

Administrator

In reply to this post by Tim Mackinnon

Tim Mackinnon wrote

then I’ve done “merge” (I’m still not clear on whether I should do merge or load?

You were correct. "Always" merge slices.

Cheers,
Sean

Ben Coman

Jul 24, 2014; 4:20pm

Re: What should I do when I get a fogbugz "Fix review needed"?

Sean P. DeNigris wrote:

Tim Mackinnon wrote

then I’ve done “merge” (I’m still not clear on whether I should do merge
or load?


You were correct. "Always" merge slices.



-----
Cheers,
Sean
--
View this message in context: http://forum.world.st/What-should-I-do-when-I-get-a-fogbugz-Fix-review-needed-tp4769395p4769709.html
Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.

... [show rest of quote]

One tip (something I like to do anyway...) is view "Changes" first, and make that window unclosable (from the window's system menu) and use that to navigate around the code after I merge - click on method and 'Browse class' from its context menu - because once you load the slice its harder to go back to remember what was changed.

cheers -ben